vcpkg
#30822
This check was added for vcpkg, given how it packages Boost. However, we don’t need to run the check for other platforms, and it’s quite slow. So, scope it to just vcpkg.
On my machine, this reduces the time to run time cmake -B build from ~12 seconds, to ~6 seconds.
Fixes: #30787.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | hebasto, kevkevinpal, maflcko, davidgumberg |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
63@@ -64,9 +64,9 @@ function(add_boost_if_needed)
64 set(CMAKE_REQUIRED_DEFINITIONS)
65 endif()
66
67- if(BUILD_TESTS)
68- # Some package managers, such as vcpkg, vendor Boost.Test separately
69- # from the rest of the headers, so we have to check for it individually.
70+# Some package managers, such as vcpkg, vendor Boost.Test separately
.cmake-format.yml, so feel free to ignore.
review ACK dda17b44e7a680412a231e64a5a09120a850bb1f
The alternative #30787 (comment) seems fine as well.
This check was added for vcpkg, given how it packages Boost. However, we
don't need to run the check for other platforms, and it's quite slow.
So, scope it to VCPKG. On my machine, this reduces the time to run
`cmake -B build` from ~12 seconds, to ~6 seconds.
Fixes: #30787
The alternative #30787 (comment) seems fine as well.
This PR change is minimal.
Tested ACK https://github.com/bitcoin/bitcoin/commit/a7a4e11db8722c85175bcc4d9f73a713e9e61513
This branch reduces the amount of time that cmake -B build takes on my setup by 52% from 26.749 seconds to 12.649 seconds:
0$ git switch 30822
1Switched to branch '30822'
2
3$ hyperfine --warmup 3 --runs 10 --prepare "git clean -dfx" "cmake -B build"
4Benchmark 1: cmake -B build
5 Time (mean ± σ): 12.649 s ± 0.113 s [User: 6.748 s, System: 5.765 s]
6 Range (min … max): 12.487 s … 12.813 s 10 runs
7
8$ git switch d661e2b --detach
9HEAD is now at d661e2b1b7 Merge bitcoin/bitcoin#30812: lint: Check for release note snippets in the wrong folder
10
11$ hyperfine --warmup 3 --runs 10 --prepare "git clean -dfx" "cmake -B build"
12Benchmark 1: cmake -B build
13 Time (mean ± σ): 26.749 s ± 0.317 s [User: 19.094 s, System: 7.420 s]
14 Range (min … max): 26.345 s … 27.354 s 10 runs