test: autogenerate bash completion #30860

pull BrandonOdiwuor wants to merge 3 commits into bitcoin:master from BrandonOdiwuor:bash-completion changing 10 files +497 −57
  1. BrandonOdiwuor commented at 8:26 am on September 10, 2024: contributor

    Fixes #17289, and follows up on #18606

    Adds a functional test that parses available RPC commands, generates the associated bitcoin-cli autocomplete file and checks that the current autocomplete file matches.

    An outdated autocomplete file can be updated via the –overwrite test parameter.

  2. rpc: add format command with support for args_cli
     - add format command to get infos about commands via a particular format
     - add output format args_cli to get arguments type info of shown commands
     - refactor RPCArg::ToTypeString to be used accross multiple output formats
     - overload CRPCTable::execute to call != methods than in their request
    
    Co-authored-by: pierrenn <git@pnn.sh>
    845842efd7
  3. contrib: sync bitcoin-cli bash autocompletion 6a825c1035
  4. test: keeps bitcoin-cli autocomplete in sync
    Adds a functional test which parses available RPC commands, generates
    the associated bitcoin-cli autcomplete file and checks that the current
    autocomplete matches the file
    An outdated autcomplete file can be updated using the --overwrite parameter
    
    Co-authored-by: pierrenn <git@pnn.sh>
    490103035b
  5. DrahtBot commented at 8:26 am on September 10, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #30937 (build: scripted-diff: drop config/ subdir for bitcoin-config.h by theStack)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. DrahtBot added the label Tests on Sep 10, 2024
  7. fanquake commented at 3:44 pm on September 10, 2024: member

    https://github.com/bitcoin/bitcoin/actions/runs/10788681404/job/29919981336?pr=30860#step:7:3564:

    0Run rpc with args ['/Users/runner/work/bitcoin/bitcoin/ci/scratch/build-x86_64-apple-darwin/src/test/fuzz/fuzz', PosixPath('/Users/runner/work/bitcoin/bitcoin/ci/scratch/qa-assets/fuzz_corpora/rpc')]Error: RPC command "format" not found in RPC_COMMANDS_SAFE_FOR_FUZZING or RPC_COMMANDS_NOT_SAFE_FOR_FUZZING. Please update src/test/fuzz/rpc.cpp.
    1libc++abi: terminating
    2
    3Error: RPC command "format" not found in RPC_COMMANDS_SAFE_FOR_FUZZING or RPC_COMMANDS_NOT_SAFE_FOR_FUZZING. Please update src/test/fuzz/rpc.cpp.
    4libc++abi: terminating
    5
    6Target ['/Users/runner/work/bitcoin/bitcoin/ci/scratch/build-x86_64-apple-darwin/src/test/fuzz/fuzz', PosixPath('/Users/runner/work/bitcoin/bitcoin/ci/scratch/qa-assets/fuzz_corpora/rpc')] failed with exit code -6
    
  8. DrahtBot commented at 7:14 pm on September 10, 2024: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/29919986329

    Make sure to run all tests locally, according to the documentation.

    The failure may happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  9. DrahtBot added the label CI failed on Sep 10, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me