build: Revert “Minimize I/O operations in GenerateHeaderFrom{Json,Raw}.cmake” #30883

1. 
   hebasto commented at 3:38 pm on September 12, 2024: member

   This reverts commit b07fe666f27e2b2515d2cb5a0339512045e64761 from #30842.

   Fixes #30881.

   Apparently, the string(APPEND ...) command isn’t optimized for large strings.

2. Revert "build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake`"

   This reverts commit b07fe666f27e2b2515d2cb5a0339512045e64761.

   fdeb717e78
3. 
   DrahtBot commented at 3:38 pm on September 12, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. 
   maflcko commented at 3:49 pm on September 12, 2024: member

   review ACK fdeb717e78fd55fbfda199c87002358bdc5895af
5. DrahtBot renamed this:
   Revert "build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake`"
   build: Revert "Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake`"
   on Sep 12, 2024
6. DrahtBot added the label Build system on Sep 12, 2024
7. 
   fanquake commented at 3:53 pm on September 12, 2024: member

   Going to merge this, given multiple developers have reported issues.
8. fanquake merged this on Sep 12, 2024
9. fanquake closed this on Sep 12, 2024

   ---

10. hebasto deleted the branch on Sep 12, 2024
11. 
    l0rinc commented at 6:02 pm on September 12, 2024: contributor

    Fixed in https://github.com/bitcoin/bitcoin/pull/30888

Contributors
hebasto DrahtBot maflcko fanquake l0rinc

Labels
Build system