This reverts commit b07fe666f27e2b2515d2cb5a0339512045e64761 from #30842.
Fixes #30881.
Apparently, the string(APPEND ...) command isn't optimized for large strings.
build: Revert "Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake`" #30883
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240912-slow-string changing 2 files +21 −25-
hebasto commented at 3:38 PM on September 12, 2024: member
-
fdeb717e78
Revert "build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake`"
This reverts commit b07fe666f27e2b2515d2cb5a0339512045e64761.
-
DrahtBot commented at 3:38 PM on September 12, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
maflcko commented at 3:49 PM on September 12, 2024: member
review ACK fdeb717e78fd55fbfda199c87002358bdc5895af
- DrahtBot renamed this:
Revert "build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake`"
build: Revert "Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake`"
on Sep 12, 2024 - DrahtBot added the label Build system on Sep 12, 2024
-
fanquake commented at 3:53 PM on September 12, 2024: member
Going to merge this, given multiple developers have reported issues.
- fanquake merged this on Sep 12, 2024
- fanquake closed this on Sep 12, 2024
- hebasto deleted the branch on Sep 12, 2024
-
l0rinc commented at 6:02 PM on September 12, 2024: contributor
- TheCharlatan referenced this in commit 69282950aa on Sep 16, 2024
- TheCharlatan referenced this in commit dfe0cd4ec5 on Sep 16, 2024
- fanquake referenced this in commit 2a0949f097 on Sep 17, 2024
- bitcoin locked this on Sep 12, 2025
