depends: Fix build with MULTIPROCESS=1 in Guix environment #30940

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:240921-guix-mp changing 3 files +4 −1
  1. hebasto commented at 11:53 am on September 21, 2024: member

    In the Guix environment, ${BASEPREFIX}/${HOST}/native/bin is added to the PATH environment variable:https://github.com/bitcoin/bitcoin/blob/33adc7521cc8bb24b941d959022b084002ba7c60/contrib/guix/libexec/build.sh#L233-L234

    This causes CMake to search for package configurations in the native subdirectory first.

    Explicitly specifying the top-priority search prefixes for the Libmultiprocess and LibmultiprocessNative packages resolves #30931.

    Can be tested on this branch with an additional commit:

    0$ uname -m
1x86_64
2$ env MULTIPROCESS=1 HOSTS=x86_64-linux-gnu ./contrib/guix/guix-build
3$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
470d482a09099931345888a918df5ccc78a0c742b1d18bb8a5d442af9b2717867  guix-build-d8ec933456bc/output/dist-archive/bitcoin-d8ec933456bc.tar.gz
5ea9465517c0e1cc559a6a353f404b2bf47447332c918b69410dc51b6c4fbdedc  guix-build-d8ec933456bc/output/x86_64-linux-gnu/SHA256SUMS.part
6f83a296139d0757abc47d053b8fddebc6d2ccc36dabea9b2d52883d23ba923bb  guix-build-d8ec933456bc/output/x86_64-linux-gnu/bitcoin-d8ec933456bc-x86_64-linux-gnu-debug.tar.gz
781aed48bece8d9bf5327530763c17d73dd66d5a3c666cbaf9381c03d4a660845  guix-build-d8ec933456bc/output/x86_64-linux-gnu/bitcoin-d8ec933456bc-x86_64-linux-gnu.tar.gz

    0$ uname -m
1aarch64
2$ env MULTIPROCESS=1 HOSTS=x86_64-linux-gnu ./contrib/guix/guix-build
3$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
470d482a09099931345888a918df5ccc78a0c742b1d18bb8a5d442af9b2717867  guix-build-d8ec933456bc/output/dist-archive/bitcoin-d8ec933456bc.tar.gz
5ea9465517c0e1cc559a6a353f404b2bf47447332c918b69410dc51b6c4fbdedc  guix-build-d8ec933456bc/output/x86_64-linux-gnu/SHA256SUMS.part
6f83a296139d0757abc47d053b8fddebc6d2ccc36dabea9b2d52883d23ba923bb  guix-build-d8ec933456bc/output/x86_64-linux-gnu/bitcoin-d8ec933456bc-x86_64-linux-gnu-debug.tar.gz
781aed48bece8d9bf5327530763c17d73dd66d5a3c666cbaf9381c03d4a660845  guix-build-d8ec933456bc/output/x86_64-linux-gnu/bitcoin-d8ec933456bc-x86_64-linux-gnu.tar.gz
  2. DrahtBot commented at 11:53 am on September 21, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK ryanofsky, fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #30975 (Add multiprocess binaries to release build by Sjors)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  3. DrahtBot added the label Build system on Sep 21, 2024
  4. hebasto commented at 2:09 pm on September 21, 2024: member

    My Guix build:

     0aarch64
 1753aee81b01ff7a560a6c2c9ad64e2f3d3a535d0f5484364ea6b0f7ac7d8d595  guix-build-953aa067c565/output/aarch64-linux-gnu/SHA256SUMS.part
 22eec13b0a0a28d16b9ec2b09908d6785666b49cd2076fd7b677259be0f30d624  guix-build-953aa067c565/output/aarch64-linux-gnu/bitcoin-953aa067c565-aarch64-linux-gnu-debug.tar.gz
 3732591be3acdc241d8d7a649bad755561dafe97839e00105682d962844acbe54  guix-build-953aa067c565/output/aarch64-linux-gnu/bitcoin-953aa067c565-aarch64-linux-gnu.tar.gz
 4279a5e977129a58cd743ac431ec1f6972db9db7e4ffaf3b755e0d0368c3e09f5  guix-build-953aa067c565/output/arm-linux-gnueabihf/SHA256SUMS.part
 584b2f3311ef1aa017e06dc4e5700df01f7e27fbcf1e254f8abd027a8b47ea09c  guix-build-953aa067c565/output/arm-linux-gnueabihf/bitcoin-953aa067c565-arm-linux-gnueabihf-debug.tar.gz
 6c14df93dce9717c7502da304bae7f49385cd8c12c8405e490c0e55f9887e549b  guix-build-953aa067c565/output/arm-linux-gnueabihf/bitcoin-953aa067c565-arm-linux-gnueabihf.tar.gz
 7332292f301369d7442d8377d08d1d47f90865e912b7b4737539bad5878658736  guix-build-953aa067c565/output/arm64-apple-darwin/SHA256SUMS.part
 8d63904f9ad6999109fb5d79a22789accb09dd0d81b76ead73fc6135d410f0c1a  guix-build-953aa067c565/output/arm64-apple-darwin/bitcoin-953aa067c565-arm64-apple-darwin-unsigned.tar.gz
 979b0787b0eaeca13cf892e52e077b8ea019cfa793babae7db50d76d73a24d032  guix-build-953aa067c565/output/arm64-apple-darwin/bitcoin-953aa067c565-arm64-apple-darwin-unsigned.zip
1016c1b1903b538761ce8ad815b62f4e8429873fc97e5cba17a200054b7137ef0a  guix-build-953aa067c565/output/arm64-apple-darwin/bitcoin-953aa067c565-arm64-apple-darwin.tar.gz
111490148fb1df2ea9905803dc074757f0b984b953920e41d9898de46de641484d  guix-build-953aa067c565/output/dist-archive/bitcoin-953aa067c565.tar.gz
128c0f6348a8bba512d65cfbb4e88767b7a0b315e0d492d2ac8afedfcc11fff4e0  guix-build-953aa067c565/output/powerpc64-linux-gnu/SHA256SUMS.part
13bc4e32c911a8ed7eea0b10e4b5cf4fdc7b98109bebbe7e14afa2a2e53285f0fa  guix-build-953aa067c565/output/powerpc64-linux-gnu/bitcoin-953aa067c565-powerpc64-linux-gnu-debug.tar.gz
143575cf0a74fe0a6e133c607797ab00ddc5f6065527ce0394a0a3c8fa841ef1e7  guix-build-953aa067c565/output/powerpc64-linux-gnu/bitcoin-953aa067c565-powerpc64-linux-gnu.tar.gz
15a700d77e7590b135cb3532bbfaef6f8c27ca62c8231e5141afe6e5a794d3fc17  guix-build-953aa067c565/output/riscv64-linux-gnu/SHA256SUMS.part
163b0c1c3c94c7708ecea77d772f90239cb1214b8a700299b985b73764676858bd  guix-build-953aa067c565/output/riscv64-linux-gnu/bitcoin-953aa067c565-riscv64-linux-gnu-debug.tar.gz
17afb8d5268772e9b930510187fd5cbbc6f40b46265290dfe0bbd09a10f5db7790  guix-build-953aa067c565/output/riscv64-linux-gnu/bitcoin-953aa067c565-riscv64-linux-gnu.tar.gz
18578c713215654a9b62ae45284b880670e1d6068a027c32813c40ba716c5b4e80  guix-build-953aa067c565/output/x86_64-apple-darwin/SHA256SUMS.part
195dd6a1f023b26c2dca8d683b4caf84f8c85eee1f5a9864167338ec196ebba13f  guix-build-953aa067c565/output/x86_64-apple-darwin/bitcoin-953aa067c565-x86_64-apple-darwin-unsigned.tar.gz
20919cdc33088161a299c14dd54588ff7be85bf17ebf1d322451a08bcd5ad26f89  guix-build-953aa067c565/output/x86_64-apple-darwin/bitcoin-953aa067c565-x86_64-apple-darwin-unsigned.zip
2175b8158ee168dd423a6ec27feb977f2f0d0740a79827a4e9a1d6b81df3498002  guix-build-953aa067c565/output/x86_64-apple-darwin/bitcoin-953aa067c565-x86_64-apple-darwin.tar.gz
226350e63b33d0d96aa05d5c5ce609e2cfdf40d2cdcb21453964791e4481a7e992  guix-build-953aa067c565/output/x86_64-linux-gnu/SHA256SUMS.part
23001fecc381e92ac1af001ee3a710584e823aceb848d84f08d05e875e853b24c4  guix-build-953aa067c565/output/x86_64-linux-gnu/bitcoin-953aa067c565-x86_64-linux-gnu-debug.tar.gz
24eedee938d168aeac897ccdf85c970d63b27acd22fd2aa491fb0abb65c4e4de94  guix-build-953aa067c565/output/x86_64-linux-gnu/bitcoin-953aa067c565-x86_64-linux-gnu.tar.gz
25b388fff8c467d965ef9b66c20d388fa07380dba70e58b5ca9e837895d2fc3a71  guix-build-953aa067c565/output/x86_64-w64-mingw32/SHA256SUMS.part
26f080084caa711253b7efb4b9d0080b8bbea9a69792fb652b519a3205742ab36e  guix-build-953aa067c565/output/x86_64-w64-mingw32/bitcoin-953aa067c565-win64-debug.zip
274c4b472665e80f1c9555fe8591f4082f5967ed92aa9428007bbd25679e636005  guix-build-953aa067c565/output/x86_64-w64-mingw32/bitcoin-953aa067c565-win64-setup-unsigned.exe
28280ee9e224c502a81e65237a9a4ce96f04e644577e584d0e68cdfb954538f499  guix-build-953aa067c565/output/x86_64-w64-mingw32/bitcoin-953aa067c565-win64-unsigned.tar.gz
29a9e003992f668a97ee56f601f3631ea0613d7a2200cc11461abc18485d79f002  guix-build-953aa067c565/output/x86_64-w64-mingw32/bitcoin-953aa067c565-win64.zip
  5. Sjors commented at 3:09 pm on September 21, 2024: member

    @hebasto can you rebase your 240921-guix-mp.DEMO branch so it builds directly on this PR? That makes it easier to compare guix builds.

    I’ll make a regular guix build for this PR first, without MULTIPROCESS=1.

  6. hebasto commented at 8:24 pm on September 21, 2024: member

    @Sjors

    can you rebase your 240921-guix-mp.DEMO branch so it builds directly on this PR? That makes it easier to compare guix builds.

    Done. The PR description has been updated accordingly.

  7. Sjors commented at 2:29 pm on September 22, 2024: member

    On this PR

     0x86_64
 1
 2753aee81b01ff7a560a6c2c9ad64e2f3d3a535d0f5484364ea6b0f7ac7d8d595  guix-build-953aa067c565/output/aarch64-linux-gnu/SHA256SUMS.part
 32eec13b0a0a28d16b9ec2b09908d6785666b49cd2076fd7b677259be0f30d624  guix-build-953aa067c565/output/aarch64-linux-gnu/bitcoin-953aa067c565-aarch64-linux-gnu-debug.tar.gz
 4732591be3acdc241d8d7a649bad755561dafe97839e00105682d962844acbe54  guix-build-953aa067c565/output/aarch64-linux-gnu/bitcoin-953aa067c565-aarch64-linux-gnu.tar.gz
 5279a5e977129a58cd743ac431ec1f6972db9db7e4ffaf3b755e0d0368c3e09f5  guix-build-953aa067c565/output/arm-linux-gnueabihf/SHA256SUMS.part
 684b2f3311ef1aa017e06dc4e5700df01f7e27fbcf1e254f8abd027a8b47ea09c  guix-build-953aa067c565/output/arm-linux-gnueabihf/bitcoin-953aa067c565-arm-linux-gnueabihf-debug.tar.gz
 7c14df93dce9717c7502da304bae7f49385cd8c12c8405e490c0e55f9887e549b  guix-build-953aa067c565/output/arm-linux-gnueabihf/bitcoin-953aa067c565-arm-linux-gnueabihf.tar.gz
 8332292f301369d7442d8377d08d1d47f90865e912b7b4737539bad5878658736  guix-build-953aa067c565/output/arm64-apple-darwin/SHA256SUMS.part
 9d63904f9ad6999109fb5d79a22789accb09dd0d81b76ead73fc6135d410f0c1a  guix-build-953aa067c565/output/arm64-apple-darwin/bitcoin-953aa067c565-arm64-apple-darwin-unsigned.tar.gz
1079b0787b0eaeca13cf892e52e077b8ea019cfa793babae7db50d76d73a24d032  guix-build-953aa067c565/output/arm64-apple-darwin/bitcoin-953aa067c565-arm64-apple-darwin-unsigned.zip
1116c1b1903b538761ce8ad815b62f4e8429873fc97e5cba17a200054b7137ef0a  guix-build-953aa067c565/output/arm64-apple-darwin/bitcoin-953aa067c565-arm64-apple-darwin.tar.gz
121490148fb1df2ea9905803dc074757f0b984b953920e41d9898de46de641484d  guix-build-953aa067c565/output/dist-archive/bitcoin-953aa067c565.tar.gz
138c0f6348a8bba512d65cfbb4e88767b7a0b315e0d492d2ac8afedfcc11fff4e0  guix-build-953aa067c565/output/powerpc64-linux-gnu/SHA256SUMS.part
14bc4e32c911a8ed7eea0b10e4b5cf4fdc7b98109bebbe7e14afa2a2e53285f0fa  guix-build-953aa067c565/output/powerpc64-linux-gnu/bitcoin-953aa067c565-powerpc64-linux-gnu-debug.tar.gz
153575cf0a74fe0a6e133c607797ab00ddc5f6065527ce0394a0a3c8fa841ef1e7  guix-build-953aa067c565/output/powerpc64-linux-gnu/bitcoin-953aa067c565-powerpc64-linux-gnu.tar.gz
16a700d77e7590b135cb3532bbfaef6f8c27ca62c8231e5141afe6e5a794d3fc17  guix-build-953aa067c565/output/riscv64-linux-gnu/SHA256SUMS.part
173b0c1c3c94c7708ecea77d772f90239cb1214b8a700299b985b73764676858bd  guix-build-953aa067c565/output/riscv64-linux-gnu/bitcoin-953aa067c565-riscv64-linux-gnu-debug.tar.gz
18afb8d5268772e9b930510187fd5cbbc6f40b46265290dfe0bbd09a10f5db7790  guix-build-953aa067c565/output/riscv64-linux-gnu/bitcoin-953aa067c565-riscv64-linux-gnu.tar.gz
19578c713215654a9b62ae45284b880670e1d6068a027c32813c40ba716c5b4e80  guix-build-953aa067c565/output/x86_64-apple-darwin/SHA256SUMS.part
205dd6a1f023b26c2dca8d683b4caf84f8c85eee1f5a9864167338ec196ebba13f  guix-build-953aa067c565/output/x86_64-apple-darwin/bitcoin-953aa067c565-x86_64-apple-darwin-unsigned.tar.gz
21919cdc33088161a299c14dd54588ff7be85bf17ebf1d322451a08bcd5ad26f89  guix-build-953aa067c565/output/x86_64-apple-darwin/bitcoin-953aa067c565-x86_64-apple-darwin-unsigned.zip
2275b8158ee168dd423a6ec27feb977f2f0d0740a79827a4e9a1d6b81df3498002  guix-build-953aa067c565/output/x86_64-apple-darwin/bitcoin-953aa067c565-x86_64-apple-darwin.tar.gz
236350e63b33d0d96aa05d5c5ce609e2cfdf40d2cdcb21453964791e4481a7e992  guix-build-953aa067c565/output/x86_64-linux-gnu/SHA256SUMS.part
24001fecc381e92ac1af001ee3a710584e823aceb848d84f08d05e875e853b24c4  guix-build-953aa067c565/output/x86_64-linux-gnu/bitcoin-953aa067c565-x86_64-linux-gnu-debug.tar.gz
25eedee938d168aeac897ccdf85c970d63b27acd22fd2aa491fb0abb65c4e4de94  guix-build-953aa067c565/output/x86_64-linux-gnu/bitcoin-953aa067c565-x86_64-linux-gnu.tar.gz
26b388fff8c467d965ef9b66c20d388fa07380dba70e58b5ca9e837895d2fc3a71  guix-build-953aa067c565/output/x86_64-w64-mingw32/SHA256SUMS.part
27f080084caa711253b7efb4b9d0080b8bbea9a69792fb652b519a3205742ab36e  guix-build-953aa067c565/output/x86_64-w64-mingw32/bitcoin-953aa067c565-win64-debug.zip
284c4b472665e80f1c9555fe8591f4082f5967ed92aa9428007bbd25679e636005  guix-build-953aa067c565/output/x86_64-w64-mingw32/bitcoin-953aa067c565-win64-setup-unsigned.exe
29280ee9e224c502a81e65237a9a4ce96f04e644577e584d0e68cdfb954538f499  guix-build-953aa067c565/output/x86_64-w64-mingw32/bitcoin-953aa067c565-win64-unsigned.tar.gz
30a9e003992f668a97ee56f601f3631ea0613d7a2200cc11461abc18485d79f002  guix-build-953aa067c565/output/x86_64-w64-mingw32/bitcoin-953aa067c565-win64.zip
  8. Sjors commented at 2:31 pm on September 22, 2024: member

    On the demo branch (without x86_64-w64-mingw32, see below):

     0MULTIPROCESS=1 ./contrib/guix/guix-build
 1
 2c41f25fce469d9142210cfd57398423035fc41e68f3d052cb2f39c1493fc9a9d  guix-build-878cb237b717/output/aarch64-linux-gnu/SHA256SUMS.part
 3b11a40d0a61efd90d11d5d38c5c10bbb4b859f6da14d166669684b86b8993a8d  guix-build-878cb237b717/output/aarch64-linux-gnu/bitcoin-878cb237b717-aarch64-linux-gnu-debug.tar.gz
 4e577a60a76f9f3063fef2497651bf0a741a4f454620eba27e8f75e114b70da39  guix-build-878cb237b717/output/aarch64-linux-gnu/bitcoin-878cb237b717-aarch64-linux-gnu.tar.gz
 5a432e894a4a8d998b7a101bebfc58a377abaecfaaef97d96d93fffd714e1d163  guix-build-878cb237b717/output/arm-linux-gnueabihf/SHA256SUMS.part
 60a08dc7dca2fd051d3a8b298326456788d98a9ce230a37e94aa61187f0521115  guix-build-878cb237b717/output/arm-linux-gnueabihf/bitcoin-878cb237b717-arm-linux-gnueabihf-debug.tar.gz
 797f90701ad1ab9ec74eb8edef6e63f4be910d79a611a8f7a0561db0e4ca6f648  guix-build-878cb237b717/output/arm-linux-gnueabihf/bitcoin-878cb237b717-arm-linux-gnueabihf.tar.gz
 827857319c1079c310bcaf0a7061b514971fb1a878847831fa94a1216cb6f34b3  guix-build-878cb237b717/output/arm64-apple-darwin/SHA256SUMS.part
 949d0eabc382e69e00f507b0f249989eff8149587ffe0b830423c36a559d36565  guix-build-878cb237b717/output/arm64-apple-darwin/bitcoin-878cb237b717-arm64-apple-darwin-unsigned.tar.gz
101fb7ddfe2580a23ecfd15af65de6e5e084ebf0d559eaa8eb95365714d324eb3d  guix-build-878cb237b717/output/arm64-apple-darwin/bitcoin-878cb237b717-arm64-apple-darwin-unsigned.zip
114d39d7be8db058020c534e3204e7947bac3f64fe07ac8b110195a8e161190207  guix-build-878cb237b717/output/arm64-apple-darwin/bitcoin-878cb237b717-arm64-apple-darwin.tar.gz
1296379dd49b1db9a092389b7adf7c178086f36126dfe2b31397849b57bd68aaa7  guix-build-878cb237b717/output/dist-archive/bitcoin-878cb237b717.tar.gz
134c7ce3cad4be3ee70beda5da65c03707af68415eea378e1985870a4a16ab9eaf  guix-build-878cb237b717/output/powerpc64-linux-gnu/SHA256SUMS.part
142a86bec1740ea479ca4905b9a1b14f5243110076a0cfa8f25e8357932e610c83  guix-build-878cb237b717/output/powerpc64-linux-gnu/bitcoin-878cb237b717-powerpc64-linux-gnu-debug.tar.gz
152f5e696744fd14f00c992756e8bebf58a066d1bfcf88dfccbe42a5a643ed7198  guix-build-878cb237b717/output/powerpc64-linux-gnu/bitcoin-878cb237b717-powerpc64-linux-gnu.tar.gz
16466e812e8299c01a62d1a3cd5cb287dc3ce882b5284b8af08f45c8b139799c8a  guix-build-878cb237b717/output/riscv64-linux-gnu/SHA256SUMS.part
17a5c9c1d5837e7b1ab136c261b9865ce3a2dbe23b45980fe15a9c44970582146b  guix-build-878cb237b717/output/riscv64-linux-gnu/bitcoin-878cb237b717-riscv64-linux-gnu-debug.tar.gz
1891e248596752017878f81ed85eece94535e69c35d0e9ce8357c269f0dc7a383a  guix-build-878cb237b717/output/riscv64-linux-gnu/bitcoin-878cb237b717-riscv64-linux-gnu.tar.gz
19ffdc6f44c9768d277738c51fc943215915d6410cd1442d5d7c43a878593401f5  guix-build-878cb237b717/output/x86_64-apple-darwin/SHA256SUMS.part
2076edf927e8a2b928f517b1722ecc8689b7b20c13d12df063fd058bd19bf8c373  guix-build-878cb237b717/output/x86_64-apple-darwin/bitcoin-878cb237b717-x86_64-apple-darwin-unsigned.tar.gz
215eb71d759593d50849fc03546742facade3d5b956cd17f10398d259b9cb57b08  guix-build-878cb237b717/output/x86_64-apple-darwin/bitcoin-878cb237b717-x86_64-apple-darwin-unsigned.zip
2264289038b111dfc26420d912a65cde4702abddff24a0245804f5e357f430746e  guix-build-878cb237b717/output/x86_64-apple-darwin/bitcoin-878cb237b717-x86_64-apple-darwin.tar.gz
23e50a278567866f3adf251958e8840f5f1330b0bab314b501451412b3e09d3440  guix-build-878cb237b717/output/x86_64-linux-gnu/SHA256SUMS.part
240329693191416d3ed3efda08a0d3e41149bcc2d52182048aa447765cce3425f2  guix-build-878cb237b717/output/x86_64-linux-gnu/bitcoin-878cb237b717-x86_64-linux-gnu-debug.tar.gz
25f7d4f900d53db09d4958363382e75fe169a97ef4996743b5a96f6c8b9d18b800  guix-build-878cb237b717/output/x86_64-linux-gnu/bitcoin-878cb237b717-x86_64-linux-gnu.tar.gz

    It fails for x86_64-w64-mingw32:

     0[ 20%] Building CXX object CMakeFiles/util.dir/src/mp/util.cpp.obj
 1/bitcoin/depends/work/build/x86_64-w64-mingw32/libmultiprocess/c1b4ab4eb897d3af09bc9b3cc30e2e6fff87f3e2-79146c14ac6/src/mp/util.cpp:13:10: fatal error: sys/resource.h: No such file or directory
 2   13 | #include <sys/resource.h>
 3      |          ^~~~~~~~~~~~~~~~
 4compilation terminated.
 5make[4]: *** [CMakeFiles/util.dir/build.make:77: CMakeFiles/util.dir/src/mp/util.cpp.obj] Error 1
 6make[4]: Leaving directory '/bitcoin/depends/work/build/x86_64-w64-mingw32/libmultiprocess/c1b4ab4eb897d3af09bc9b3cc30e2e6fff87f3e2-79146c14ac6'
 7make[3]: *** [CMakeFiles/Makefile2:156: CMakeFiles/util.dir/all] Error 2
 8make[3]: Leaving directory '/bitcoin/depends/work/build/x86_64-w64-mingw32/libmultiprocess/c1b4ab4eb897d3af09bc9b3cc30e2e6fff87f3e2-79146c14ac6'
 9make[2]: *** [CMakeFiles/Makefile2:189: CMakeFiles/multiprocess.dir/rule] Error 2
10make[2]: Leaving directory '/bitcoin/depends/work/build/x86_64-w64-mingw32/libmultiprocess/c1b4ab4eb897d3af09bc9b3cc30e2e6fff87f3e2-79146c14ac6'
11make[1]: *** [Makefile:182: multiprocess] Error 2
12make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-w64-mingw32/libmultiprocess/c1b4ab4eb897d3af09bc9b3cc30e2e6fff87f3e2-79146c14ac6'
13make: *** [funcs.mk:301: /bitcoin/depends/work/build/x86_64-w64-mingw32/libmultiprocess/c1b4ab4eb897d3af09bc9b3cc30e2e6fff87f3e2-79146c14ac6/./.stamp_built] Error 2
14make: Leaving directory '/bitcoin/depends'

    Not sure if that platform is supposed to work at all, cc @ryanofsky, but if not, the Guix and/or depends build process should imo complain about that earlier.

  9. hebasto commented at 8:59 am on September 23, 2024: member

    Not sure if that platform is supposed to work at all, cc @ryanofsky, but if not, the Guix and/or depends build process should imo complain about that earlier.

    MIght be related: https://github.com/chaincodelabs/libmultiprocess/issues/53.

  10. hebasto commented at 9:05 am on September 23, 2024: member

    For the x86_64-linux-gnu host, builds are non-deterministic:

    • mine, aarch64:
    0dde3c647c0121f5f0623c8edffe4bc3fccf79bf1195752b3c51362fc35904e4f  guix-build-878cb237b717/output/x86_64-linux-gnu/bitcoin-878cb237b717-x86_64-linux-gnu.tar.gz

    0f7d4f900d53db09d4958363382e75fe169a97ef4996743b5a96f6c8b9d18b800  guix-build-878cb237b717/output/x86_64-linux-gnu/bitcoin-878cb237b717-x86_64-linux-gnu.tar.gz
  11. fanquake commented at 9:17 am on September 23, 2024: member

    Not sure I understand this fix yet, and it seems like there are some other depends changes here, for what I would have expected to be a fixup in libmultiprocess (either in how it’s installed, or how we are searching for it in CMake)?

    In 38bc0463aaf1f3e20e2f3447af40c29c6d2d6859:

    which in turn facilitates the use of depends in scenarios where building depends is a separate step, such as on NixOS.

    Building depends is always it’s own/a separate step. Not really clear what this means? As far as I’m aware, building depends also already works on NixOS (or at least it did last time I tested it).

    This causes CMake to search for package configurations in the native subdirectory first.

    This is the correct behaviour as far as we are concerned right? The PR description and commit message in 953aa067c565c55efaca184bca1f9c90ddf16e0c make it sound like this is something we’re now trying to work around. Also, if CMake is looking in some place “first”, shouldn’t it then be falling back to look somewhere else second, rather than failing immediately (as seems to be the case here).

  12. depends: Fix build with `MULTIPROCESS=1` in Guix environment 
    In the Guix environment, `${BASEPREFIX}/${HOST}/native/bin` is added to
the `PATH` environment variable, causing CMake to search for package
configurations in the `native` subdirectory first.

Explicitly specifying the top-priority search prefixes for the
`Libmultiprocess` and `LibmultiprocessNative` packages resolves the
issue.
    d8e3afc335
  13. hebasto force-pushed on Sep 23, 2024
  14. hebasto commented at 10:01 am on September 23, 2024: member

    Not sure I understand this fix yet, and it seems like there are some other depends changes here, for what I would have expected to be a fixup in libmultiprocess (either in how it’s installed, or how we are searching for it in CMake)?

    Dropped the first refactoring commit after the off-line discussion with @fanquake.

  15. Sjors commented at 10:55 am on September 23, 2024: member

    Dropped the first refactoring commit

    Do you think that was the cause of the indeterminism, or are you still investigating that? (might be a followup)

    This branch MULTIPROCESS=0:

     0x86_64
 1bfaa20403bf3ee4c1ef89c102444957296adf672a79ffd6c8b483f7d0e5cc2a8  guix-build-d8e3afc3352a/output/aarch64-linux-gnu/SHA256SUMS.part
 2e02da874c1cb6950747b9a54ec1ad8b63b09c62540c276f6a900d44987eabd4b  guix-build-d8e3afc3352a/output/aarch64-linux-gnu/bitcoin-d8e3afc3352a-aarch64-linux-gnu-debug.tar.gz
 3a22d1edb297e51c1c8b8ee3333eb5f209b8ed42703e6f9c0f312529465474817  guix-build-d8e3afc3352a/output/aarch64-linux-gnu/bitcoin-d8e3afc3352a-aarch64-linux-gnu.tar.gz
 4d772fea41bfa182f3f0ddeef2bb65a425e63d73a89a1b894d720272773ef4671  guix-build-d8e3afc3352a/output/arm-linux-gnueabihf/SHA256SUMS.part
 529fa49459b663bc0709f38683360135a040006e1529cb93c575a2eb9e40d1a0f  guix-build-d8e3afc3352a/output/arm-linux-gnueabihf/bitcoin-d8e3afc3352a-arm-linux-gnueabihf-debug.tar.gz
 6a61c5749360b985a988c71ddddeda2654257abfc0cba72acc1c0426a28b0e1b8  guix-build-d8e3afc3352a/output/arm-linux-gnueabihf/bitcoin-d8e3afc3352a-arm-linux-gnueabihf.tar.gz
 7e4a00dcfecf581fa984417887d74e66aa909788d1ea127713e62215c5e2c6f03  guix-build-d8e3afc3352a/output/arm64-apple-darwin/SHA256SUMS.part
 87334890d40984488fbc01fbfeaf0684ae218b97d5cb2032c53cca632c948dc2a  guix-build-d8e3afc3352a/output/arm64-apple-darwin/bitcoin-d8e3afc3352a-arm64-apple-darwin-unsigned.tar.gz
 91027ba0678f83e6547cff26a985e0bccfbdf36a79dc871eea629d3ce9dc64e61  guix-build-d8e3afc3352a/output/arm64-apple-darwin/bitcoin-d8e3afc3352a-arm64-apple-darwin-unsigned.zip
10a77c3c851eb5e4e7f2f69767274d8c34cde4fb92cf5239026655e4daaed8ea9b  guix-build-d8e3afc3352a/output/arm64-apple-darwin/bitcoin-d8e3afc3352a-arm64-apple-darwin.tar.gz
110e2311596ba061221c1aeb44889beb7b51726dd0ca23a68caf888213ac9bce5c  guix-build-d8e3afc3352a/output/dist-archive/bitcoin-d8e3afc3352a.tar.gz
12f95791b624d811029129988fdd171675accd7c57fa4d077b845e43116077a285  guix-build-d8e3afc3352a/output/powerpc64-linux-gnu/SHA256SUMS.part
13b5cd800c5652f702d7ac46999fdf120c77ec52dffd7a5f639c6b9794e9aec825  guix-build-d8e3afc3352a/output/powerpc64-linux-gnu/bitcoin-d8e3afc3352a-powerpc64-linux-gnu-debug.tar.gz
14aec2201d30ed04c0da8b1387a46fcb70f437341e8b1c53afc846a4b1a55876aa  guix-build-d8e3afc3352a/output/powerpc64-linux-gnu/bitcoin-d8e3afc3352a-powerpc64-linux-gnu.tar.gz
15fe4ac26e6eb0a021fc02f91905513ff4f7c2338f84413fe12f7d5ffafcd61378  guix-build-d8e3afc3352a/output/riscv64-linux-gnu/SHA256SUMS.part
16bab8c4152193344eea4000a068dc9ac0e5a26bf978db43725bbeffa0983b7e54  guix-build-d8e3afc3352a/output/riscv64-linux-gnu/bitcoin-d8e3afc3352a-riscv64-linux-gnu-debug.tar.gz
178750da1c00262782a93d4d9f315938c0a6602cd2c2777dd351f2a1333ed5e16a  guix-build-d8e3afc3352a/output/riscv64-linux-gnu/bitcoin-d8e3afc3352a-riscv64-linux-gnu.tar.gz
1833e55b3bd700edfd5bb818d7c7ef7ef3f1d3b0d86aec9936d0460d8270f6e3ec  guix-build-d8e3afc3352a/output/x86_64-apple-darwin/SHA256SUMS.part
19cde54231fc65d3b5f3cc40e8eee7f853d16005b99135ce79006d3169232b2092  guix-build-d8e3afc3352a/output/x86_64-apple-darwin/bitcoin-d8e3afc3352a-x86_64-apple-darwin-unsigned.tar.gz
209d1af30a2d96fdce2b3ff0880e6f2d056450fbd21a86c8f548db869f12ecc0bc  guix-build-d8e3afc3352a/output/x86_64-apple-darwin/bitcoin-d8e3afc3352a-x86_64-apple-darwin-unsigned.zip
2193f7197dde355f8cef1b8c24aa7f4ecd35a34267d156dbb9ee83f98839ea4559  guix-build-d8e3afc3352a/output/x86_64-apple-darwin/bitcoin-d8e3afc3352a-x86_64-apple-darwin.tar.gz
22c46b0811e99a10d78f4279b1817e38624434ed8a236f7cb3db95551cd8b10221  guix-build-d8e3afc3352a/output/x86_64-linux-gnu/SHA256SUMS.part
238b23f1a9726a1d71edc86780e5edfee1f2d90de460de9884845dad268984c61b  guix-build-d8e3afc3352a/output/x86_64-linux-gnu/bitcoin-d8e3afc3352a-x86_64-linux-gnu-debug.tar.gz
24115983c7d91b4d25de39e5ece75f837eb0ff8425e68c6d7b7002fb8a2138a55c  guix-build-d8e3afc3352a/output/x86_64-linux-gnu/bitcoin-d8e3afc3352a-x86_64-linux-gnu.tar.gz
25331c80a06dbed7c9b462f2d05bdbfcdb936eeb00ee07b5d86a87ab34c8e24ebc  guix-build-d8e3afc3352a/output/x86_64-w64-mingw32/SHA256SUMS.part
26f4da4dc9e4b0e2bd3c41105967255f5faa76b70372b87a64c44086a7f6d34825  guix-build-d8e3afc3352a/output/x86_64-w64-mingw32/bitcoin-d8e3afc3352a-win64-debug.zip
271f2d3f89b26b907c46e7b448655341c39be708ee872e415186e873af7c7bf9e6  guix-build-d8e3afc3352a/output/x86_64-w64-mingw32/bitcoin-d8e3afc3352a-win64-setup-unsigned.exe
28226de35527d8892ece8162cb0f48701fb5a1eb6125f2e28f11c7ebd35824333c  guix-build-d8e3afc3352a/output/x86_64-w64-mingw32/bitcoin-d8e3afc3352a-win64-unsigned.tar.gz
29c4ca5fd6b11fb298d979835a9aca4d32ce9613cf2e95e5075a221649395bf574  guix-build-d8e3afc3352a/output/x86_64-w64-mingw32/bitcoin-d8e3afc3352a-win64.zip

    Demo branch MULTIPROCESS=1 and without x86_64-w64-mingw32:

    0x86_64
1(abort due to update)
  16. depends: Fix reproducibility when building with `MULTIPROCESS=1` 06b4c339e8
  17. hebasto commented at 12:34 pm on September 23, 2024: member

    Dropped the first refactoring commit

    Do you think that was the cause of the indeterminism, or are you still investigating that? (might be a followup)

    Another commit with a fix for indeterminism has been pushed.

    The PR description has been updated accordingly.

  18. ryanofsky approved
  19. ryanofsky commented at 2:03 pm on September 23, 2024: contributor

    Code review ACK 06b4c339e89e593d951a90cd2d1bce944acf3bf7

    This causes CMake to search for package configurations in the native subdirectory first.

    This is the correct behaviour as far as we are concerned right?

    I think the problem here is not that that cmake is searching the native directory first, but that it is searching the native directory only for the libmultiprocess runtime library, which is cross compiled, and can’t be found in the native prefix.

    The fix in d8e3afc3352a2742e9da1f777e026d1f051042ac seems like a good change since it explicitly points cmake to right directories for both native and cross compiled packages, but there are a number of things here I’m wondering about:

    1. The current fix d8e3afc3352a2742e9da1f777e026d1f051042ac seems good because it sets directory paths for both packages, not just the native package. But I don’t understand why it is switching from _DIR variables to _ROOT variables. According to https://chatgpt.com/c/66f16a25-c068-800a-bba6-36d030d42869 both approaches seem roughly equivalent, but I don’t understand if there was another reason to switch from _DIR to _ROOT.

    2. I don’t understand why “In the Guix environment, ${BASEPREFIX}/${HOST}/native/bin is added to the PATH environment variable,” according to the description. Setting this seems indiscriminate, like a sledgehammer approach, something that would cause the guix build to behave differently from normal depends builds and lead to confusing issues like this one.

    3. Indirectly related to this issue: I don’t understand why depends toolchain is setting set(CMAKE_FIND_USE_CMAKE_ENVIRONMENT_PATH OFF). I use a shell.nix file to set up a build environment for bitcoin and this setting make it hard to use depends because it makes cmake ignore the CMAKE_INCLUDE_PATH / CMAKE_PREFIX_PATH / CMAKE_LIBRARY_PATH variables constructed in the nix environment to allow cmake to find dependencies.

    (2) and (3) both seem like cases of guix and depends builds doing unusual things that cause them to interoperate poorly, without clear reasons for doing those things.

    1. I think dropped commit 38bc0463aaf1f3e20e2f3447af40c29c6d2d6859 is a good change and would be nice to add to a separate PR. The change is good because it makes toolchain file more readable, getting rid of unnecessary @depends_prefix@ variable making it obvious that paths just are relative to the toolchain file. It also seems like a good change because it stops abusing the CMAKE_FIND_ROOT_PATH variable and treating it like a single path when it is actually a list of paths.
  20. hebasto commented at 2:13 pm on September 23, 2024: member
    1. I don’t understand why “In the Guix environment, ${BASEPREFIX}/${HOST}/native/bin is added to the PATH environment variable,” according to the description. Setting this seems indiscriminate, like a sledgehammer approach, something that would cause the guix build to behave differently from normal depends builds and lead to confusing issues like this one.

    I believe it was required when the macOS toolchain was built in depends. We can investigate this issue separately, can’t we?

  21. hebasto commented at 2:21 pm on September 23, 2024: member

    My Guix build:

     0aarch64
 18868809b50ea77b47c45c1cdf802e85540d9428f182773b1cd7e5d73750dce87  guix-build-06b4c339e89e/output/aarch64-linux-gnu/SHA256SUMS.part
 2fccf8cf14ca3d3ee7812f254d10eb17e62c507f5b2606c6b099c5d00ed5d3446  guix-build-06b4c339e89e/output/aarch64-linux-gnu/bitcoin-06b4c339e89e-aarch64-linux-gnu-debug.tar.gz
 32d7cf4959e238fae666476db1cd11112c77708a58bb9d5cd1e0c7986c8c477a6  guix-build-06b4c339e89e/output/aarch64-linux-gnu/bitcoin-06b4c339e89e-aarch64-linux-gnu.tar.gz
 422d7016c186928f517a3b69db90d01b2eed3b15b9ecaa53cab5c5cb35d3974d3  guix-build-06b4c339e89e/output/arm-linux-gnueabihf/SHA256SUMS.part
 5a77e95ce28b755f7aeb5d6bca0e084a17d78dca755bb7e21e854ad2c7324fd7c  guix-build-06b4c339e89e/output/arm-linux-gnueabihf/bitcoin-06b4c339e89e-arm-linux-gnueabihf-debug.tar.gz
 6c08fdd60e0b4ba56245fc5e4a50d7537d180fe682108137e951b13c793744bc8  guix-build-06b4c339e89e/output/arm-linux-gnueabihf/bitcoin-06b4c339e89e-arm-linux-gnueabihf.tar.gz
 7f3b6dcdf7a05ca1faa3bbfb01721fddd801070b85ddbdd84d6bb4ecc61b24aac  guix-build-06b4c339e89e/output/arm64-apple-darwin/SHA256SUMS.part
 87877c5d19c602fd85192ba398284e2447f898b1cacc9b9321cb6392b5e451864  guix-build-06b4c339e89e/output/arm64-apple-darwin/bitcoin-06b4c339e89e-arm64-apple-darwin-unsigned.tar.gz
 968acba090e08e71fbc3734673cc649a361de9117692db76ec8aa8f17f4952ea0  guix-build-06b4c339e89e/output/arm64-apple-darwin/bitcoin-06b4c339e89e-arm64-apple-darwin-unsigned.zip
1076d6b38655a2e52079ebcf108c2e9c4ad99ffd76efa7382f8425be043930b7dc  guix-build-06b4c339e89e/output/arm64-apple-darwin/bitcoin-06b4c339e89e-arm64-apple-darwin.tar.gz
1104266bb6fb00caf81afc62df9dae9ca39d8e2da788a093f7d722b4d7038c8a3f  guix-build-06b4c339e89e/output/dist-archive/bitcoin-06b4c339e89e.tar.gz
12ccd67910dc8e7e9d499cdb4914b0c6bcb2fce70902f02b17ec1b789134d7520e  guix-build-06b4c339e89e/output/powerpc64-linux-gnu/SHA256SUMS.part
134e42474ae55caa372fadc8d4552944175e4405b8aa1cb6d7f299450aa47b6862  guix-build-06b4c339e89e/output/powerpc64-linux-gnu/bitcoin-06b4c339e89e-powerpc64-linux-gnu-debug.tar.gz
14ca8f7c6fde62db3c8147539f060b6f67ffb28c072127166cd55042804d390613  guix-build-06b4c339e89e/output/powerpc64-linux-gnu/bitcoin-06b4c339e89e-powerpc64-linux-gnu.tar.gz
154fa8f97503783a1dfdf79133a0c7d98af381203064a83620d357ffcdb0192f12  guix-build-06b4c339e89e/output/riscv64-linux-gnu/SHA256SUMS.part
1680684fa83f4b9cf7e9514eca0828901643d73efe7ff0651d97eed4dab7353172  guix-build-06b4c339e89e/output/riscv64-linux-gnu/bitcoin-06b4c339e89e-riscv64-linux-gnu-debug.tar.gz
1756bfacda24dc665078ba9242c89a9a429705a35298f6fa123bcb257ea7ec7964  guix-build-06b4c339e89e/output/riscv64-linux-gnu/bitcoin-06b4c339e89e-riscv64-linux-gnu.tar.gz
189725713bfda6b9288936aba7ab1598b77275b975628061a5c76f613bf959f60a  guix-build-06b4c339e89e/output/x86_64-apple-darwin/SHA256SUMS.part
19c01a581746d53ac316cd20cbc8504dcdff37a0aa3ded92023fbbb3220782712f  guix-build-06b4c339e89e/output/x86_64-apple-darwin/bitcoin-06b4c339e89e-x86_64-apple-darwin-unsigned.tar.gz
20d1527ef633352089ae823405377af88e469a08aaed04b7f1c40b6f5d7db93d6d  guix-build-06b4c339e89e/output/x86_64-apple-darwin/bitcoin-06b4c339e89e-x86_64-apple-darwin-unsigned.zip
21ffbc384aa5b401246a4f5a3e6879bb03566e13eb215662e3ef381b90eba1c141  guix-build-06b4c339e89e/output/x86_64-apple-darwin/bitcoin-06b4c339e89e-x86_64-apple-darwin.tar.gz
2250bc20c2256ff9209d2c095a862be00a6c8259acbb54d3c40f76019a34e9af6b  guix-build-06b4c339e89e/output/x86_64-linux-gnu/SHA256SUMS.part
239329c9c322240b8cc189d9389996feffd249c949daad0ad87167b0f50f196ebe  guix-build-06b4c339e89e/output/x86_64-linux-gnu/bitcoin-06b4c339e89e-x86_64-linux-gnu-debug.tar.gz
240d46f3124764daf22aabcebaa24dd63df4e804b74ea1e66251c53d36ef8af0e2  guix-build-06b4c339e89e/output/x86_64-linux-gnu/bitcoin-06b4c339e89e-x86_64-linux-gnu.tar.gz
25a13668ea24fc71065d1647ce0c2f75b883818dc20ee06c40a8ae35227bbb295c  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/SHA256SUMS.part
2664ec47382e2e771451b9976f1729593be20687ff92dcfa0526c3fb255c0c734a  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/bitcoin-06b4c339e89e-win64-debug.zip
279d6f9a971ee70a5ad7c6e3c425b0d6b3b0d80604b39198ba60821148fe7d75e4  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/bitcoin-06b4c339e89e-win64-setup-unsigned.exe
281e255cddf39f1d7a1b0d5c92ed71d9a5d2da92af476ae50071e873eb5ee4c30a  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/bitcoin-06b4c339e89e-win64-unsigned.tar.gz
29e34c7c07343f6f4a055edad66d7d9903025134e9028bde7d2673a9782d23e31a  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/bitcoin-06b4c339e89e-win64.zip
  22. hebasto commented at 2:53 pm on September 23, 2024: member
    1. Indirectly related to this issue: I don’t understand why depends toolchain is setting set(CMAKE_FIND_USE_CMAKE_ENVIRONMENT_PATH OFF). I use a shell.nix file to set up a build environment for bitcoin and this setting make it hard to use depends because it makes cmake ignore the CMAKE_INCLUDE_PATH / CMAKE_PREFIX_PATH / CMAKE_LIBRARY_PATH variables constructed in the nix environment to allow cmake to find dependencies.

    I vaguely recall that while working on the CMake staging branch, this line prevented scenarios where, when using depends for the same architecture as the build platform, host packages were considered instead of the ones being built in depends.

    I cannot provide a reproducible example at this moment.

  23. Sjors commented at 3:05 pm on September 23, 2024: member

    This branch MULTIPROCESS=0:

     0x86_64
 18868809b50ea77b47c45c1cdf802e85540d9428f182773b1cd7e5d73750dce87  guix-build-06b4c339e89e/output/aarch64-linux-gnu/SHA256SUMS.part
 2fccf8cf14ca3d3ee7812f254d10eb17e62c507f5b2606c6b099c5d00ed5d3446  guix-build-06b4c339e89e/output/aarch64-linux-gnu/bitcoin-06b4c339e89e-aarch64-linux-gnu-debug.tar.gz
 32d7cf4959e238fae666476db1cd11112c77708a58bb9d5cd1e0c7986c8c477a6  guix-build-06b4c339e89e/output/aarch64-linux-gnu/bitcoin-06b4c339e89e-aarch64-linux-gnu.tar.gz
 422d7016c186928f517a3b69db90d01b2eed3b15b9ecaa53cab5c5cb35d3974d3  guix-build-06b4c339e89e/output/arm-linux-gnueabihf/SHA256SUMS.part
 5a77e95ce28b755f7aeb5d6bca0e084a17d78dca755bb7e21e854ad2c7324fd7c  guix-build-06b4c339e89e/output/arm-linux-gnueabihf/bitcoin-06b4c339e89e-arm-linux-gnueabihf-debug.tar.gz
 6c08fdd60e0b4ba56245fc5e4a50d7537d180fe682108137e951b13c793744bc8  guix-build-06b4c339e89e/output/arm-linux-gnueabihf/bitcoin-06b4c339e89e-arm-linux-gnueabihf.tar.gz
 7f3b6dcdf7a05ca1faa3bbfb01721fddd801070b85ddbdd84d6bb4ecc61b24aac  guix-build-06b4c339e89e/output/arm64-apple-darwin/SHA256SUMS.part
 87877c5d19c602fd85192ba398284e2447f898b1cacc9b9321cb6392b5e451864  guix-build-06b4c339e89e/output/arm64-apple-darwin/bitcoin-06b4c339e89e-arm64-apple-darwin-unsigned.tar.gz
 968acba090e08e71fbc3734673cc649a361de9117692db76ec8aa8f17f4952ea0  guix-build-06b4c339e89e/output/arm64-apple-darwin/bitcoin-06b4c339e89e-arm64-apple-darwin-unsigned.zip
1076d6b38655a2e52079ebcf108c2e9c4ad99ffd76efa7382f8425be043930b7dc  guix-build-06b4c339e89e/output/arm64-apple-darwin/bitcoin-06b4c339e89e-arm64-apple-darwin.tar.gz
1104266bb6fb00caf81afc62df9dae9ca39d8e2da788a093f7d722b4d7038c8a3f  guix-build-06b4c339e89e/output/dist-archive/bitcoin-06b4c339e89e.tar.gz
12ccd67910dc8e7e9d499cdb4914b0c6bcb2fce70902f02b17ec1b789134d7520e  guix-build-06b4c339e89e/output/powerpc64-linux-gnu/SHA256SUMS.part
134e42474ae55caa372fadc8d4552944175e4405b8aa1cb6d7f299450aa47b6862  guix-build-06b4c339e89e/output/powerpc64-linux-gnu/bitcoin-06b4c339e89e-powerpc64-linux-gnu-debug.tar.gz
14ca8f7c6fde62db3c8147539f060b6f67ffb28c072127166cd55042804d390613  guix-build-06b4c339e89e/output/powerpc64-linux-gnu/bitcoin-06b4c339e89e-powerpc64-linux-gnu.tar.gz
154fa8f97503783a1dfdf79133a0c7d98af381203064a83620d357ffcdb0192f12  guix-build-06b4c339e89e/output/riscv64-linux-gnu/SHA256SUMS.part
1680684fa83f4b9cf7e9514eca0828901643d73efe7ff0651d97eed4dab7353172  guix-build-06b4c339e89e/output/riscv64-linux-gnu/bitcoin-06b4c339e89e-riscv64-linux-gnu-debug.tar.gz
1756bfacda24dc665078ba9242c89a9a429705a35298f6fa123bcb257ea7ec7964  guix-build-06b4c339e89e/output/riscv64-linux-gnu/bitcoin-06b4c339e89e-riscv64-linux-gnu.tar.gz
189725713bfda6b9288936aba7ab1598b77275b975628061a5c76f613bf959f60a  guix-build-06b4c339e89e/output/x86_64-apple-darwin/SHA256SUMS.part
19c01a581746d53ac316cd20cbc8504dcdff37a0aa3ded92023fbbb3220782712f  guix-build-06b4c339e89e/output/x86_64-apple-darwin/bitcoin-06b4c339e89e-x86_64-apple-darwin-unsigned.tar.gz
20d1527ef633352089ae823405377af88e469a08aaed04b7f1c40b6f5d7db93d6d  guix-build-06b4c339e89e/output/x86_64-apple-darwin/bitcoin-06b4c339e89e-x86_64-apple-darwin-unsigned.zip
21ffbc384aa5b401246a4f5a3e6879bb03566e13eb215662e3ef381b90eba1c141  guix-build-06b4c339e89e/output/x86_64-apple-darwin/bitcoin-06b4c339e89e-x86_64-apple-darwin.tar.gz
2250bc20c2256ff9209d2c095a862be00a6c8259acbb54d3c40f76019a34e9af6b  guix-build-06b4c339e89e/output/x86_64-linux-gnu/SHA256SUMS.part
239329c9c322240b8cc189d9389996feffd249c949daad0ad87167b0f50f196ebe  guix-build-06b4c339e89e/output/x86_64-linux-gnu/bitcoin-06b4c339e89e-x86_64-linux-gnu-debug.tar.gz
240d46f3124764daf22aabcebaa24dd63df4e804b74ea1e66251c53d36ef8af0e2  guix-build-06b4c339e89e/output/x86_64-linux-gnu/bitcoin-06b4c339e89e-x86_64-linux-gnu.tar.gz
25a13668ea24fc71065d1647ce0c2f75b883818dc20ee06c40a8ae35227bbb295c  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/SHA256SUMS.part
2664ec47382e2e771451b9976f1729593be20687ff92dcfa0526c3fb255c0c734a  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/bitcoin-06b4c339e89e-win64-debug.zip
279d6f9a971ee70a5ad7c6e3c425b0d6b3b0d80604b39198ba60821148fe7d75e4  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/bitcoin-06b4c339e89e-win64-setup-unsigned.exe
281e255cddf39f1d7a1b0d5c92ed71d9a5d2da92af476ae50071e873eb5ee4c30a  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/bitcoin-06b4c339e89e-win64-unsigned.tar.gz
29e34c7c07343f6f4a055edad66d7d9903025134e9028bde7d2673a9782d23e31a  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/bitcoin-06b4c339e89e-win64.zip

    Demo branch MULTIPROCESS=1 and without x86_64-w64-mingw32:

     0x86_64
 1e31ab0eeff88048301f113731a9b829df63e7db2c6a83c3a54e14b6f423aa4a8  guix-build-d8ec933456bc/output/aarch64-linux-gnu/SHA256SUMS.part
 277f4a9481b4ce7df26549c6001384e066a1de3cb1b81ba950c29cc41b0b5c058  guix-build-d8ec933456bc/output/aarch64-linux-gnu/bitcoin-d8ec933456bc-aarch64-linux-gnu-debug.tar.gz
 3ee471d630ea0eb71c2040a3b9e408c4f1709ee29d2da4ecbc1931d93b67e5495  guix-build-d8ec933456bc/output/aarch64-linux-gnu/bitcoin-d8ec933456bc-aarch64-linux-gnu.tar.gz
 49744317e6629543dc888151742d55d0dfdb6f8776c5f5d163b10e79050c3880e  guix-build-d8ec933456bc/output/arm-linux-gnueabihf/SHA256SUMS.part
 5a2883ba1b6580f3f2b36ffc20b07fa75f0ca7bc6ca49bfc21f3848db9fcf0397  guix-build-d8ec933456bc/output/arm-linux-gnueabihf/bitcoin-d8ec933456bc-arm-linux-gnueabihf-debug.tar.gz
 61d99a254ae6399057ea2217fe0c9768ae291f88ec15c0cb65b8a22e122e3a85a  guix-build-d8ec933456bc/output/arm-linux-gnueabihf/bitcoin-d8ec933456bc-arm-linux-gnueabihf.tar.gz
 71046592530177d4277ca3dff6ac19f456b44f665db8d795d4f0ae76020a99524  guix-build-d8ec933456bc/output/arm64-apple-darwin/SHA256SUMS.part
 808bbbe7981d01452a25f2ca508e32a969bf5045e39eed36ff7905137ec1d66b9  guix-build-d8ec933456bc/output/arm64-apple-darwin/bitcoin-d8ec933456bc-arm64-apple-darwin-unsigned.tar.gz
 97b6817f6155911af5a570abc152af197d70401bad1bb072efd6491c82c53f454  guix-build-d8ec933456bc/output/arm64-apple-darwin/bitcoin-d8ec933456bc-arm64-apple-darwin-unsigned.zip
10f4189e3cbb57212a6abd26f90a82fc531d72ada53e75388a962f3d1a9275c09a  guix-build-d8ec933456bc/output/arm64-apple-darwin/bitcoin-d8ec933456bc-arm64-apple-darwin.tar.gz
1170d482a09099931345888a918df5ccc78a0c742b1d18bb8a5d442af9b2717867  guix-build-d8ec933456bc/output/dist-archive/bitcoin-d8ec933456bc.tar.gz
129dad508d7a88f3f1392912a0450ebcd9faa6bd9e1d7a05ed5b70b4609f98dd32  guix-build-d8ec933456bc/output/powerpc64-linux-gnu/SHA256SUMS.part
13695ce97c3aa0653199cc8faa72fab94748f8d86ef2e1112e2d0bb1d859eff266  guix-build-d8ec933456bc/output/powerpc64-linux-gnu/bitcoin-d8ec933456bc-powerpc64-linux-gnu-debug.tar.gz
14d36c8b7fcb8767e34da7a2b3a94cbd80d4127561fca9e369a276bba877e54d23  guix-build-d8ec933456bc/output/powerpc64-linux-gnu/bitcoin-d8ec933456bc-powerpc64-linux-gnu.tar.gz
15427ebc830b497f9eb91a1e8a16f6aab502625c5cde413f8d004f34525ce14b2e  guix-build-d8ec933456bc/output/riscv64-linux-gnu/SHA256SUMS.part
1630ecfa479f73fce75de85a1c47df69fafb42db39f434c350a3c1400cd4c299c5  guix-build-d8ec933456bc/output/riscv64-linux-gnu/bitcoin-d8ec933456bc-riscv64-linux-gnu-debug.tar.gz
1730a647dc75a96547170ec97e9a8523e7b97ef1db08ac61ef447ad17e4d6e32e4  guix-build-d8ec933456bc/output/riscv64-linux-gnu/bitcoin-d8ec933456bc-riscv64-linux-gnu.tar.gz
183994475a244829ecdf355d435e0550eb1677d4bb22f0cb974ba11d2f55f6333d  guix-build-d8ec933456bc/output/x86_64-apple-darwin/SHA256SUMS.part
1938c4915df15fb41238c9fb2ba9186757b8b38dcd4700bf7383a116945f44f806  guix-build-d8ec933456bc/output/x86_64-apple-darwin/bitcoin-d8ec933456bc-x86_64-apple-darwin-unsigned.tar.gz
20c5cf271a16e7597ba585de8c73770fb1ada459749a08dd4aa1d12fcc169a9378  guix-build-d8ec933456bc/output/x86_64-apple-darwin/bitcoin-d8ec933456bc-x86_64-apple-darwin-unsigned.zip
21dfa4f1e060bd1980caaaff950051b7e119408bb560de77f1e1efacee7416a7b5  guix-build-d8ec933456bc/output/x86_64-apple-darwin/bitcoin-d8ec933456bc-x86_64-apple-darwin.tar.gz
22ea9465517c0e1cc559a6a353f404b2bf47447332c918b69410dc51b6c4fbdedc  guix-build-d8ec933456bc/output/x86_64-linux-gnu/SHA256SUMS.part
23f83a296139d0757abc47d053b8fddebc6d2ccc36dabea9b2d52883d23ba923bb  guix-build-d8ec933456bc/output/x86_64-linux-gnu/bitcoin-d8ec933456bc-x86_64-linux-gnu-debug.tar.gz
2481aed48bece8d9bf5327530763c17d73dd66d5a3c666cbaf9381c03d4a660845  guix-build-d8ec933456bc/output/x86_64-linux-gnu/bitcoin-d8ec933456bc-x86_64-linux-gnu.tar.gz
  24. hebasto commented at 3:26 pm on September 23, 2024: member

    I don’t understand why it is switching from _DIR variables to _ROOT variables. According to https://chatgpt.com/c/66f16a25-c068-800a-bba6-36d030d42869 both approaches seem roughly equivalent, but I don’t understand if there was another reason to switch from _DIR to _ROOT.

    1. https://cmake.org/cmake/help/latest/policy/CMP0074.html
    2. <PackageName>_ROOT has top priority for the find_package() command.
    3. <PackageName>_ROOT has its own documentation page.
    4. <packageName>_DIR has mostly optmization purpose. From Professional CMake: A Practical Guide 19th Edition, section 34.4:

    Once a suitable config file for a package has been found, the <packageName>_DIR cache variable will be set to the directory containing that file. Subsequent calls to find_package() will then look in that directory first, and if the config file still exists, it is used without further searching. <packageName>_DIR is ignored if there is no longer a config file for the package at that location. This arrangement ensures that subsequent calls to find_package() for the same package are much faster, even from one invocation of CMake to the next. But the search is still performed if the package is removed.

  25. ryanofsky commented at 3:36 pm on September 23, 2024: contributor
    Thanks for the clarifications. I agree that issues (2) (3) and (4) are not directly related to this PR and would be best to address separately if it makes sense to follow up on them. Those were just things that I didn’t understand, and seemed to intersect with the issue.
  26. hebasto commented at 10:52 pm on September 23, 2024: member

    My Guix build of the demo branch, except for x86_64-w64-mingw32:

     0aarch64
 1e31ab0eeff88048301f113731a9b829df63e7db2c6a83c3a54e14b6f423aa4a8  guix-build-d8ec933456bc/output/aarch64-linux-gnu/SHA256SUMS.part
 277f4a9481b4ce7df26549c6001384e066a1de3cb1b81ba950c29cc41b0b5c058  guix-build-d8ec933456bc/output/aarch64-linux-gnu/bitcoin-d8ec933456bc-aarch64-linux-gnu-debug.tar.gz
 3ee471d630ea0eb71c2040a3b9e408c4f1709ee29d2da4ecbc1931d93b67e5495  guix-build-d8ec933456bc/output/aarch64-linux-gnu/bitcoin-d8ec933456bc-aarch64-linux-gnu.tar.gz
 49744317e6629543dc888151742d55d0dfdb6f8776c5f5d163b10e79050c3880e  guix-build-d8ec933456bc/output/arm-linux-gnueabihf/SHA256SUMS.part
 5a2883ba1b6580f3f2b36ffc20b07fa75f0ca7bc6ca49bfc21f3848db9fcf0397  guix-build-d8ec933456bc/output/arm-linux-gnueabihf/bitcoin-d8ec933456bc-arm-linux-gnueabihf-debug.tar.gz
 61d99a254ae6399057ea2217fe0c9768ae291f88ec15c0cb65b8a22e122e3a85a  guix-build-d8ec933456bc/output/arm-linux-gnueabihf/bitcoin-d8ec933456bc-arm-linux-gnueabihf.tar.gz
 71046592530177d4277ca3dff6ac19f456b44f665db8d795d4f0ae76020a99524  guix-build-d8ec933456bc/output/arm64-apple-darwin/SHA256SUMS.part
 808bbbe7981d01452a25f2ca508e32a969bf5045e39eed36ff7905137ec1d66b9  guix-build-d8ec933456bc/output/arm64-apple-darwin/bitcoin-d8ec933456bc-arm64-apple-darwin-unsigned.tar.gz
 97b6817f6155911af5a570abc152af197d70401bad1bb072efd6491c82c53f454  guix-build-d8ec933456bc/output/arm64-apple-darwin/bitcoin-d8ec933456bc-arm64-apple-darwin-unsigned.zip
10f4189e3cbb57212a6abd26f90a82fc531d72ada53e75388a962f3d1a9275c09a  guix-build-d8ec933456bc/output/arm64-apple-darwin/bitcoin-d8ec933456bc-arm64-apple-darwin.tar.gz
1170d482a09099931345888a918df5ccc78a0c742b1d18bb8a5d442af9b2717867  guix-build-d8ec933456bc/output/dist-archive/bitcoin-d8ec933456bc.tar.gz
129dad508d7a88f3f1392912a0450ebcd9faa6bd9e1d7a05ed5b70b4609f98dd32  guix-build-d8ec933456bc/output/powerpc64-linux-gnu/SHA256SUMS.part
13695ce97c3aa0653199cc8faa72fab94748f8d86ef2e1112e2d0bb1d859eff266  guix-build-d8ec933456bc/output/powerpc64-linux-gnu/bitcoin-d8ec933456bc-powerpc64-linux-gnu-debug.tar.gz
14d36c8b7fcb8767e34da7a2b3a94cbd80d4127561fca9e369a276bba877e54d23  guix-build-d8ec933456bc/output/powerpc64-linux-gnu/bitcoin-d8ec933456bc-powerpc64-linux-gnu.tar.gz
15427ebc830b497f9eb91a1e8a16f6aab502625c5cde413f8d004f34525ce14b2e  guix-build-d8ec933456bc/output/riscv64-linux-gnu/SHA256SUMS.part
1630ecfa479f73fce75de85a1c47df69fafb42db39f434c350a3c1400cd4c299c5  guix-build-d8ec933456bc/output/riscv64-linux-gnu/bitcoin-d8ec933456bc-riscv64-linux-gnu-debug.tar.gz
1730a647dc75a96547170ec97e9a8523e7b97ef1db08ac61ef447ad17e4d6e32e4  guix-build-d8ec933456bc/output/riscv64-linux-gnu/bitcoin-d8ec933456bc-riscv64-linux-gnu.tar.gz
183994475a244829ecdf355d435e0550eb1677d4bb22f0cb974ba11d2f55f6333d  guix-build-d8ec933456bc/output/x86_64-apple-darwin/SHA256SUMS.part
1938c4915df15fb41238c9fb2ba9186757b8b38dcd4700bf7383a116945f44f806  guix-build-d8ec933456bc/output/x86_64-apple-darwin/bitcoin-d8ec933456bc-x86_64-apple-darwin-unsigned.tar.gz
20c5cf271a16e7597ba585de8c73770fb1ada459749a08dd4aa1d12fcc169a9378  guix-build-d8ec933456bc/output/x86_64-apple-darwin/bitcoin-d8ec933456bc-x86_64-apple-darwin-unsigned.zip
21dfa4f1e060bd1980caaaff950051b7e119408bb560de77f1e1efacee7416a7b5  guix-build-d8ec933456bc/output/x86_64-apple-darwin/bitcoin-d8ec933456bc-x86_64-apple-darwin.tar.gz
22ea9465517c0e1cc559a6a353f404b2bf47447332c918b69410dc51b6c4fbdedc  guix-build-d8ec933456bc/output/x86_64-linux-gnu/SHA256SUMS.part
23f83a296139d0757abc47d053b8fddebc6d2ccc36dabea9b2d52883d23ba923bb  guix-build-d8ec933456bc/output/x86_64-linux-gnu/bitcoin-d8ec933456bc-x86_64-linux-gnu-debug.tar.gz
2481aed48bece8d9bf5327530763c17d73dd66d5a3c666cbaf9381c03d4a660845  guix-build-d8ec933456bc/output/x86_64-linux-gnu/bitcoin-d8ec933456bc-x86_64-linux-gnu.tar.gz
  27. fanquake commented at 9:43 am on September 27, 2024: member

    Guix Build (x86_64):

     08868809b50ea77b47c45c1cdf802e85540d9428f182773b1cd7e5d73750dce87  guix-build-06b4c339e89e/output/aarch64-linux-gnu/SHA256SUMS.part
 1fccf8cf14ca3d3ee7812f254d10eb17e62c507f5b2606c6b099c5d00ed5d3446  guix-build-06b4c339e89e/output/aarch64-linux-gnu/bitcoin-06b4c339e89e-aarch64-linux-gnu-debug.tar.gz
 22d7cf4959e238fae666476db1cd11112c77708a58bb9d5cd1e0c7986c8c477a6  guix-build-06b4c339e89e/output/aarch64-linux-gnu/bitcoin-06b4c339e89e-aarch64-linux-gnu.tar.gz
 322d7016c186928f517a3b69db90d01b2eed3b15b9ecaa53cab5c5cb35d3974d3  guix-build-06b4c339e89e/output/arm-linux-gnueabihf/SHA256SUMS.part
 4a77e95ce28b755f7aeb5d6bca0e084a17d78dca755bb7e21e854ad2c7324fd7c  guix-build-06b4c339e89e/output/arm-linux-gnueabihf/bitcoin-06b4c339e89e-arm-linux-gnueabihf-debug.tar.gz
 5c08fdd60e0b4ba56245fc5e4a50d7537d180fe682108137e951b13c793744bc8  guix-build-06b4c339e89e/output/arm-linux-gnueabihf/bitcoin-06b4c339e89e-arm-linux-gnueabihf.tar.gz
 6f3b6dcdf7a05ca1faa3bbfb01721fddd801070b85ddbdd84d6bb4ecc61b24aac  guix-build-06b4c339e89e/output/arm64-apple-darwin/SHA256SUMS.part
 77877c5d19c602fd85192ba398284e2447f898b1cacc9b9321cb6392b5e451864  guix-build-06b4c339e89e/output/arm64-apple-darwin/bitcoin-06b4c339e89e-arm64-apple-darwin-unsigned.tar.gz
 868acba090e08e71fbc3734673cc649a361de9117692db76ec8aa8f17f4952ea0  guix-build-06b4c339e89e/output/arm64-apple-darwin/bitcoin-06b4c339e89e-arm64-apple-darwin-unsigned.zip
 976d6b38655a2e52079ebcf108c2e9c4ad99ffd76efa7382f8425be043930b7dc  guix-build-06b4c339e89e/output/arm64-apple-darwin/bitcoin-06b4c339e89e-arm64-apple-darwin.tar.gz
1004266bb6fb00caf81afc62df9dae9ca39d8e2da788a093f7d722b4d7038c8a3f  guix-build-06b4c339e89e/output/dist-archive/bitcoin-06b4c339e89e.tar.gz
11ccd67910dc8e7e9d499cdb4914b0c6bcb2fce70902f02b17ec1b789134d7520e  guix-build-06b4c339e89e/output/powerpc64-linux-gnu/SHA256SUMS.part
124e42474ae55caa372fadc8d4552944175e4405b8aa1cb6d7f299450aa47b6862  guix-build-06b4c339e89e/output/powerpc64-linux-gnu/bitcoin-06b4c339e89e-powerpc64-linux-gnu-debug.tar.gz
13ca8f7c6fde62db3c8147539f060b6f67ffb28c072127166cd55042804d390613  guix-build-06b4c339e89e/output/powerpc64-linux-gnu/bitcoin-06b4c339e89e-powerpc64-linux-gnu.tar.gz
144fa8f97503783a1dfdf79133a0c7d98af381203064a83620d357ffcdb0192f12  guix-build-06b4c339e89e/output/riscv64-linux-gnu/SHA256SUMS.part
1580684fa83f4b9cf7e9514eca0828901643d73efe7ff0651d97eed4dab7353172  guix-build-06b4c339e89e/output/riscv64-linux-gnu/bitcoin-06b4c339e89e-riscv64-linux-gnu-debug.tar.gz
1656bfacda24dc665078ba9242c89a9a429705a35298f6fa123bcb257ea7ec7964  guix-build-06b4c339e89e/output/riscv64-linux-gnu/bitcoin-06b4c339e89e-riscv64-linux-gnu.tar.gz
179725713bfda6b9288936aba7ab1598b77275b975628061a5c76f613bf959f60a  guix-build-06b4c339e89e/output/x86_64-apple-darwin/SHA256SUMS.part
18c01a581746d53ac316cd20cbc8504dcdff37a0aa3ded92023fbbb3220782712f  guix-build-06b4c339e89e/output/x86_64-apple-darwin/bitcoin-06b4c339e89e-x86_64-apple-darwin-unsigned.tar.gz
19d1527ef633352089ae823405377af88e469a08aaed04b7f1c40b6f5d7db93d6d  guix-build-06b4c339e89e/output/x86_64-apple-darwin/bitcoin-06b4c339e89e-x86_64-apple-darwin-unsigned.zip
20ffbc384aa5b401246a4f5a3e6879bb03566e13eb215662e3ef381b90eba1c141  guix-build-06b4c339e89e/output/x86_64-apple-darwin/bitcoin-06b4c339e89e-x86_64-apple-darwin.tar.gz
2150bc20c2256ff9209d2c095a862be00a6c8259acbb54d3c40f76019a34e9af6b  guix-build-06b4c339e89e/output/x86_64-linux-gnu/SHA256SUMS.part
229329c9c322240b8cc189d9389996feffd249c949daad0ad87167b0f50f196ebe  guix-build-06b4c339e89e/output/x86_64-linux-gnu/bitcoin-06b4c339e89e-x86_64-linux-gnu-debug.tar.gz
230d46f3124764daf22aabcebaa24dd63df4e804b74ea1e66251c53d36ef8af0e2  guix-build-06b4c339e89e/output/x86_64-linux-gnu/bitcoin-06b4c339e89e-x86_64-linux-gnu.tar.gz
24a13668ea24fc71065d1647ce0c2f75b883818dc20ee06c40a8ae35227bbb295c  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/SHA256SUMS.part
2564ec47382e2e771451b9976f1729593be20687ff92dcfa0526c3fb255c0c734a  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/bitcoin-06b4c339e89e-win64-debug.zip
269d6f9a971ee70a5ad7c6e3c425b0d6b3b0d80604b39198ba60821148fe7d75e4  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/bitcoin-06b4c339e89e-win64-setup-unsigned.exe
271e255cddf39f1d7a1b0d5c92ed71d9a5d2da92af476ae50071e873eb5ee4c30a  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/bitcoin-06b4c339e89e-win64-unsigned.tar.gz
28e34c7c07343f6f4a055edad66d7d9903025134e9028bde7d2673a9782d23e31a  guix-build-06b4c339e89e/output/x86_64-w64-mingw32/bitcoin-06b4c339e89e-win64.zip
  28. fanquake approved
  29. fanquake commented at 9:44 am on September 27, 2024: member
    ACK 06b4c339e89e593d951a90cd2d1bce944acf3bf7
  30. fanquake merged this on Sep 27, 2024
  31. fanquake closed this on Sep 27, 2024
  32. hebasto deleted the branch on Sep 27, 2024
  33. hebasto commented at 2:00 pm on September 27, 2024: member

    @ryanofsky

    1. I don’t understand why “In the Guix environment, ${BASEPREFIX}/${HOST}/native/bin is added to the PATH environment variable,” according to the description. Setting this seems indiscriminate, like a sledgehammer approach, something that would cause the guix build to behave differently from normal depends builds and lead to confusing issues like this one.

    Addressed in #30989.


hebasto DrahtBot Sjors fanquake ryanofsky

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me