test: Use shell builtins in run_command test case #30952

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:fix-runcommand-test changing 1 files +1 −1
  1. achow101 commented at 5:04 pm on September 23, 2024: member

    Uses the suggested command

    Fixes #30938

  2. test: Use shell builtins in run_command test case 7bd3ee62f6
  3. DrahtBot commented at 5:04 pm on September 23, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #29868 (Reintroduce external signer support for Windows by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot added the label Tests on Sep 23, 2024
  5. achow101 added this to the milestone 28.0 on Sep 23, 2024
  6. achow101 added the label Needs backport (28.x) on Sep 23, 2024
  7. maflcko commented at 6:18 am on September 24, 2024: member

    review ACK 7bd3ee62f6d6f59ca599e85f81776d282dee1539

    Seems fine to replace the python3 dependency with sh, assuming that sh is available on more systems (at least on all systems where ls was previously available)

  8. hebasto approved
  9. hebasto commented at 10:49 am on September 24, 2024: member

    ACK 7bd3ee62f6d6f59ca599e85f81776d282dee1539.

    The new command does exactly what is described in the comment above.

    Both sh and echo are expected to be available on systems where ls (from the original implementation) is available.

  10. fanquake merged this on Sep 24, 2024
  11. fanquake closed this on Sep 24, 2024

  12. achow101 referenced this in commit e24a25d882 on Sep 24, 2024
  13. achow101 commented at 3:41 pm on September 24, 2024: member
    Backported in #30959
  14. achow101 removed the label Needs backport (28.x) on Sep 24, 2024


achow101 DrahtBot maflcko hebasto

Labels
Tests

Milestone
28.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-08 16:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me