[28.x] backports and finalize #30959
pull achow101 wants to merge 5 commits into bitcoin:28.x from achow101:28.0rc3-backports changing 10 files +381 −22-
achow101 commented at 3:41 pm on September 24, 2024: member
-
test: Use shell builtins in run_command test case
Github-Pull: bitcoin/bitcoin#30952 Rebased-From: 7bd3ee62f6d6f59ca599e85f81776d282dee1539
-
DrahtBot commented at 3:41 pm on September 24, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage
For detailed information about the code coverage, see the test coverage report.
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
DrahtBot added the label Backport on Sep 24, 2024
-
achow101 added this to the milestone 28.0 on Sep 24, 2024
-
achow101 renamed this:
[28.x] Further backports
[28.x] backports and finalize (or rc3)
on Sep 24, 2024 -
hebasto approved
-
hebasto commented at 10:49 am on September 25, 2024: member
ACK 1f6c3caf30849a6e53957aa15c6ac27b97004dc5.
A new backport only affects the test code, so I agree to skip the rc3 phase.
-
validation: Disable CheckForkWarningConditions for background chainstate
The comparison of m_best_invalid with the tip of the respective chainstate makes no sense for the background chainstate, and can lead to incorrect error messages. Github-Pull: bitcoin/bitcoin#30962 Rebased-From: c0a0c72b4d68a4f0c53c2c4b95f4d6e399f8e4ee
-
build: Bump to 28.0 5feef9ce7e
-
doc: generate manpages 98745e03ff
-
achow101 force-pushed on Sep 25, 2024
-
stickies-v commented at 3:23 pm on September 27, 2024: contributor
code LGTM 98745e03ffc9f69f901b827e19e4d8d645a27112
Verified all backport commits are clean and make sense, and that I’m getting the same manpages. I think
doc/release-notes.md
still needs to be updated though? -
achow101 commented at 4:01 pm on September 30, 2024: member
I think
doc/release-notes.md
still needs to be updated though?I think that’s usually done when after the release is published on the website.
-
achow101 renamed this:
[28.x] backports and finalize (or rc3)
[28.x] backports and finalize
on Sep 30, 2024 -
stickies-v commented at 5:07 pm on September 30, 2024: contributor
It seems to have been the process for 26.0 and 27.0 at least:
-
achow101 commented at 5:19 pm on September 30, 2024: memberHmm ok, will add those soon. Still some changes to be made on the release notes.
-
doc: 28.0 Release Notes 5de225f5c1
-
achow101 commented at 9:14 pm on September 30, 2024: memberAdded release notes (as of eab8c9df5996bfe0d0997f747eefbdb745381aa0)
-
instagibbs commented at 5:05 pm on October 1, 2024: member
-
sipa commented at 5:12 pm on October 1, 2024: memberutACK 5de225f5c145368f70cb5f870933bcf9df6b92c8
-
DrahtBot requested review from hebasto on Oct 1, 2024
-
achow101 merged this on Oct 1, 2024
-
achow101 closed this on Oct 1, 2024
-
glozow commented at 5:40 pm on October 1, 2024: memberpost merge ACK
-
stickies-v commented at 6:38 pm on October 1, 2024: contributor
Added release notes (as of eab8c9df5996bfe0d0997f747eefbdb745381aa0)
Thanks! I’ve added https://github.com/bitcoin-core/bitcoin-devwiki/wiki/28.0-Release-Notes-Draft/6677e1b3aa3ecadd142786f1393d2a7affe9e03e which adds missing PR numbers.
Release notes otherwise LGTM, I verified the author list and read through the descriptions. I think these 3 might benefit from being added to the list too, I’ll give them a go later:
- bitcoin/bitcoin#29648
- bitcoin/bitcoin#28981
- bitcoin/bitcoin#28280
Edit: oh, too late. I’m on bad wifi today, didn’t see it got merged already.
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-08 16:12 UTC
More mirrored repositories can be found on mirror.b10c.me