ci: add LLVM_SYMBOLIZER_PATH to Valgrind fuzz job #30961

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:valgrind_symbolizer changing 1 files +1 −0
  1. fanquake commented at 4:06 pm on September 24, 2024: member

    Otherwise:

    0	NEW_FUNC[1/23]: ==4710==WARNING: invalid path to external symbolizer!
    1==4710==WARNING: Failed to use and restart external symbolizer!
    20xb72010  (/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0xa6a010) (BuildId: 2087ad415cb752eea259ed750f3b78a7fcb0b43b)
    3	NEW_FUNC[2/23]: 0xb72240  (/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0xa6a240) (BuildId: 2087ad415cb752eea259ed750f3b78a7fcb0b43b)
    
  2. ci: add LLVM_SYMBOLIZER_PATH to Valgrind fuzz job
    Otherwise:
    ```bash
    	NEW_FUNC[1/23]: ==4710==WARNING: invalid path to external symbolizer!
    ==4710==WARNING: Failed to use and restart external symbolizer!
    0xb72010  (/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0xa6a010) (BuildId: 2087ad415cb752eea259ed750f3b78a7fcb0b43b)
    	NEW_FUNC[2/23]: 0xb72240  (/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0xa6a240) (BuildId: 2087ad415cb752eea259ed750f3b78a7fcb0b43b)
    
    ```
    c1832584bf
  3. DrahtBot commented at 4:06 pm on September 24, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Sep 24, 2024
  5. theuni commented at 8:19 pm on September 25, 2024: member
    Makes sense to me. I assume this could also be solved with a symlink or update-alternatives, but even if so, using the env var seems simpler.
  6. maflcko commented at 6:31 am on September 26, 2024: member

    Otherwise:

    Can you explain this a bit better? The CI task is passing, see https://cirrus-ci.com/task/6297362342084608

    So I presume this is just for the case when an error happens, because otherwise the symbolizer wouldn’t be asked?

  7. fanquake commented at 6:44 am on September 26, 2024: member

    So I presume this is just for the case when an error happens, because otherwise the symbolizer wouldn’t be asked?

    Yea. Or fuzzing with no corpus. https://cirrus-ci.com/task/6297362342084608?logs=ci#L2903.

  8. maflcko commented at 6:50 am on September 26, 2024: member
    review ACK c1832584bfd1b352095bc41a13ff17564e456d43
  9. fanquake merged this on Sep 26, 2024
  10. fanquake closed this on Sep 26, 2024

  11. fanquake deleted the branch on Sep 26, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-08 16:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me