validation: Disable CheckForkWarningConditions for background chainstate #30962

1. 
   mzumsande commented at 6:22 PM on September 24, 2024: contributor

   The comparison of m_best_invalid with the tip of the chainstate makes no sense for the background chainstate and can lead to incorrect log messages.

   Fixes #30958

2. 
   DrahtBot commented at 6:22 PM on September 24, 2024: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	TheCharlatan, fjahr, tdb3, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Validation on Sep 24, 2024
4. mzumsande force-pushed on Sep 24, 2024
5. validation: Disable CheckForkWarningConditions for background chainstate

   The comparison of m_best_invalid with the tip of the respective chainstate
   makes no sense for the background chainstate, and can lead to incorrect
   error messages.

   c0a0c72b4d
6. mzumsande force-pushed on Sep 24, 2024
7. TheCharlatan approved
8. 
   TheCharlatan commented at 7:53 PM on September 24, 2024: contributor

   ACK c0a0c72b4d68a4f0c53c2c4b95f4d6e399f8e4ee

9. 
   fjahr commented at 7:59 PM on September 24, 2024: contributor

   utACK c0a0c72b4d68a4f0c53c2c4b95f4d6e399f8e4ee

10. tdb3 approved
11. 
    tdb3 commented at 12:11 PM on September 25, 2024: contributor

    CR ACK c0a0c72b4d68a4f0c53c2c4b95f4d6e399f8e4ee

12. 
    achow101 commented at 6:27 PM on September 25, 2024: member

    ACK c0a0c72b4d68a4f0c53c2c4b95f4d6e399f8e4ee

13. achow101 added this to the milestone 28.0 on Sep 25, 2024
14. achow101 added the label Needs backport (28.x) on Sep 25, 2024
15. achow101 merged this on Sep 25, 2024
16. achow101 closed this on Sep 25, 2024

    ---

17. achow101 referenced this in commit 7fcd7b85c6 on Sep 25, 2024
18. achow101 removed the label Needs backport (28.x) on Sep 25, 2024
19. 
    achow101 commented at 6:36 PM on September 25, 2024: member

    Backport in #30959

20. mzumsande deleted the branch on Sep 26, 2024
21. achow101 referenced this in commit 1101837461 on Oct 1, 2024
22. TheCharlatan referenced this in commit 8bb47d4c2c on Nov 2, 2024
23. bitcoin locked this on Sep 26, 2025

Milestone
28.0