build: Add missing USDT header dependency to kernel #30970

1. 
   theuni commented at 4:26 pm on September 25, 2024: member

   Noticed while testing a branch that replaces boost::multi_index with a custom replacement.

   Currently depends builds pick up usdt and boost from the same path, and because boost always exists, the usdt path is implicitly included. So without boost, USDT isn’t found.

   An alternative to this would be to disable USDT for the kernel. I’d be open to either approach.

2. build: Add missing USDT header dependency to kernel ccd10fdb97
3. 
   DrahtBot commented at 4:26 pm on September 25, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto
   Concept ACK	TheCharlatan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28690 (build: Introduce internal kernel library by TheCharlatan)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Build system on Sep 25, 2024
5. 
   theuni commented at 4:26 pm on September 25, 2024: member

   Ping @hebasto @TheCharlatan
6. 
   TheCharlatan commented at 7:42 pm on September 25, 2024: contributor

   Concept ACK

   Good find, I think just including it like you’ve done here is ok for now.

7. maflcko added the label DrahtBot Guix build requested on Sep 26, 2024
8. maflcko removed the label DrahtBot Guix build requested on Sep 26, 2024
9. hebasto approved
10. 
    hebasto commented at 10:42 am on September 26, 2024: member

    ACK ccd10fdb97f9b8268a5cd60d7461967cfe536f16, the diff looks correct.

    Ideally, such changes should be enforced by a failure to compile:

    0/home/hebasto/git/bitcoin/src/util/trace.h:12:10: fatal error: sys/sdt.h: No such file or directory
    1    8 | #include <sys/sdt.h>
    2      |          ^~~~~~~~~~~
    3compilation terminated.
    

    However, when building with depends, the compiler is still able to include a system-wide header:

    0$ sudo apt install systemtap-sdt-dev
    1$ make -C depends NO_QT=1 NO_WALLET=1 NO_ZMQ=1 NO_NATPMP=1 NO_UPNP=1
    2$ cmake -B build --toolchain depends/x86_64-pc-linux-gnu/toolchain.cmake -DBUILD_KERNEL_LIB=ON
    3$ rm -rf depends/x86_64-pc-linux-gnu/include/sys
    4$ cmake --build build  # no compiler errors
    

11. DrahtBot requested review from TheCharlatan on Sep 26, 2024
12. DrahtBot added the label CI failed on Sep 29, 2024
13. DrahtBot removed the label CI failed on Sep 29, 2024

Contributors
theuni DrahtBot TheCharlatan hebasto

Review Requested
TheCharlatan

Labels
Build system