ci: Inline PACKAGE_MANAGER_INSTALL #30974

1. 
   maflcko commented at 10:09 AM on September 26, 2024: member

   The fallback bash -c "$PACKAGE_MANAGER_INSTALL git" is only needed by the lint task, so simplify it and inline PACKAGE_MANAGER_INSTALL once. Also, fixup the docs to add some other packages which are needed by podman in user-mode.

2. 
   DrahtBot commented at 10:09 AM on September 26, 2024: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Tests on Sep 26, 2024
4. maflcko force-pushed on Sep 26, 2024
5. DrahtBot added the label CI failed on Sep 26, 2024
6. 
   DrahtBot commented at 10:12 AM on September 26, 2024: contributor

   <!--85328a0da195eb286784d51f73fa0af9-->

   🚧 At least one of the CI tasks failed. _{Debug: https://github.com/bitcoin/bitcoin/runs/30697188070}

   <details><summary>Hints</summary>

   Make sure to run all tests locally, according to the documentation.

   The failure may happen due to a number of reasons, for example:

   • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

   • An intermittent issue.

   Leave a comment here, if you need help tracking down a confusing failure.

   </details>

7. maflcko renamed this:
   ci: Require git to be installed on workers
   ci: Inline PACKAGE_MANAGER_INSTALL
   on Sep 26, 2024
8. maflcko force-pushed on Sep 26, 2024
9. DrahtBot removed the label CI failed on Sep 26, 2024
10. maflcko requested review from willcl-ark on Sep 26, 2024
11. DrahtBot added the label Needs rebase on Sep 26, 2024
12. ci: Inline PACKAGE_MANAGER_INSTALL fafd1a0f64
13. maflcko force-pushed on Sep 26, 2024
14. DrahtBot removed the label Needs rebase on Sep 26, 2024
15. 
    maflcko commented at 7:08 PM on September 26, 2024: member

    (rebased)

16. fanquake approved
17. 
    fanquake commented at 9:43 AM on September 27, 2024: member

    ACK fafd1a0f648fcd602166d01d47da417b0eb380df

18. fanquake merged this on Sep 27, 2024
19. fanquake closed this on Sep 27, 2024

    ---

20. maflcko deleted the branch on Sep 27, 2024
21. TheCharlatan referenced this in commit 8bb47d4c2c on Nov 2, 2024
22. bitcoin locked this on Sep 27, 2025

Contributors

maflckoDrahtBotfanquake

Review Requested
willcl-ark