build: Fix kernel static lib component install #31078

pull TheCharlatan wants to merge 2 commits into bitcoin:master from TheCharlatan:install_kernel_component changing 1 files +4 −8
  1. TheCharlatan commented at 6:37 pm on October 12, 2024: contributor

    Fixes the installation of the pkgconfig file and the static library when installing only the Kernel component.

    This is a followup to fix #30835 and #30814, which were merged shortly after one another, but are interrelated. Can be tested with:

    0cmake -B build -DBUILD_SHARED_LIBS=OFF -DBUILD_KERNEL_LIB=ON
    1cmake --build build --target bitcoinkernel
    2cmake --install build --component Kernel
    
  2. build: Add static libraries to Kernel install component 42e6277987
  3. cmake: Refactor install kernel dependencies 82e16e6983
  4. DrahtBot commented at 6:38 pm on October 12, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #30595 (kernel: Introduce initial C header API by TheCharlatan)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. DrahtBot added the label Build system on Oct 12, 2024
  6. hebasto commented at 6:43 pm on October 12, 2024: member
    Concept ACK.
  7. DrahtBot added the label CI failed on Oct 12, 2024
  8. DrahtBot removed the label CI failed on Oct 12, 2024
  9. jarolrod commented at 5:05 pm on October 14, 2024: member

    concept ack

    master install

    0cmake --install build --component Kernel
    1-- Install configuration: "RelWithDebInfo"
    2-- Installing: /usr/local/lib/libbitcoinkernel.a
    

    pr install

     0cmake --install build --component Kernel
     1-- Install configuration: "RelWithDebInfo"
     2-- Installing: /usr/local/lib/libbitcoin_crypto.a
     3-- Installing: /usr/local/lib/libbitcoin_crypto_sse41.a
     4-- Installing: /usr/local/lib/libbitcoin_crypto_avx2.a
     5-- Installing: /usr/local/lib/libbitcoin_crypto_x86_shani.a
     6-- Installing: /usr/local/lib/libleveldb.a
     7-- Installing: /usr/local/lib/libcrc32c.a
     8-- Installing: /usr/local/lib/libcrc32c_sse42.a
     9-- Installing: /usr/local/lib/libsecp256k1.a
    10-- Installing: /usr/local/lib/pkgconfig/libbitcoinkernel.pc
    11-- Installing: /usr/local/lib/libbitcoinkernel.a
    
  10. fanquake requested review from theuni on Oct 21, 2024
  11. hebasto approved
  12. hebasto commented at 4:03 pm on October 22, 2024: member
    ACK 82e16e698321ea6fb69ce5a08b048347aab8c74e, tested on Ubuntu 23.10.
  13. fanquake approved
  14. fanquake commented at 8:53 am on October 24, 2024: member
    ACK 82e16e698321ea6fb69ce5a08b048347aab8c74e
  15. fanquake merged this on Oct 24, 2024
  16. fanquake closed this on Oct 24, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me