This PR enables building and installing only libbitcoinkernel, without the need to disable other targets during the project build system generation:
$ rm -rf build && cmake -B build -DBUILD_KERNEL_LIB=ON
$ cmake --build build --target bitcoinkernel
$ cmake --install build --component Kernel --prefix /home/hebasto/INSTALL
-- Install configuration: "RelWithDebInfo"
-- Installing: /home/hebasto/INSTALL/lib/libbitcoinkernel.so
Please note, that only the bitcoinkernel target is being built.
This change enables building and installing only `libbitcoinkernel`,
without the need to disable other targets during the project build
system generation.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | TheCharlatan, ryanofsky |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
99 | @@ -100,7 +100,13 @@ set_target_properties(bitcoinkernel PROPERTIES 100 | 101 | include(GNUInstallDirs) 102 | install(TARGETS bitcoinkernel 103 | - RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} 104 | - LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} 105 | - ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} 106 | + RUNTIME 107 | + DESTINATION ${CMAKE_INSTALL_BINDIR} 108 | + COMPONENT Kernel
Why call this Kernel and not bitcoinkernel?
For brevity. Do you want me to update it?
I don't think it matters really what it is called. As far as I know there is no way to list all available install components from the command line and discover its name. With the targets you can at least do cmake --build build --target help, so my idea was that this might make it more discoverable. But a component might also include multiple targets, so I don't think colliding their names here really helps in terms of making it clearer. So in short, no need to change.
ACK 7b04fabe2d95f05a295b1ef30c9aeab7f753ed46
Code review ACK 7b04fabe2d95f05a295b1ef30c9aeab7f753ed46
$ rm -rf build && cmake -B build -DBUILD_KERNEL_LIB=ON $ cmake --build build --target bitcoinkernel $ cmake --install build --component Kernel --prefix /home/hebasto/INSTALL
Might be nice to document the steps for building and installing one component somewhere. I'm not sure if there is kernel library documentation where these steps could go.