Issue:
The text mentions that the createwallet command should use the options disable_private_keys=true, blank=true, but the provided command only includes disable_private_keys=true, missing the blank=true option.
Correction:
Added blank=true to the command to match the options described in the text.
Explanation:
The blank=true option is necessary to create a blank wallet. Including this option ensures the command matches the options specified in the text.
Issue:
The text mentions that the `createwallet` command should use the options `disable_private_keys=true, blank=true`, but the provided command only includes `disable_private_keys=true`, missing the `blank=true` option.
Correction:
Added `blank=true` to the command to match the options described in the text.
Explanation:
The `blank=true` option is necessary to create a blank wallet. Including this option ensures the command matches the options specified in the text.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31237.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | fanquake |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
ACK ec375de39ff8e0d44fc026618a234e37019e46c1
Post merge -0
disable_private_keys already implies blank so there isn't really a point in specifying blank explicitly. I would have preferred to remove the earlier text that says both options would be set.
I guess if we decide to do that, we can also update the other guides that are doing this redundantly, i.e: https://github.com/bitcoin/bitcoin/blob/master/doc/multisig-tutorial.md#13-create-the-multisig-wallet.