Clarify log messages when handling SOCKS5 proxy connections.
Suggested in #29420 (review)
Clarify log messages when handling SOCKS5 proxy connections.
Suggested in #29420 (review)
Co-authored-by: Martin Zumsande <mzumsande@gmail.com>
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31239.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
No conflicts as of last run.
code review ACK 99d9a093cf6d53b24d4a48f5845e0e0299f47800
While we’re updating this file, looks like docstring for handle()
should say RFC1928
instead of RFC192
. https://www.rfc-editor.org/rfc/rfc1928.txt
0 def handle(self):
1 """Handle socks5 request according to RFC192."""
While we’re updating this file,
Pulled this into another branch.