test: clarify log messages when handling SOCKS5 proxy connections #31239

pull vasild wants to merge 1 commits into bitcoin:master from vasild:socks5proxy_log changing 1 files +4 −2
  1. vasild commented at 1:24 pm on November 7, 2024: contributor

    Clarify log messages when handling SOCKS5 proxy connections.

    Suggested in #29420 (review)

  2. test: clarify log messages when handling SOCKS5 proxy connections
    Co-authored-by: Martin Zumsande <mzumsande@gmail.com>
    99d9a093cf
  3. DrahtBot commented at 1:24 pm on November 7, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31239.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK mzumsande, tdb3

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    No conflicts as of last run.

  4. DrahtBot added the label Tests on Nov 7, 2024
  5. mzumsande commented at 3:45 pm on November 7, 2024: contributor
    Code Review ACK 99d9a093cf6d53b24d4a48f5845e0e0299f47800
  6. tdb3 approved
  7. tdb3 commented at 10:18 pm on November 8, 2024: contributor

    code review ACK 99d9a093cf6d53b24d4a48f5845e0e0299f47800

    While we’re updating this file, looks like docstring for handle() should say RFC1928 instead of RFC192. https://www.rfc-editor.org/rfc/rfc1928.txt

    0    def handle(self):
    1        """Handle socks5 request according to RFC192."""
    
  8. fanquake commented at 2:08 pm on November 11, 2024: member

    While we’re updating this file,

    Pulled this into another branch.

  9. fanquake merged this on Nov 11, 2024
  10. fanquake closed this on Nov 11, 2024

  11. vasild deleted the branch on Nov 11, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-22 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me