test: clarify log messages when handling SOCKS5 proxy connections #31239

pull vasild wants to merge 1 commits into bitcoin:master from vasild:socks5proxy_log changing 1 files +4 −2

vasild commented at 1:24 PM on November 7, 2024: contributor

Clarify log messages when handling SOCKS5 proxy connections.

Suggested in #29420 (review)
test: clarify log messages when handling SOCKS5 proxy connections
Co-authored-by: Martin Zumsande <mzumsande@gmail.com>
99d9a093cf
DrahtBot commented at 1:24 PM on November 7, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31239.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK mzumsande, tdb3

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

No conflicts as of last run.
DrahtBot added the label Tests on Nov 7, 2024
mzumsande commented at 3:45 PM on November 7, 2024: contributor

Code Review ACK 99d9a093cf6d53b24d4a48f5845e0e0299f47800
tdb3 approved
tdb3 commented at 10:18 PM on November 8, 2024: contributor
code review ACK 99d9a093cf6d53b24d4a48f5845e0e0299f47800

While we're updating this file, looks like docstring for handle() should say RFC1928 instead of RFC192. https://www.rfc-editor.org/rfc/rfc1928.txt
```
    def handle(self):
        """Handle socks5 request according to RFC192."""
```
fanquake commented at 2:08 PM on November 11, 2024: member

While we're updating this file,

Pulled this into another branch.
fanquake merged this on Nov 11, 2024
fanquake closed this on Nov 11, 2024
vasild deleted the branch on Nov 11, 2024
fanquake referenced this in commit 3fb6229dcf on Nov 12, 2024
TheCharlatan referenced this in commit a73b2bd0f0 on Nov 14, 2024
bug-castercv502 referenced this in commit fdcc066ca0 on Sep 28, 2025
bitcoin locked this on Nov 11, 2025