wallet: Disable creating and loading legacy wallets #31250

1. 
   achow101 commented at 6:42 pm on November 7, 2024: member

   To prepare for the deletion of legacy wallet code, disable creating or loading new legacy wallets.

   Tests for the legacy wallet specifically are deleted.

   Depends on #31248 and #31241

   Split from https://github.com/bitcoin/bitcoin/pull/28710

2. 
   DrahtBot commented at 6:42 pm on November 7, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31250.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #31298 (rpc: combinerawtransaction now rejects unmergeable transactions by adamandrews1)
   • #31295 (refactor: Prepare compile-time check of bilingual format strings by maflcko)
   • #31278 (wallet, rpc: Settxfeerate by polespinasa)
   • #31260 (scripted-diff: Type-safe settings retrieval by ryanofsky)
   • #31248 (test: Rework wallet_migration.py to use previous releases by achow101)
   • #31241 (wallet: remove BDB dependency from wallet migration benchmark by furszy)
   • #31072 (refactor: Clean up messy strformat and bilingual_str usages by ryanofsky)
   • #31061 (refactor: Check translatable format strings at compile-time by maflcko)
   • #30893 (test: Introduce ensure_for helper by fjahr)
   • #30860 (test: autogenerate bash completion by BrandonOdiwuor)
   • #30844 (RPC: improve SFFO arg parsing, error catching and coverage by furszy)
   • #30125 (test: improve BDB parser (handle internal/overflow pages, support all page sizes) by theStack)
   • #29500 (test: create assert_not_equal util by kevkevinpal)
   • #29156 (tests: add functional test for miniscript decaying multisig by mjdietzx)
   • #29124 (wallet: Automatically repair corrupted metadata with doubled derivation path by achow101)
   • #28944 (wallet, rpc: add anti-fee-sniping to send and sendall by ishaanam)
   • #28802 (ArgsManager: support subcommand-specific options by ajtowns)
   • #27865 (wallet: Track no-longer-spendable TXOs separately by achow101)
   • #27286 (wallet: Keep track of the wallet’s own transaction outputs in memory by achow101)
   • #27052 (test: rpc: add last block announcement time to getpeerinfo result by LarryRuane)
   • #25722 (refactor: Use util::Result class for wallet loading by ryanofsky)
   • #19461 (multiprocess: Add bitcoin-gui -ipcconnect option by ryanofsky)
   • #19460 (multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky)
   • #10102 (Multiprocess bitcoin by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Wallet on Nov 7, 2024
4. achow101 force-pushed on Nov 7, 2024
5. DrahtBot added the label CI failed on Nov 7, 2024
6. DrahtBot added the label Needs rebase on Nov 12, 2024
7. test: Rework migratewallet to use previous releases 31b75f6364
8. wallet: remove BDB dependency from wallet migration benchmark

   Stops creating a bdb database in the wallet migration benchmark.
   Instead, the benchmark now creates the db in memory and re-uses
   it for the migration process.

   1222de646b
9. test: rpcs disabled for descriptor wallets were removed 94d8b96f1a
10. test: Remove legacy wallet unit tests f4f48a0c41
11. test: wallet_transactiontime_rescan importdescriptors always rescans 986e2e05dc
12. test: wallet_signer.py bdb will be removed 28f75a4025
13. test: Remove legacy wallet tests from wallet_backwards_compatibility.py 37b13e4803
14. test: Remove legacy wallet tests from wallet_reindex.py 6647d76d4b
15. test: remove legacy wallet functional tests

    Removes all legacy wallet specific functional tests.
    
    Also removes the --descriptor and --legacy-wallet options as these are
    no longer necessary with the legacy wallet removed.

    c616c6ffb6
16. wallet: Remove -format and bdb from wallet tool's createfromdump daf44d34a0
17. wallet: Remove wallettool salvage

    Salvage is bdb only which is about to be removed.

    f24deddacd
18. bench: Remove WalletLoadingLegacy benchmark 39ea96c147
19. wallet: Don't reload legacy wallet on failed migration

    We can't load legacy wallet anymore, so if migration fails, don't try to
    load the failed wallet.

    f54efd3dc4
20. build: Require sqlite when --enable-wallet

    Require sqlite is available in order to compile the wallet. Removes
    instances of USE_SQLITE since it is no longer possible to not have
    sqlite available.

    c39de5fd3b
21. wallet: Disallow legacy wallets

    Legacy wallets do not have the descriptors flag set. Don't load wallets
    without the descriptors flag.
    
    At the same time, we will no longer load BDB databases since they are
    only used for legacy wallets.

    4f0e11b508
22. achow101 force-pushed on Nov 12, 2024
23. DrahtBot removed the label CI failed on Nov 12, 2024
24. DrahtBot removed the label Needs rebase on Nov 12, 2024

Contributors
achow101 DrahtBot

Labels
Wallet