build: Enable -Wbidi-chars=any #31315

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2411-less-bidi changing 1 files +1 −0
  1. maflcko commented at 10:07 am on November 18, 2024: member

    I don’t see a use-case for UTF-8 bidirectional control characters in this codebase. So disable them for now.

    Ref: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wbidi-chars_003d

  2. build: Enable -Wbidi-chars=any fa7857ccda
  3. DrahtBot commented at 10:07 am on November 18, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31315.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Build system on Nov 18, 2024
  5. maflcko commented at 10:07 am on November 18, 2024: member
    Can be tested with the patch in https://github.com/bitcoin/bitcoin/pull/31314
  6. maflcko added the label DrahtBot Guix build requested on Nov 18, 2024
  7. DrahtBot commented at 10:18 am on November 19, 2024: contributor

    Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

    File commit ccc2d3abcd39c64a78e366f3e4794de729155e9e(master) commit 38eb54623ea2ac45521e3afcb4d2299d69a2c920(master and this pull)
    SHA256SUMS.part 90e69a2116dbf9e4... 36759a3ecd316972...
    *-aarch64-linux-gnu-debug.tar.gz fde1af48d37a7e97... da38242de4f529cc...
    *-aarch64-linux-gnu.tar.gz 1c2eac1b42cc0b62... c3ade7c60790c5fa...
    *-arm-linux-gnueabihf-debug.tar.gz 0aa342647eea4fb5... 2506f8a8284eee26...
    *-arm-linux-gnueabihf.tar.gz 76579326566230b7... 190d6ea4496bc9a8...
    *-arm64-apple-darwin-unsigned.tar.gz 58c5a98ee0ec9797... c665dd240531e77e...
    *-arm64-apple-darwin-unsigned.zip 5e19ae710c461bb9... ef2206ff316b3f98...
    *-arm64-apple-darwin.tar.gz 3b5b4f0f4e9df258... dd4c75df87fa82ee...
    *-powerpc64-linux-gnu-debug.tar.gz 03ff4e3e74211df6... d9fb643108017872...
    *-powerpc64-linux-gnu.tar.gz 3d17abb62ce153d6... 234ddf95d88a6ff8...
    *-riscv64-linux-gnu-debug.tar.gz 286828089dcfe4fa... d1e0fecd44f2a5a0...
    *-riscv64-linux-gnu.tar.gz 6e876fc93ca507da... f9b0acb51e71d4ef...
    *-x86_64-apple-darwin-unsigned.tar.gz a0acfc231f9e5df5... 4f6f861277e59124...
    *-x86_64-apple-darwin-unsigned.zip cd2275751a11c7e0... c2977620766af4df...
    *-x86_64-apple-darwin.tar.gz d5591dd5c0f3f8c6... f1721e9d33dd8951...
    *-x86_64-linux-gnu-debug.tar.gz a65bbfc43d98affc... 523337936bfbed50...
    *-x86_64-linux-gnu.tar.gz 9c265daa1cf5e8e2... 8e0e34170b0b97b5...
    *.tar.gz 0cadc668da7ea099... 6792ee66abffa01e...
    guix_build.log a1ce391ae2e3aa46... 27bfab3cfd88b974...
    guix_build.log.diff 1839cfffe620f66f...
  8. DrahtBot removed the label DrahtBot Guix build requested on Nov 19, 2024
  9. fanquake commented at 2:16 pm on November 19, 2024: member
    Concept ACK - looks like GH also tries to warn about this. hidden
  10. fanquake approved
  11. fanquake commented at 10:54 am on November 20, 2024: member

    ACK fa7857ccda5d82739bba16eeb7244433978d28f3

    0/root/ci_scratch/src/kernel/cs_main.cpp:8:33: warning: found problematic Unicode character "U+202E (RIGHT-TO-LEFT OVERRIDE)" [-Wbidi-chars=]
    1    8 | RecursiveMutex cs_main; // 1234 <U+202E> 1234 <U+202C>
    2      |                                 ^~~~~~~~
    
  12. fanquake merged this on Nov 20, 2024
  13. fanquake closed this on Nov 20, 2024

  14. maflcko deleted the branch on Nov 20, 2024
  15. hebasto commented at 12:27 pm on November 21, 2024: member
    Post-merge ACK fa7857ccda5d82739bba16eeb7244433978d28f3. This compiler option is recommended in the Compiler Options Hardening Guide for C and C++.

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me