guix: swap `moreutils` for just `sponge`

fanquake commented at 4:18 pm on November 19, 2024: member

Switch to building the only moreutils utility we actually need (sponge). This results in having less unused stuff in the Guix environment (i.e all the other moreutils utilities), and, the dependency graph is simplified. i.e we no-longer have a dependency on perl, docbook etc, for this package.

Current moreutils dependency graph:

sponge dependency graph: sponge

In the Guix env, chronic, combine, errno, ifdata, ifne, isutf8, lckdo, mispipe, parallel, pee, ts, vidir, vipe & zrun (plus their *.real variants) are removed.

Guix build:

 074a02707614d7fc7ed460148b37e90c126d09c2e9b2962765de14d267a3f22d3  guix-build-c4ee9b8aa078/output/aarch64-linux-gnu/SHA256SUMS.part
 1263f079da730485eb583995c1fc6304b7ca957a668fd5aac8f879bc59746dc67  guix-build-c4ee9b8aa078/output/aarch64-linux-gnu/bitcoin-c4ee9b8aa078-aarch64-linux-gnu-debug.tar.gz
 2745a9bfdd9550cf9abf80415c4efe818446ea05e9c4f659f643669c3dcb49893  guix-build-c4ee9b8aa078/output/aarch64-linux-gnu/bitcoin-c4ee9b8aa078-aarch64-linux-gnu.tar.gz
 35810b1efc04172fec17bab60082fec045c4a23c93050baeb391ac2f2a73c6e63  guix-build-c4ee9b8aa078/output/arm-linux-gnueabihf/SHA256SUMS.part
 4501eab289ad3e2eec030425ee3fbede73c7ec3f23b42377e330fec8af32c1de6  guix-build-c4ee9b8aa078/output/arm-linux-gnueabihf/bitcoin-c4ee9b8aa078-arm-linux-gnueabihf-debug.tar.gz
 5827edd55ebf01fe26f6ae2caa2cefac048f2a697bfdd22728f64fb61ab30d660  guix-build-c4ee9b8aa078/output/arm-linux-gnueabihf/bitcoin-c4ee9b8aa078-arm-linux-gnueabihf.tar.gz
 65eb22cc353375cc8e37f0e7dfd897029d0ae227730ecd0c0b8cc23434e609026  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/SHA256SUMS.part
 7d16b7d032ce11110e68306d303e6c712bafbdabb86541d29c5a3c88f62c8600d  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/bitcoin-c4ee9b8aa078-arm64-apple-darwin-unsigned.tar.gz
 826faf4775d2ff65260c6ebd7ccd76d6fd69633d3658b7a3d6c2aa3f07a975204  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/bitcoin-c4ee9b8aa078-arm64-apple-darwin-unsigned.zip
 938767a02f670f1e3ddc60be7f442e9b555dcdf3e6e1df101b9e607b958b48e9c  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/bitcoin-c4ee9b8aa078-arm64-apple-darwin.tar.gz
105ee0ba02fafd22a488ad14ca6c54485e9756724de9076122e02a460a9dc966d8  guix-build-c4ee9b8aa078/output/dist-archive/bitcoin-c4ee9b8aa078.tar.gz
1180e1da69b4a56313660c69b987c4c0d8a66f8635e8f3c2a007f15cfeeae87c73  guix-build-c4ee9b8aa078/output/powerpc64-linux-gnu/SHA256SUMS.part
12eb731a4f1bdd32b7801cdda3de20db6fb534c42249cd4b2207f8919780223e48  guix-build-c4ee9b8aa078/output/powerpc64-linux-gnu/bitcoin-c4ee9b8aa078-powerpc64-linux-gnu-debug.tar.gz
130378720813c837f4ca5ba345630b9b5447a1b00c1634985024e6898ac551f875  guix-build-c4ee9b8aa078/output/powerpc64-linux-gnu/bitcoin-c4ee9b8aa078-powerpc64-linux-gnu.tar.gz
14f97e69bd741f2a7c38a3022acd84dd331f5be11230eb502bcbb936d84ac85ca9  guix-build-c4ee9b8aa078/output/riscv64-linux-gnu/SHA256SUMS.part
1507a7d1edafb77d43644530040ccb22865d059ffd0dd1cbe3bcba08a9cab5f6c0  guix-build-c4ee9b8aa078/output/riscv64-linux-gnu/bitcoin-c4ee9b8aa078-riscv64-linux-gnu-debug.tar.gz
16876191186998d63e549bb6679c848ecbe0d7296092198e85d31983035734f3d0  guix-build-c4ee9b8aa078/output/riscv64-linux-gnu/bitcoin-c4ee9b8aa078-riscv64-linux-gnu.tar.gz
17213e98d14ff34079376a06188c7e2e328cfdf2a8a1145b284b804ed97e03c235  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/SHA256SUMS.part
1846cb71117952c371ff152cd686554522b55ca8f17336e7dd64bb9fc223fdf4ae  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/bitcoin-c4ee9b8aa078-x86_64-apple-darwin-unsigned.tar.gz
19d2d029ce8886fdd1701e5acb7ffd54c94fba9f77337517e2bc87f306a4483e89  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/bitcoin-c4ee9b8aa078-x86_64-apple-darwin-unsigned.zip
202592b4df5270b01baa7ef929d7b98d2512262fcac2a5d773bb1befb36c05b347  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/bitcoin-c4ee9b8aa078-x86_64-apple-darwin.tar.gz
212a441abe210364b95e440ac374031313793ee95286c251079a653035c8f78654  guix-build-c4ee9b8aa078/output/x86_64-linux-gnu/SHA256SUMS.part
2269a8acf7797cfb0ae3fa73c82193454a8a71827f8aaa530d1a4dfaef8223bfbe  guix-build-c4ee9b8aa078/output/x86_64-linux-gnu/bitcoin-c4ee9b8aa078-x86_64-linux-gnu-debug.tar.gz
23293a245727edf76296f24fbbb853422ce18b924690db586edc45660e3d4eae8a  guix-build-c4ee9b8aa078/output/x86_64-linux-gnu/bitcoin-c4ee9b8aa078-x86_64-linux-gnu.tar.gz
244a8dcedcedb26d19e5d556c4f38ba51cb45be24fd15efbb2808355723506ea97  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/SHA256SUMS.part
25ea784b1d8a350a538ddf9258c9f4ba764ac088232919e8ddd8a2fa5a1740e746  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64-debug.zip
261d00d2b90fe47f52a6ced4daca8e6e37f16c8215540150214dbefbdbf375ef5a  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64-setup-unsigned.exe
27cb6e1533402ddf487cc71481926768a773868701d66f0f5655806b7f6160a50e  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64-unsigned.tar.gz
282313eafb2af4d2f9292cbe2537a8611a98f98d07c98706005f7c6aa759279ac7  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64.zip

DrahtBot commented at 4:19 pm on November 19, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31323.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	hebasto, TheCharlatan, kevkevinpal

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Build system on Nov 19, 2024

hebasto commented at 4:24 pm on November 19, 2024: member

Concept ACK.

TheCharlatan commented at 4:33 pm on November 19, 2024: contributor

Nice, Concept ACK

Sjors commented at 5:45 pm on November 19, 2024: member

On my x86_64 machine I get the same guix hashes as @fanquake.

guix: swap moreutils for just sponge

We build the only moreutils utility we actually need (sponge), have less
unused stuff in the Guix environment, and, the dependency graph is
simplified. i.e we no-longer have a dependency on perl, docbook etc, for
this package.

c4ee9b8aa0

fanquake force-pushed on Nov 20, 2024

TheCharlatan commented at 9:25 pm on November 20, 2024: contributor

Checked the patch against the original moreutils package, and reproduced the stripped-down package. I think grabbing the specific tools we need from these kind of packages is a good thing.

Guix builds (aarch64):

 074a02707614d7fc7ed460148b37e90c126d09c2e9b2962765de14d267a3f22d3  guix-build-c4ee9b8aa078/output/aarch64-linux-gnu/SHA256SUMS.part
 1263f079da730485eb583995c1fc6304b7ca957a668fd5aac8f879bc59746dc67  guix-build-c4ee9b8aa078/output/aarch64-linux-gnu/bitcoin-c4ee9b8aa078-aarch64-linux-gnu-debug.tar.gz
 2745a9bfdd9550cf9abf80415c4efe818446ea05e9c4f659f643669c3dcb49893  guix-build-c4ee9b8aa078/output/aarch64-linux-gnu/bitcoin-c4ee9b8aa078-aarch64-linux-gnu.tar.gz
 35810b1efc04172fec17bab60082fec045c4a23c93050baeb391ac2f2a73c6e63  guix-build-c4ee9b8aa078/output/arm-linux-gnueabihf/SHA256SUMS.part
 4501eab289ad3e2eec030425ee3fbede73c7ec3f23b42377e330fec8af32c1de6  guix-build-c4ee9b8aa078/output/arm-linux-gnueabihf/bitcoin-c4ee9b8aa078-arm-linux-gnueabihf-debug.tar.gz
 5827edd55ebf01fe26f6ae2caa2cefac048f2a697bfdd22728f64fb61ab30d660  guix-build-c4ee9b8aa078/output/arm-linux-gnueabihf/bitcoin-c4ee9b8aa078-arm-linux-gnueabihf.tar.gz
 65eb22cc353375cc8e37f0e7dfd897029d0ae227730ecd0c0b8cc23434e609026  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/SHA256SUMS.part
 7d16b7d032ce11110e68306d303e6c712bafbdabb86541d29c5a3c88f62c8600d  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/bitcoin-c4ee9b8aa078-arm64-apple-darwin-unsigned.tar.gz
 826faf4775d2ff65260c6ebd7ccd76d6fd69633d3658b7a3d6c2aa3f07a975204  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/bitcoin-c4ee9b8aa078-arm64-apple-darwin-unsigned.zip
 938767a02f670f1e3ddc60be7f442e9b555dcdf3e6e1df101b9e607b958b48e9c  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/bitcoin-c4ee9b8aa078-arm64-apple-darwin.tar.gz
105ee0ba02fafd22a488ad14ca6c54485e9756724de9076122e02a460a9dc966d8  guix-build-c4ee9b8aa078/output/dist-archive/bitcoin-c4ee9b8aa078.tar.gz
1180e1da69b4a56313660c69b987c4c0d8a66f8635e8f3c2a007f15cfeeae87c73  guix-build-c4ee9b8aa078/output/powerpc64-linux-gnu/SHA256SUMS.part
12eb731a4f1bdd32b7801cdda3de20db6fb534c42249cd4b2207f8919780223e48  guix-build-c4ee9b8aa078/output/powerpc64-linux-gnu/bitcoin-c4ee9b8aa078-powerpc64-linux-gnu-debug.tar.gz
130378720813c837f4ca5ba345630b9b5447a1b00c1634985024e6898ac551f875  guix-build-c4ee9b8aa078/output/powerpc64-linux-gnu/bitcoin-c4ee9b8aa078-powerpc64-linux-gnu.tar.gz
14f97e69bd741f2a7c38a3022acd84dd331f5be11230eb502bcbb936d84ac85ca9  guix-build-c4ee9b8aa078/output/riscv64-linux-gnu/SHA256SUMS.part
1507a7d1edafb77d43644530040ccb22865d059ffd0dd1cbe3bcba08a9cab5f6c0  guix-build-c4ee9b8aa078/output/riscv64-linux-gnu/bitcoin-c4ee9b8aa078-riscv64-linux-gnu-debug.tar.gz
16876191186998d63e549bb6679c848ecbe0d7296092198e85d31983035734f3d0  guix-build-c4ee9b8aa078/output/riscv64-linux-gnu/bitcoin-c4ee9b8aa078-riscv64-linux-gnu.tar.gz
17213e98d14ff34079376a06188c7e2e328cfdf2a8a1145b284b804ed97e03c235  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/SHA256SUMS.part
1846cb71117952c371ff152cd686554522b55ca8f17336e7dd64bb9fc223fdf4ae  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/bitcoin-c4ee9b8aa078-x86_64-apple-darwin-unsigned.tar.gz
19d2d029ce8886fdd1701e5acb7ffd54c94fba9f77337517e2bc87f306a4483e89  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/bitcoin-c4ee9b8aa078-x86_64-apple-darwin-unsigned.zip
202592b4df5270b01baa7ef929d7b98d2512262fcac2a5d773bb1befb36c05b347  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/bitcoin-c4ee9b8aa078-x86_64-apple-darwin.tar.gz
212a441abe210364b95e440ac374031313793ee95286c251079a653035c8f78654  guix-build-c4ee9b8aa078/output/x86_64-linux-gnu/SHA256SUMS.part
2269a8acf7797cfb0ae3fa73c82193454a8a71827f8aaa530d1a4dfaef8223bfbe  guix-build-c4ee9b8aa078/output/x86_64-linux-gnu/bitcoin-c4ee9b8aa078-x86_64-linux-gnu-debug.tar.gz
23293a245727edf76296f24fbbb853422ce18b924690db586edc45660e3d4eae8a  guix-build-c4ee9b8aa078/output/x86_64-linux-gnu/bitcoin-c4ee9b8aa078-x86_64-linux-gnu.tar.gz
244a8dcedcedb26d19e5d556c4f38ba51cb45be24fd15efbb2808355723506ea97  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/SHA256SUMS.part
25ea784b1d8a350a538ddf9258c9f4ba764ac088232919e8ddd8a2fa5a1740e746  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64-debug.zip
261d00d2b90fe47f52a6ced4daca8e6e37f16c8215540150214dbefbdbf375ef5a  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64-setup-unsigned.exe
27cb6e1533402ddf487cc71481926768a773868701d66f0f5655806b7f6160a50e  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64-unsigned.tar.gz
282313eafb2af4d2f9292cbe2537a8611a98f98d07c98706005f7c6aa759279ac7  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64.zip

kevkevinpal commented at 2:13 am on November 21, 2024: contributor

Concept ACK

guix: swap moreutils for just sponge #31323

Code Coverage & Benchmarks

Reviews

guix: swap `moreutils` for just `sponge` #31323