guix: swap moreutils for just sponge #31323

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:moreutils_just_sponge changing 1 files +33 −3
  1. fanquake commented at 4:18 pm on November 19, 2024: member

    Switch to building the only moreutils utility we actually need (sponge). This results in having less unused stuff in the Guix environment (i.e all the other moreutils utilities), and, the dependency graph is simplified. i.e we no-longer have a dependency on perl, docbook etc, for this package.

    Current moreutils dependency graph: moreutils

    In the Guix env, chronic, combine, errno, ifdata, ifne, isutf8, lckdo, mispipe, parallel, pee, ts, vidir, vipe & zrun (plus their *.real variants) are removed.

  2. DrahtBot commented at 4:19 pm on November 19, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31323.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, TheCharlatan
    Concept ACK kevkevinpal

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Build system on Nov 19, 2024
  4. hebasto commented at 4:24 pm on November 19, 2024: member
    Concept ACK.
  5. TheCharlatan commented at 4:33 pm on November 19, 2024: contributor
    Nice, Concept ACK
  6. Sjors commented at 5:45 pm on November 19, 2024: member
    On my x86_64 machine I get the same guix hashes as @fanquake.
  7. fanquake force-pushed on Nov 20, 2024
  8. TheCharlatan commented at 9:25 pm on November 20, 2024: contributor

    Checked the patch against the original moreutils package, and reproduced the stripped-down package. I think grabbing the specific tools we need from these kind of packages is a good thing.

    Guix builds (aarch64):

     074a02707614d7fc7ed460148b37e90c126d09c2e9b2962765de14d267a3f22d3  guix-build-c4ee9b8aa078/output/aarch64-linux-gnu/SHA256SUMS.part
     1263f079da730485eb583995c1fc6304b7ca957a668fd5aac8f879bc59746dc67  guix-build-c4ee9b8aa078/output/aarch64-linux-gnu/bitcoin-c4ee9b8aa078-aarch64-linux-gnu-debug.tar.gz
     2745a9bfdd9550cf9abf80415c4efe818446ea05e9c4f659f643669c3dcb49893  guix-build-c4ee9b8aa078/output/aarch64-linux-gnu/bitcoin-c4ee9b8aa078-aarch64-linux-gnu.tar.gz
     35810b1efc04172fec17bab60082fec045c4a23c93050baeb391ac2f2a73c6e63  guix-build-c4ee9b8aa078/output/arm-linux-gnueabihf/SHA256SUMS.part
     4501eab289ad3e2eec030425ee3fbede73c7ec3f23b42377e330fec8af32c1de6  guix-build-c4ee9b8aa078/output/arm-linux-gnueabihf/bitcoin-c4ee9b8aa078-arm-linux-gnueabihf-debug.tar.gz
     5827edd55ebf01fe26f6ae2caa2cefac048f2a697bfdd22728f64fb61ab30d660  guix-build-c4ee9b8aa078/output/arm-linux-gnueabihf/bitcoin-c4ee9b8aa078-arm-linux-gnueabihf.tar.gz
     65eb22cc353375cc8e37f0e7dfd897029d0ae227730ecd0c0b8cc23434e609026  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/SHA256SUMS.part
     7d16b7d032ce11110e68306d303e6c712bafbdabb86541d29c5a3c88f62c8600d  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/bitcoin-c4ee9b8aa078-arm64-apple-darwin-unsigned.tar.gz
     826faf4775d2ff65260c6ebd7ccd76d6fd69633d3658b7a3d6c2aa3f07a975204  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/bitcoin-c4ee9b8aa078-arm64-apple-darwin-unsigned.zip
     938767a02f670f1e3ddc60be7f442e9b555dcdf3e6e1df101b9e607b958b48e9c  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/bitcoin-c4ee9b8aa078-arm64-apple-darwin.tar.gz
    105ee0ba02fafd22a488ad14ca6c54485e9756724de9076122e02a460a9dc966d8  guix-build-c4ee9b8aa078/output/dist-archive/bitcoin-c4ee9b8aa078.tar.gz
    1180e1da69b4a56313660c69b987c4c0d8a66f8635e8f3c2a007f15cfeeae87c73  guix-build-c4ee9b8aa078/output/powerpc64-linux-gnu/SHA256SUMS.part
    12eb731a4f1bdd32b7801cdda3de20db6fb534c42249cd4b2207f8919780223e48  guix-build-c4ee9b8aa078/output/powerpc64-linux-gnu/bitcoin-c4ee9b8aa078-powerpc64-linux-gnu-debug.tar.gz
    130378720813c837f4ca5ba345630b9b5447a1b00c1634985024e6898ac551f875  guix-build-c4ee9b8aa078/output/powerpc64-linux-gnu/bitcoin-c4ee9b8aa078-powerpc64-linux-gnu.tar.gz
    14f97e69bd741f2a7c38a3022acd84dd331f5be11230eb502bcbb936d84ac85ca9  guix-build-c4ee9b8aa078/output/riscv64-linux-gnu/SHA256SUMS.part
    1507a7d1edafb77d43644530040ccb22865d059ffd0dd1cbe3bcba08a9cab5f6c0  guix-build-c4ee9b8aa078/output/riscv64-linux-gnu/bitcoin-c4ee9b8aa078-riscv64-linux-gnu-debug.tar.gz
    16876191186998d63e549bb6679c848ecbe0d7296092198e85d31983035734f3d0  guix-build-c4ee9b8aa078/output/riscv64-linux-gnu/bitcoin-c4ee9b8aa078-riscv64-linux-gnu.tar.gz
    17213e98d14ff34079376a06188c7e2e328cfdf2a8a1145b284b804ed97e03c235  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/SHA256SUMS.part
    1846cb71117952c371ff152cd686554522b55ca8f17336e7dd64bb9fc223fdf4ae  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/bitcoin-c4ee9b8aa078-x86_64-apple-darwin-unsigned.tar.gz
    19d2d029ce8886fdd1701e5acb7ffd54c94fba9f77337517e2bc87f306a4483e89  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/bitcoin-c4ee9b8aa078-x86_64-apple-darwin-unsigned.zip
    202592b4df5270b01baa7ef929d7b98d2512262fcac2a5d773bb1befb36c05b347  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/bitcoin-c4ee9b8aa078-x86_64-apple-darwin.tar.gz
    212a441abe210364b95e440ac374031313793ee95286c251079a653035c8f78654  guix-build-c4ee9b8aa078/output/x86_64-linux-gnu/SHA256SUMS.part
    2269a8acf7797cfb0ae3fa73c82193454a8a71827f8aaa530d1a4dfaef8223bfbe  guix-build-c4ee9b8aa078/output/x86_64-linux-gnu/bitcoin-c4ee9b8aa078-x86_64-linux-gnu-debug.tar.gz
    23293a245727edf76296f24fbbb853422ce18b924690db586edc45660e3d4eae8a  guix-build-c4ee9b8aa078/output/x86_64-linux-gnu/bitcoin-c4ee9b8aa078-x86_64-linux-gnu.tar.gz
    244a8dcedcedb26d19e5d556c4f38ba51cb45be24fd15efbb2808355723506ea97  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/SHA256SUMS.part
    25ea784b1d8a350a538ddf9258c9f4ba764ac088232919e8ddd8a2fa5a1740e746  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64-debug.zip
    261d00d2b90fe47f52a6ced4daca8e6e37f16c8215540150214dbefbdbf375ef5a  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64-setup-unsigned.exe
    27cb6e1533402ddf487cc71481926768a773868701d66f0f5655806b7f6160a50e  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64-unsigned.tar.gz
    282313eafb2af4d2f9292cbe2537a8611a98f98d07c98706005f7c6aa759279ac7  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64.zip
    
  9. kevkevinpal commented at 2:13 am on November 21, 2024: contributor
    Concept ACK
  10. hebasto commented at 9:50 pm on November 21, 2024: member

    My Guix build:

     0riscv64
     174a02707614d7fc7ed460148b37e90c126d09c2e9b2962765de14d267a3f22d3  guix-build-c4ee9b8aa078/output/aarch64-linux-gnu/SHA256SUMS.part
     2263f079da730485eb583995c1fc6304b7ca957a668fd5aac8f879bc59746dc67  guix-build-c4ee9b8aa078/output/aarch64-linux-gnu/bitcoin-c4ee9b8aa078-aarch64-linux-gnu-debug.tar.gz
     3745a9bfdd9550cf9abf80415c4efe818446ea05e9c4f659f643669c3dcb49893  guix-build-c4ee9b8aa078/output/aarch64-linux-gnu/bitcoin-c4ee9b8aa078-aarch64-linux-gnu.tar.gz
     45810b1efc04172fec17bab60082fec045c4a23c93050baeb391ac2f2a73c6e63  guix-build-c4ee9b8aa078/output/arm-linux-gnueabihf/SHA256SUMS.part
     5501eab289ad3e2eec030425ee3fbede73c7ec3f23b42377e330fec8af32c1de6  guix-build-c4ee9b8aa078/output/arm-linux-gnueabihf/bitcoin-c4ee9b8aa078-arm-linux-gnueabihf-debug.tar.gz
     6827edd55ebf01fe26f6ae2caa2cefac048f2a697bfdd22728f64fb61ab30d660  guix-build-c4ee9b8aa078/output/arm-linux-gnueabihf/bitcoin-c4ee9b8aa078-arm-linux-gnueabihf.tar.gz
     75eb22cc353375cc8e37f0e7dfd897029d0ae227730ecd0c0b8cc23434e609026  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/SHA256SUMS.part
     8d16b7d032ce11110e68306d303e6c712bafbdabb86541d29c5a3c88f62c8600d  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/bitcoin-c4ee9b8aa078-arm64-apple-darwin-unsigned.tar.gz
     926faf4775d2ff65260c6ebd7ccd76d6fd69633d3658b7a3d6c2aa3f07a975204  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/bitcoin-c4ee9b8aa078-arm64-apple-darwin-unsigned.zip
    1038767a02f670f1e3ddc60be7f442e9b555dcdf3e6e1df101b9e607b958b48e9c  guix-build-c4ee9b8aa078/output/arm64-apple-darwin/bitcoin-c4ee9b8aa078-arm64-apple-darwin.tar.gz
    115ee0ba02fafd22a488ad14ca6c54485e9756724de9076122e02a460a9dc966d8  guix-build-c4ee9b8aa078/output/dist-archive/bitcoin-c4ee9b8aa078.tar.gz
    1280e1da69b4a56313660c69b987c4c0d8a66f8635e8f3c2a007f15cfeeae87c73  guix-build-c4ee9b8aa078/output/powerpc64-linux-gnu/SHA256SUMS.part
    13eb731a4f1bdd32b7801cdda3de20db6fb534c42249cd4b2207f8919780223e48  guix-build-c4ee9b8aa078/output/powerpc64-linux-gnu/bitcoin-c4ee9b8aa078-powerpc64-linux-gnu-debug.tar.gz
    140378720813c837f4ca5ba345630b9b5447a1b00c1634985024e6898ac551f875  guix-build-c4ee9b8aa078/output/powerpc64-linux-gnu/bitcoin-c4ee9b8aa078-powerpc64-linux-gnu.tar.gz
    15f97e69bd741f2a7c38a3022acd84dd331f5be11230eb502bcbb936d84ac85ca9  guix-build-c4ee9b8aa078/output/riscv64-linux-gnu/SHA256SUMS.part
    1607a7d1edafb77d43644530040ccb22865d059ffd0dd1cbe3bcba08a9cab5f6c0  guix-build-c4ee9b8aa078/output/riscv64-linux-gnu/bitcoin-c4ee9b8aa078-riscv64-linux-gnu-debug.tar.gz
    17876191186998d63e549bb6679c848ecbe0d7296092198e85d31983035734f3d0  guix-build-c4ee9b8aa078/output/riscv64-linux-gnu/bitcoin-c4ee9b8aa078-riscv64-linux-gnu.tar.gz
    18213e98d14ff34079376a06188c7e2e328cfdf2a8a1145b284b804ed97e03c235  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/SHA256SUMS.part
    1946cb71117952c371ff152cd686554522b55ca8f17336e7dd64bb9fc223fdf4ae  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/bitcoin-c4ee9b8aa078-x86_64-apple-darwin-unsigned.tar.gz
    20d2d029ce8886fdd1701e5acb7ffd54c94fba9f77337517e2bc87f306a4483e89  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/bitcoin-c4ee9b8aa078-x86_64-apple-darwin-unsigned.zip
    212592b4df5270b01baa7ef929d7b98d2512262fcac2a5d773bb1befb36c05b347  guix-build-c4ee9b8aa078/output/x86_64-apple-darwin/bitcoin-c4ee9b8aa078-x86_64-apple-darwin.tar.gz
    222a441abe210364b95e440ac374031313793ee95286c251079a653035c8f78654  guix-build-c4ee9b8aa078/output/x86_64-linux-gnu/SHA256SUMS.part
    2369a8acf7797cfb0ae3fa73c82193454a8a71827f8aaa530d1a4dfaef8223bfbe  guix-build-c4ee9b8aa078/output/x86_64-linux-gnu/bitcoin-c4ee9b8aa078-x86_64-linux-gnu-debug.tar.gz
    24293a245727edf76296f24fbbb853422ce18b924690db586edc45660e3d4eae8a  guix-build-c4ee9b8aa078/output/x86_64-linux-gnu/bitcoin-c4ee9b8aa078-x86_64-linux-gnu.tar.gz
    254a8dcedcedb26d19e5d556c4f38ba51cb45be24fd15efbb2808355723506ea97  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/SHA256SUMS.part
    26ea784b1d8a350a538ddf9258c9f4ba764ac088232919e8ddd8a2fa5a1740e746  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64-debug.zip
    271d00d2b90fe47f52a6ced4daca8e6e37f16c8215540150214dbefbdbf375ef5a  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64-setup-unsigned.exe
    28cb6e1533402ddf487cc71481926768a773868701d66f0f5655806b7f6160a50e  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64-unsigned.tar.gz
    292313eafb2af4d2f9292cbe2537a8611a98f98d07c98706005f7c6aa759279ac7  guix-build-c4ee9b8aa078/output/x86_64-w64-mingw32/bitcoin-c4ee9b8aa078-win64.zip
    
  11. TheCharlatan approved
  12. TheCharlatan commented at 9:49 am on November 22, 2024: contributor
    ACK c4ee9b8aa07824610e1de9c70a4b938844c5ff53
  13. DrahtBot requested review from hebasto on Nov 22, 2024
  14. in contrib/guix/manifest.scm:516 in c4ee9b8aa0 outdated
    511+                  (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
    512+                  (install-file "sponge" bin)))))
    513+           #:make-flags
    514+           #~(list "sponge" (string-append "CC=" #$(cc-for-target)))))
    515+    (inputs
    516+     (list bash-minimal))
    


    hebasto commented at 9:55 am on November 22, 2024:
    Why are these lines needed?

    fanquake commented at 11:22 am on November 22, 2024:
    Bash is implied/available, so we are able to drop this.
  15. DrahtBot requested review from hebasto on Nov 22, 2024
  16. guix: swap moreutils for just sponge
    We build the only moreutils utility we actually need (sponge), have less
    unused stuff in the Guix environment, and, the dependency graph is
    simplified. i.e we no-longer have a dependency on perl, docbook etc, for
    this package.
    e8f50c5deb
  17. fanquake force-pushed on Nov 22, 2024
  18. hebasto approved
  19. hebasto commented at 1:18 pm on November 22, 2024: member

    ACK e8f50c5debe2b866e59872dbbf22db0fd592ec04.

    My Guix build:

     0aarch64
     1c3d79b98874ba44dbe6550fd18cdd78443ee1b4d0594dc1cc2e6b423dcded117  guix-build-e8f50c5debe2/output/aarch64-linux-gnu/SHA256SUMS.part
     2159a09c6ed25d498a48f3e3d53dd4c77b61c2ecbd824661593316030678ee5b0  guix-build-e8f50c5debe2/output/aarch64-linux-gnu/bitcoin-e8f50c5debe2-aarch64-linux-gnu-debug.tar.gz
     334cd42b0a3574085c173073bbb12cbb19db2169efadab752335071eb897c242e  guix-build-e8f50c5debe2/output/aarch64-linux-gnu/bitcoin-e8f50c5debe2-aarch64-linux-gnu.tar.gz
     40a62bc6b870d6dc36a4926ebcd546f001363ed3f5453ce80e20d929313e1a1ee  guix-build-e8f50c5debe2/output/arm-linux-gnueabihf/SHA256SUMS.part
     5374b3aeb02c3d9b0324ecce254ccdaf172e9711bf2ca5a821178cb57440f076c  guix-build-e8f50c5debe2/output/arm-linux-gnueabihf/bitcoin-e8f50c5debe2-arm-linux-gnueabihf-debug.tar.gz
     6dd088f2a79b31041f895ce3791ebaf4a9b6d79cefea79ec99dfbe1fee3adae87  guix-build-e8f50c5debe2/output/arm-linux-gnueabihf/bitcoin-e8f50c5debe2-arm-linux-gnueabihf.tar.gz
     7735bc9fd04d401527adc298d89b42a46c3d3a5dd80dea9a14ae00eefc6c1c5db  guix-build-e8f50c5debe2/output/arm64-apple-darwin/SHA256SUMS.part
     84a478126accb0817e02c1009d0fa92dc2539fbd84b75fbc30d2eb97ae82c66a8  guix-build-e8f50c5debe2/output/arm64-apple-darwin/bitcoin-e8f50c5debe2-arm64-apple-darwin-unsigned.tar.gz
     9783ef9e80244cc9052c54bc4ece78d736f3109dc24f5fcef46c6b55a995398f4  guix-build-e8f50c5debe2/output/arm64-apple-darwin/bitcoin-e8f50c5debe2-arm64-apple-darwin-unsigned.zip
    10de8323486f3186ef8dae7b5f204b2bb785ac93970f50c23662220d43aae1fe6c  guix-build-e8f50c5debe2/output/arm64-apple-darwin/bitcoin-e8f50c5debe2-arm64-apple-darwin.tar.gz
    1193865368c5b9e6f88d273b64c85849c891444c598dcab872ee6ca37a4b6c814b  guix-build-e8f50c5debe2/output/dist-archive/bitcoin-e8f50c5debe2.tar.gz
    12d26be9fd3bef2b03459ac4de7fbe8c97b2bc8046313f53ff03add7d697c28403  guix-build-e8f50c5debe2/output/powerpc64-linux-gnu/SHA256SUMS.part
    13dfc44ce17b066576e337461d9843ca4b4a029b57add079a847a24a2a9e40321c  guix-build-e8f50c5debe2/output/powerpc64-linux-gnu/bitcoin-e8f50c5debe2-powerpc64-linux-gnu-debug.tar.gz
    143a9fe2ca2b1f86855d9bd47414ae3ccd6652472b0e4510a73d5f24e2cb5d7a8d  guix-build-e8f50c5debe2/output/powerpc64-linux-gnu/bitcoin-e8f50c5debe2-powerpc64-linux-gnu.tar.gz
    154d1a139f7e22fe3333c96b355fb5bb599cea0b0c7e83619fd2505a45f73c8e6e  guix-build-e8f50c5debe2/output/riscv64-linux-gnu/SHA256SUMS.part
    1615b148748fae1403ab79a00d9320b70f3c2275c492cc7761df41ee8d8be6a59a  guix-build-e8f50c5debe2/output/riscv64-linux-gnu/bitcoin-e8f50c5debe2-riscv64-linux-gnu-debug.tar.gz
    17f90f17f276d5cdd866aa07b5f853c1d110eb37df5b561b69d861b78678672719  guix-build-e8f50c5debe2/output/riscv64-linux-gnu/bitcoin-e8f50c5debe2-riscv64-linux-gnu.tar.gz
    18f8dfe9e92b52167c0bd21f57fd63b28882c9bf9673b038c38f39730eec0ad0a7  guix-build-e8f50c5debe2/output/x86_64-apple-darwin/SHA256SUMS.part
    197acc601c6d3b02ca757d10b2cd992cba6fa5c432cbd1c78f1f11bb11135c69ad  guix-build-e8f50c5debe2/output/x86_64-apple-darwin/bitcoin-e8f50c5debe2-x86_64-apple-darwin-unsigned.tar.gz
    20ecc294be346a9755a51354a4cd0aeb33651506f306069a3966d67e7b45f44daa  guix-build-e8f50c5debe2/output/x86_64-apple-darwin/bitcoin-e8f50c5debe2-x86_64-apple-darwin-unsigned.zip
    21c21ce456ec028304799c1cab06ac1dfc4c53d3add3f1f7dc4d5d42582a4bde95  guix-build-e8f50c5debe2/output/x86_64-apple-darwin/bitcoin-e8f50c5debe2-x86_64-apple-darwin.tar.gz
    22b61b2ba603ec2830e351bd6631876e6f3098d022befa1a7564f4fb64f3fdf22b  guix-build-e8f50c5debe2/output/x86_64-linux-gnu/SHA256SUMS.part
    235277cec1cdabacccd2dfae3607a71509074a58482861186fd71f11b7636380f7  guix-build-e8f50c5debe2/output/x86_64-linux-gnu/bitcoin-e8f50c5debe2-x86_64-linux-gnu-debug.tar.gz
    24c1b300217698837c4503e266c12dc10399f21774d919de5f875fe6f090da453f  guix-build-e8f50c5debe2/output/x86_64-linux-gnu/bitcoin-e8f50c5debe2-x86_64-linux-gnu.tar.gz
    25c49124e733de8587b95cbfc07076111e306de008c3f0390eb90a03076db23eaa  guix-build-e8f50c5debe2/output/x86_64-w64-mingw32/SHA256SUMS.part
    26a0d8a61b6a42beea561eb799825a2af43a1d07b9638c114887b90945e7a1fefc  guix-build-e8f50c5debe2/output/x86_64-w64-mingw32/bitcoin-e8f50c5debe2-win64-debug.zip
    274a9915cf08aeb23775b5a7b9142b85cdce28686a97e05882f98777c4106b0e19  guix-build-e8f50c5debe2/output/x86_64-w64-mingw32/bitcoin-e8f50c5debe2-win64-setup-unsigned.exe
    283d2ed27bf47823b48ba55a0839f8a064bf5dc9e59b2af25299de43663126394e  guix-build-e8f50c5debe2/output/x86_64-w64-mingw32/bitcoin-e8f50c5debe2-win64-unsigned.tar.gz
    295c116eec993f8ce82cd0ca4e698570ac7d25542c4d17992562c736052ec72fde  guix-build-e8f50c5debe2/output/x86_64-w64-mingw32/bitcoin-e8f50c5debe2-win64.zip
    
  20. DrahtBot requested review from TheCharlatan on Nov 22, 2024
  21. TheCharlatan approved
  22. TheCharlatan commented at 1:27 pm on November 22, 2024: contributor

    Re-ACK e8f50c5debe2

    Guix build (aarch64):

     0c3d79b98874ba44dbe6550fd18cdd78443ee1b4d0594dc1cc2e6b423dcded117  guix-build-e8f50c5debe2/output/aarch64-linux-gnu/SHA256SUMS.part
     1159a09c6ed25d498a48f3e3d53dd4c77b61c2ecbd824661593316030678ee5b0  guix-build-e8f50c5debe2/output/aarch64-linux-gnu/bitcoin-e8f50c5debe2-aarch64-linux-gnu-debug.tar.gz
     234cd42b0a3574085c173073bbb12cbb19db2169efadab752335071eb897c242e  guix-build-e8f50c5debe2/output/aarch64-linux-gnu/bitcoin-e8f50c5debe2-aarch64-linux-gnu.tar.gz
     30a62bc6b870d6dc36a4926ebcd546f001363ed3f5453ce80e20d929313e1a1ee  guix-build-e8f50c5debe2/output/arm-linux-gnueabihf/SHA256SUMS.part
     4374b3aeb02c3d9b0324ecce254ccdaf172e9711bf2ca5a821178cb57440f076c  guix-build-e8f50c5debe2/output/arm-linux-gnueabihf/bitcoin-e8f50c5debe2-arm-linux-gnueabihf-debug.tar.gz
     5dd088f2a79b31041f895ce3791ebaf4a9b6d79cefea79ec99dfbe1fee3adae87  guix-build-e8f50c5debe2/output/arm-linux-gnueabihf/bitcoin-e8f50c5debe2-arm-linux-gnueabihf.tar.gz
     6735bc9fd04d401527adc298d89b42a46c3d3a5dd80dea9a14ae00eefc6c1c5db  guix-build-e8f50c5debe2/output/arm64-apple-darwin/SHA256SUMS.part
     74a478126accb0817e02c1009d0fa92dc2539fbd84b75fbc30d2eb97ae82c66a8  guix-build-e8f50c5debe2/output/arm64-apple-darwin/bitcoin-e8f50c5debe2-arm64-apple-darwin-unsigned.tar.gz
     8783ef9e80244cc9052c54bc4ece78d736f3109dc24f5fcef46c6b55a995398f4  guix-build-e8f50c5debe2/output/arm64-apple-darwin/bitcoin-e8f50c5debe2-arm64-apple-darwin-unsigned.zip
     9de8323486f3186ef8dae7b5f204b2bb785ac93970f50c23662220d43aae1fe6c  guix-build-e8f50c5debe2/output/arm64-apple-darwin/bitcoin-e8f50c5debe2-arm64-apple-darwin.tar.gz
    1093865368c5b9e6f88d273b64c85849c891444c598dcab872ee6ca37a4b6c814b  guix-build-e8f50c5debe2/output/dist-archive/bitcoin-e8f50c5debe2.tar.gz
    11d26be9fd3bef2b03459ac4de7fbe8c97b2bc8046313f53ff03add7d697c28403  guix-build-e8f50c5debe2/output/powerpc64-linux-gnu/SHA256SUMS.part
    12dfc44ce17b066576e337461d9843ca4b4a029b57add079a847a24a2a9e40321c  guix-build-e8f50c5debe2/output/powerpc64-linux-gnu/bitcoin-e8f50c5debe2-powerpc64-linux-gnu-debug.tar.gz
    133a9fe2ca2b1f86855d9bd47414ae3ccd6652472b0e4510a73d5f24e2cb5d7a8d  guix-build-e8f50c5debe2/output/powerpc64-linux-gnu/bitcoin-e8f50c5debe2-powerpc64-linux-gnu.tar.gz
    144d1a139f7e22fe3333c96b355fb5bb599cea0b0c7e83619fd2505a45f73c8e6e  guix-build-e8f50c5debe2/output/riscv64-linux-gnu/SHA256SUMS.part
    1515b148748fae1403ab79a00d9320b70f3c2275c492cc7761df41ee8d8be6a59a  guix-build-e8f50c5debe2/output/riscv64-linux-gnu/bitcoin-e8f50c5debe2-riscv64-linux-gnu-debug.tar.gz
    16f90f17f276d5cdd866aa07b5f853c1d110eb37df5b561b69d861b78678672719  guix-build-e8f50c5debe2/output/riscv64-linux-gnu/bitcoin-e8f50c5debe2-riscv64-linux-gnu.tar.gz
    17f8dfe9e92b52167c0bd21f57fd63b28882c9bf9673b038c38f39730eec0ad0a7  guix-build-e8f50c5debe2/output/x86_64-apple-darwin/SHA256SUMS.part
    187acc601c6d3b02ca757d10b2cd992cba6fa5c432cbd1c78f1f11bb11135c69ad  guix-build-e8f50c5debe2/output/x86_64-apple-darwin/bitcoin-e8f50c5debe2-x86_64-apple-darwin-unsigned.tar.gz
    19ecc294be346a9755a51354a4cd0aeb33651506f306069a3966d67e7b45f44daa  guix-build-e8f50c5debe2/output/x86_64-apple-darwin/bitcoin-e8f50c5debe2-x86_64-apple-darwin-unsigned.zip
    20c21ce456ec028304799c1cab06ac1dfc4c53d3add3f1f7dc4d5d42582a4bde95  guix-build-e8f50c5debe2/output/x86_64-apple-darwin/bitcoin-e8f50c5debe2-x86_64-apple-darwin.tar.gz
    21b61b2ba603ec2830e351bd6631876e6f3098d022befa1a7564f4fb64f3fdf22b  guix-build-e8f50c5debe2/output/x86_64-linux-gnu/SHA256SUMS.part
    225277cec1cdabacccd2dfae3607a71509074a58482861186fd71f11b7636380f7  guix-build-e8f50c5debe2/output/x86_64-linux-gnu/bitcoin-e8f50c5debe2-x86_64-linux-gnu-debug.tar.gz
    23c1b300217698837c4503e266c12dc10399f21774d919de5f875fe6f090da453f  guix-build-e8f50c5debe2/output/x86_64-linux-gnu/bitcoin-e8f50c5debe2-x86_64-linux-gnu.tar.gz
    24c49124e733de8587b95cbfc07076111e306de008c3f0390eb90a03076db23eaa  guix-build-e8f50c5debe2/output/x86_64-w64-mingw32/SHA256SUMS.part
    25a0d8a61b6a42beea561eb799825a2af43a1d07b9638c114887b90945e7a1fefc  guix-build-e8f50c5debe2/output/x86_64-w64-mingw32/bitcoin-e8f50c5debe2-win64-debug.zip
    264a9915cf08aeb23775b5a7b9142b85cdce28686a97e05882f98777c4106b0e19  guix-build-e8f50c5debe2/output/x86_64-w64-mingw32/bitcoin-e8f50c5debe2-win64-setup-unsigned.exe
    273d2ed27bf47823b48ba55a0839f8a064bf5dc9e59b2af25299de43663126394e  guix-build-e8f50c5debe2/output/x86_64-w64-mingw32/bitcoin-e8f50c5debe2-win64-unsigned.tar.gz
    285c116eec993f8ce82cd0ca4e698570ac7d25542c4d17992562c736052ec72fde  guix-build-e8f50c5debe2/output/x86_64-w64-mingw32/bitcoin-e8f50c5debe2-win64.zip
    
  23. Sjors commented at 11:57 am on November 26, 2024: member

    Getting the same guix hashes on x86_64 as @TheCharlatan, still working on my aarch64 guix system.

    Update 2024-11-27: aarch64 guix also matches.

  24. fanquake merged this on Nov 27, 2024
  25. fanquake closed this on Nov 27, 2024

  26. fanquake deleted the branch on Nov 27, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me