doc: Correct PR Review Club frequency from weekly to monthly #31327

pull GabrieleBocchi wants to merge 1 commits into bitcoin:master from GabrieleBocchi:fix-pr-club-frequency changing 1 files +1 −2
  1. GabrieleBocchi commented at 10:46 pm on November 19, 2024: contributor
    The PR Review Club is mentioned as weekly in the CONTRIBUTING.md file, but it is held monthly as per the official Bitcoin Core PR Review Club website. This PR updates the documentation to just remove the frequency.
  2. DrahtBot commented at 10:46 pm on November 19, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31327.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake
    Concept ACK tdb3, kevkevinpal

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Docs on Nov 19, 2024
  4. jonatack commented at 11:53 pm on November 19, 2024: member

    Perhaps drop the periodicity altogether, as it may evolve.

    (In which case, could also drop the word “meeting”.)

  5. tdb3 commented at 1:12 am on November 20, 2024: contributor
    Concept ACK I agree with the suggestion from @jonatack. It’d be good to drop “monthly” and “meeting”.
  6. kevkevinpal commented at 2:23 am on November 20, 2024: contributor

    Concept ACK

    I agree with tbd3 and jonatack, drop the “monthly” and “meeting” and even if the frequency changes we won’t need to touch this again. Unless the link is dead

  7. GabrieleBocchi commented at 9:25 am on November 20, 2024: contributor
    Thank you for the suggestion! I completely agree. I’ve updated the PR accordingly.
  8. tdb3 commented at 10:03 am on November 20, 2024: contributor
    Let’s squash the two commits into one. It makes for a cleaner history when this is merged.
  9. doc: remove PR Review Club frequency 637f437a16
  10. GabrieleBocchi force-pushed on Nov 20, 2024
  11. GabrieleBocchi commented at 10:26 am on November 20, 2024: contributor
    Thank you @tdb3, I did it. Should I also update the PR description? This is actually my first contribution to this project, thank you for your guidance and support!
  12. fanquake approved
  13. fanquake commented at 10:57 am on November 20, 2024: member

    ACK 637f437a1642ce845d7f750b45b71320a82d83b5

    Should I also update the PR description?

    Yes. I’ve done it now in any case.

  14. DrahtBot requested review from tdb3 on Nov 20, 2024
  15. fanquake merged this on Nov 20, 2024
  16. fanquake closed this on Nov 20, 2024

  17. GabrieleBocchi deleted the branch on Nov 20, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me