depends: Avoid using helper variables in toolchain file

hebasto commented at 1:49 pm on November 24, 2024: member

Using helper variables has two issues:

They contaminate the global namespace of the main build script.
They can be used as set(var), effectively exposing a cache variable var, which makes the toolchain file susceptible to the build environment.

The depends/Makefile can generate values with “not-set” semantics as empty strings or strings containing only spaces. For example:https://github.com/bitcoin/bitcoin/blob/2638fdb4f934be96b7c798dbac38ea5ab8a6374a/depends/Makefile#L157 Therefore, MATCHES must be used rather than STREQUAL.

DrahtBot commented at 1:50 pm on November 24, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31360.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	purpleKarrot

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

DrahtBot added the label Build system on Nov 24, 2024

DrahtBot added the label Needs rebase on Mar 14, 2025

hebasto force-pushed on Mar 17, 2025

hebasto commented at 12:00 pm on March 17, 2025: member

Rebased.

DrahtBot added the label CI failed on Mar 17, 2025

DrahtBot removed the label Needs rebase on Mar 17, 2025

maflcko commented at 7:52 pm on March 17, 2025: member

CI fails with https://cirrus-ci.com/task/6136289713455104?logs=ci#L531 :

 0copying packages: boost libevent qt expat libxcb xcb_proto libXau xproto freetype fontconfig libxkbcommon libxcb_util libxcb_util_render libxcb_util_keysyms libxcb_util_image libxcb_util_wm qrencode systemtap zeromq
 1to: /ci_container_base/depends/x86_64-pc-linux-gnu
 2To build Bitcoin Core with these packages, pass '--toolchain /ci_container_base/depends/x86_64-pc-linux-gnu/toolchain.cmake' to the first CMake invocation.
 3make: Leaving directory '/ci_container_base/depends'
 4+ '[' '' = true ']'
 5+ BITCOIN_CONFIG_ALL='-DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON'
 6+ '[' -z '' ']'
 7+ BITCOIN_CONFIG_ALL='-DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DCMAKE_TOOLCHAIN_FILE=/ci_container_base/depends/x86_64-pc-linux-gnu/toolchain.cmake'
 8+ '[' -z '' ']'
 9+ BITCOIN_CONFIG_ALL='-DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DCMAKE_TOOLCHAIN_FILE=/ci_container_base/depends/x86_64-pc-linux-gnu/toolchain.cmake -DWERROR=ON'
10+ ccache --zero-stats
11Statistics zeroed
12+ PRINT_CCACHE_STATISTICS='ccache --version | head -n 1 && ccache --show-stats'
13+ BASE_BUILD_DIR=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu
14+ mkdir -p /ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu
15+ cd /ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu
16+ BITCOIN_CONFIG_ALL='-DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DCMAKE_TOOLCHAIN_FILE=/ci_container_base/depends/x86_64-pc-linux-gnu/toolchain.cmake -DWERROR=ON -DENABLE_EXTERNAL_SIGNER=ON -DCMAKE_INSTALL_PREFIX=/ci_container_base/ci/scratch/out'
17+ [[ false == \t\r\u\e ]]
18++ cmake -P /ci_container_base/ci/test/GetCMakeLogFiles.cmake
19+ bash -c 'cmake -S /ci_container_base -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DCMAKE_TOOLCHAIN_FILE=/ci_container_base/depends/x86_64-pc-linux-gnu/toolchain.cmake -DWERROR=ON -DENABLE_EXTERNAL_SIGNER=ON -DCMAKE_INSTALL_PREFIX=/ci_container_base/ci/scratch/out -DREDUCE_EXPORTS=ON -DBUILD_UTIL_CHAINSTATE=ON -DBUILD_KERNEL_LIB=ON -DBUILD_SHARED_LIBS=ON || ( (cat CMakeFiles/CMakeOutput.log CMakeFiles/CMakeError.log) && false)'
20-- The CXX compiler identification is Clang 16.0.6
21-- Detecting CXX compiler ABI info
22-- Detecting CXX compiler ABI info - done
23-- Check for working CXX compiler: /usr/bin/clang++-16 - skipped
24-- Detecting CXX compile features
25-- Detecting CXX compile features - done
26-- Setting build type to "RelWithDebInfo" as none was specified
27-- Performing Test CXX_SUPPORTS__WERROR
28-- Performing Test CXX_SUPPORTS__WERROR - Success
29-- Performing Test CXX_SUPPORTS__G3
30-- Performing Test CXX_SUPPORTS__G3 - Success
31-- Performing Test LINKER_SUPPORTS__G3
32-- Performing Test LINKER_SUPPORTS__G3 - Success
33-- Performing Test CXX_SUPPORTS__FTRAPV
34-- Performing Test CXX_SUPPORTS__FTRAPV - Success
35-- Performing Test LINKER_SUPPORTS__FTRAPV
36-- Performing Test LINKER_SUPPORTS__FTRAPV - Success
37-- Configuring incomplete, errors occurred!
38See also "/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/CMakeFiles/CMakeOutput.log".
39CMake Error at /usr/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
40  Could NOT find BerkeleyDB (missing: BerkeleyDB_LIBRARY
41  BerkeleyDB_INCLUDE_DIR) (Required is at least version "4.8")
42Call Stack (most recent call first):
43  /usr/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
44  cmake/module/FindBerkeleyDB.cmake:107 (find_package_handle_standard_args)
45  CMakeLists.txt:116 (find_package)

hebasto force-pushed on Mar 18, 2025

hebasto commented at 9:03 am on March 18, 2025: member

CI fails with https://cirrus-ci.com/task/6136289713455104?logs=ci#L531 :

It was an error during rebasing. Fixed.

Thank you!

DrahtBot removed the label CI failed on Mar 18, 2025

DrahtBot added the label Needs rebase on May 7, 2025

depends: Avoid using helper variables in toolchain file

Using helper variables has two issues:
1. They contaminate the global namespace of the main build script.
2. They can be used as `set(var)`, effectively exposing a cache variable
`var`, which makes the toolchain file susceptible to the build
environment.

7343a1846c

hebasto force-pushed on May 7, 2025

hebasto commented at 4:05 pm on May 7, 2025: member

Rebased due to a conflict with the merged bitcoin/bitcoin#28710.

DrahtBot removed the label Needs rebase on May 7, 2025

fanquake added the label DrahtBot Guix build requested on May 8, 2025

fanquake commented at 9:27 am on May 8, 2025: member

cc @purpleKarrot

purpleKarrot commented at 11:17 am on May 8, 2025: contributor

ACK 7343a1846cebf74ffef3c54e05b633df629510a1

I am not particularly happy with logic in toolchain files. Removing helper variables is a step in the right direction.

fanquake commented at 1:25 pm on May 8, 2025: member

Guix Build:

 0cab0e4d3d2602d2eaa8893ae5294bd736b514fea6deb72df03c4d693971282dd  guix-build-7343a1846ceb/output/aarch64-linux-gnu/SHA256SUMS.part
 121163373fc74e834f3d81309888fc4cd99719462be8fef447e535fb56aa5ce1e  guix-build-7343a1846ceb/output/aarch64-linux-gnu/bitcoin-7343a1846ceb-aarch64-linux-gnu-debug.tar.gz
 2b09ca7a33bf16d3e97bce8800bf57a06402a9cf4860d327be3d6571a56be598c  guix-build-7343a1846ceb/output/aarch64-linux-gnu/bitcoin-7343a1846ceb-aarch64-linux-gnu.tar.gz
 3f1b2aa3edd0ce6b4e6641f8f7b6a1d7d877062082899e6c9e01f439b5af432dd  guix-build-7343a1846ceb/output/arm-linux-gnueabihf/SHA256SUMS.part
 4b48721be29949b71f07bd15960df5b086662ef8959539c7ed298a7e3c0fddac1  guix-build-7343a1846ceb/output/arm-linux-gnueabihf/bitcoin-7343a1846ceb-arm-linux-gnueabihf-debug.tar.gz
 5592630eb52eb268831bee123c96414a73d2146449d58af194bf948d6ad49ce8b  guix-build-7343a1846ceb/output/arm-linux-gnueabihf/bitcoin-7343a1846ceb-arm-linux-gnueabihf.tar.gz
 602f2a71a5118ac84f5343bcd59bac28156bc748e2a514e008a1b3cfba1efc8cd  guix-build-7343a1846ceb/output/arm64-apple-darwin/SHA256SUMS.part
 781c6a6eb496180b2f74902a19bd3e9790b7fbd1d60b33c9c0ae015222a931fb3  guix-build-7343a1846ceb/output/arm64-apple-darwin/bitcoin-7343a1846ceb-arm64-apple-darwin-codesigning.tar.gz
 8d5e2892fbf2526ed2fe390afedc9cb0bafe369edf2310bebf66ff2d74e47bf4c  guix-build-7343a1846ceb/output/arm64-apple-darwin/bitcoin-7343a1846ceb-arm64-apple-darwin-unsigned.tar.gz
 92caf49f194410437ca913b467007f32174ddae19dfa37c4cd47945df88fdceac  guix-build-7343a1846ceb/output/arm64-apple-darwin/bitcoin-7343a1846ceb-arm64-apple-darwin-unsigned.zip
10f81a5953adee05c82212ab7f9760aef8ca638be7ac470e56f88b0f8b1c45d86a  guix-build-7343a1846ceb/output/dist-archive/bitcoin-7343a1846ceb.tar.gz
11cda715fbc897a215cf4550ffc6474f7e236b9f07e8fde63b416e4006ffa2bfa5  guix-build-7343a1846ceb/output/powerpc64-linux-gnu/SHA256SUMS.part
1239c367e07c55d717b798f8830d618f5176b9937aa7ada20bcbaa7fece43cef38  guix-build-7343a1846ceb/output/powerpc64-linux-gnu/bitcoin-7343a1846ceb-powerpc64-linux-gnu-debug.tar.gz
1357d2b3f035348b31e4dca3a9f64fe23819135cac35d54c928dfea05fc66dda24  guix-build-7343a1846ceb/output/powerpc64-linux-gnu/bitcoin-7343a1846ceb-powerpc64-linux-gnu.tar.gz
142877f662790f1824b90076a4286d37082eaa75a5c78d0c2435cb1fd634d6dc81  guix-build-7343a1846ceb/output/riscv64-linux-gnu/SHA256SUMS.part
15a53d8c19e2542e33066cbc499f57206ea3ae045a3b4ada2a7dd2ec26a34cb108  guix-build-7343a1846ceb/output/riscv64-linux-gnu/bitcoin-7343a1846ceb-riscv64-linux-gnu-debug.tar.gz
16a257d46f6e2278174a0497b54291b94c86343e6188c08364328f88c6693c4835  guix-build-7343a1846ceb/output/riscv64-linux-gnu/bitcoin-7343a1846ceb-riscv64-linux-gnu.tar.gz
17d44daac31e753dbcd7b3b415d591b561087e3df9767e93f16c68456a4d5d6b4e  guix-build-7343a1846ceb/output/x86_64-apple-darwin/SHA256SUMS.part
184fbffee4fdafb22ec0e525eba5253f5d3e13248618162a13e7e4e02224fd9cef  guix-build-7343a1846ceb/output/x86_64-apple-darwin/bitcoin-7343a1846ceb-x86_64-apple-darwin-codesigning.tar.gz
19a97aba19627151147079296451cdee4afed17279479b191a59f49bb48eb60fb9  guix-build-7343a1846ceb/output/x86_64-apple-darwin/bitcoin-7343a1846ceb-x86_64-apple-darwin-unsigned.tar.gz
2011e4e01eeddc5dd7e8e517761ef716a1b7f2306d8a8a42a62f3d5b7d9f3e7733  guix-build-7343a1846ceb/output/x86_64-apple-darwin/bitcoin-7343a1846ceb-x86_64-apple-darwin-unsigned.zip
218ac5b21003028e25351736b6feb4a219a63089a6e600fdea56e9c3c3aa6febe3  guix-build-7343a1846ceb/output/x86_64-linux-gnu/SHA256SUMS.part
228c1dd473075143496861b13374db9a3cee3ed256bf1048be20bcc72c191eb182  guix-build-7343a1846ceb/output/x86_64-linux-gnu/bitcoin-7343a1846ceb-x86_64-linux-gnu-debug.tar.gz
234627302058f8d77d4f376424ba6a09a35a0ecc739e299167f8404a69b9769e85  guix-build-7343a1846ceb/output/x86_64-linux-gnu/bitcoin-7343a1846ceb-x86_64-linux-gnu.tar.gz
249a28ccc9d13aacc4d41486a77905c2b4d502b9605415d7dcf84aa43ecdfc4c97  guix-build-7343a1846ceb/output/x86_64-w64-mingw32/SHA256SUMS.part
2565df4aa6f05c748326355e63fd3d6e5db95958aa9db98a4ee0dacb468deec5d8  guix-build-7343a1846ceb/output/x86_64-w64-mingw32/bitcoin-7343a1846ceb-win64-codesigning.tar.gz
269c6469f487b90efdc9e9b3434911bdfce8af928dab1cf4656866810af8b6279f  guix-build-7343a1846ceb/output/x86_64-w64-mingw32/bitcoin-7343a1846ceb-win64-debug.zip
2746a14313e12b81fd3d21dd30c48c124db8b9cf6ecaa62a1519cddd5c268e95eb  guix-build-7343a1846ceb/output/x86_64-w64-mingw32/bitcoin-7343a1846ceb-win64-setup-unsigned.exe
28fc8e7170b6f0de996a56095ff8daed90e6b962933f14f1e18f696c5fcf041ccb  guix-build-7343a1846ceb/output/x86_64-w64-mingw32/bitcoin-7343a1846ceb-win64-unsigned.zip

fanquake requested review from theuni on May 8, 2025

DrahtBot commented at 8:42 pm on May 8, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 64697529523705f5a411ca893060429afcd5cd47(master)	commit 061e0c4b77e30388b979224ed056cd365d940e95(pull/31360/merge)
*-aarch64-linux-gnu-debug.tar.gz	`61f0ce7a950a0877...`	`fe4721792a10145d...`
*-aarch64-linux-gnu.tar.gz	`95854e4785a50e2e...`	`75657dd0c3c2104b...`
*-arm-linux-gnueabihf-debug.tar.gz	`d90555a1bc2baa80...`	`f82a2426aaf20d2d...`
*-arm-linux-gnueabihf.tar.gz	`e3fdda4c5939dd41...`	`d31614b8b275efe6...`
*-arm64-apple-darwin-codesigning.tar.gz	`2ed866f981b3051e...`	`c38863e8cd5f0d6b...`
*-arm64-apple-darwin-unsigned.tar.gz	`5ba09cb3196612ed...`	`962c24f6c41c7b72...`
*-arm64-apple-darwin-unsigned.zip	`7f14d6051896975d...`	`a9b5496c7e3647f7...`
*-powerpc64-linux-gnu-debug.tar.gz	`9d6e2f22955d5cc8...`	`5146a1ed78e5d7f2...`
*-powerpc64-linux-gnu.tar.gz	`572057df00e9d16c...`	`0066b98ea4bc4a29...`
*-riscv64-linux-gnu-debug.tar.gz	`982616d1b25117f0...`	`d1d33bf75260359a...`
*-riscv64-linux-gnu.tar.gz	`11a6543d62e7ae10...`	`d6fcb84c021469e0...`
*-x86_64-apple-darwin-codesigning.tar.gz	`efed3e74711d4ee8...`	`e1fcf041b285a434...`
*-x86_64-apple-darwin-unsigned.tar.gz	`ed6d74971993a386...`	`ab8f417874ccd032...`
*-x86_64-apple-darwin-unsigned.zip	`ea6a107e5c056d6a...`	`a6f56697cad8d8ed...`
*-x86_64-linux-gnu-debug.tar.gz	`25fbb96d808b376c...`	`b9e3771267f34df9...`
*-x86_64-linux-gnu.tar.gz	`15c4af31d4663f4c...`	`9b5fa9610a376317...`
*.tar.gz	`724f4ec7942ba931...`	`139ed4ff756a3a2b...`
SHA256SUMS.part	`69f25940d4173e94...`	`40832d34bd08bb09...`
guix_build.log	`07cc90f2e376b2bd...`	`d68fedb156208dcc...`
guix_build.log.diff		`deced32fc1ae9307...`

DrahtBot removed the label DrahtBot Guix build requested on May 8, 2025

hebasto commented at 7:56 am on May 9, 2025: member

My Guix build:

 0aarch64
 1cab0e4d3d2602d2eaa8893ae5294bd736b514fea6deb72df03c4d693971282dd  guix-build-7343a1846ceb/output/aarch64-linux-gnu/SHA256SUMS.part
 221163373fc74e834f3d81309888fc4cd99719462be8fef447e535fb56aa5ce1e  guix-build-7343a1846ceb/output/aarch64-linux-gnu/bitcoin-7343a1846ceb-aarch64-linux-gnu-debug.tar.gz
 3b09ca7a33bf16d3e97bce8800bf57a06402a9cf4860d327be3d6571a56be598c  guix-build-7343a1846ceb/output/aarch64-linux-gnu/bitcoin-7343a1846ceb-aarch64-linux-gnu.tar.gz
 4f1b2aa3edd0ce6b4e6641f8f7b6a1d7d877062082899e6c9e01f439b5af432dd  guix-build-7343a1846ceb/output/arm-linux-gnueabihf/SHA256SUMS.part
 5b48721be29949b71f07bd15960df5b086662ef8959539c7ed298a7e3c0fddac1  guix-build-7343a1846ceb/output/arm-linux-gnueabihf/bitcoin-7343a1846ceb-arm-linux-gnueabihf-debug.tar.gz
 6592630eb52eb268831bee123c96414a73d2146449d58af194bf948d6ad49ce8b  guix-build-7343a1846ceb/output/arm-linux-gnueabihf/bitcoin-7343a1846ceb-arm-linux-gnueabihf.tar.gz
 702f2a71a5118ac84f5343bcd59bac28156bc748e2a514e008a1b3cfba1efc8cd  guix-build-7343a1846ceb/output/arm64-apple-darwin/SHA256SUMS.part
 881c6a6eb496180b2f74902a19bd3e9790b7fbd1d60b33c9c0ae015222a931fb3  guix-build-7343a1846ceb/output/arm64-apple-darwin/bitcoin-7343a1846ceb-arm64-apple-darwin-codesigning.tar.gz
 9d5e2892fbf2526ed2fe390afedc9cb0bafe369edf2310bebf66ff2d74e47bf4c  guix-build-7343a1846ceb/output/arm64-apple-darwin/bitcoin-7343a1846ceb-arm64-apple-darwin-unsigned.tar.gz
102caf49f194410437ca913b467007f32174ddae19dfa37c4cd47945df88fdceac  guix-build-7343a1846ceb/output/arm64-apple-darwin/bitcoin-7343a1846ceb-arm64-apple-darwin-unsigned.zip
11f81a5953adee05c82212ab7f9760aef8ca638be7ac470e56f88b0f8b1c45d86a  guix-build-7343a1846ceb/output/dist-archive/bitcoin-7343a1846ceb.tar.gz
12cda715fbc897a215cf4550ffc6474f7e236b9f07e8fde63b416e4006ffa2bfa5  guix-build-7343a1846ceb/output/powerpc64-linux-gnu/SHA256SUMS.part
1339c367e07c55d717b798f8830d618f5176b9937aa7ada20bcbaa7fece43cef38  guix-build-7343a1846ceb/output/powerpc64-linux-gnu/bitcoin-7343a1846ceb-powerpc64-linux-gnu-debug.tar.gz
1457d2b3f035348b31e4dca3a9f64fe23819135cac35d54c928dfea05fc66dda24  guix-build-7343a1846ceb/output/powerpc64-linux-gnu/bitcoin-7343a1846ceb-powerpc64-linux-gnu.tar.gz
152877f662790f1824b90076a4286d37082eaa75a5c78d0c2435cb1fd634d6dc81  guix-build-7343a1846ceb/output/riscv64-linux-gnu/SHA256SUMS.part
16a53d8c19e2542e33066cbc499f57206ea3ae045a3b4ada2a7dd2ec26a34cb108  guix-build-7343a1846ceb/output/riscv64-linux-gnu/bitcoin-7343a1846ceb-riscv64-linux-gnu-debug.tar.gz
17a257d46f6e2278174a0497b54291b94c86343e6188c08364328f88c6693c4835  guix-build-7343a1846ceb/output/riscv64-linux-gnu/bitcoin-7343a1846ceb-riscv64-linux-gnu.tar.gz
18d44daac31e753dbcd7b3b415d591b561087e3df9767e93f16c68456a4d5d6b4e  guix-build-7343a1846ceb/output/x86_64-apple-darwin/SHA256SUMS.part
194fbffee4fdafb22ec0e525eba5253f5d3e13248618162a13e7e4e02224fd9cef  guix-build-7343a1846ceb/output/x86_64-apple-darwin/bitcoin-7343a1846ceb-x86_64-apple-darwin-codesigning.tar.gz
20a97aba19627151147079296451cdee4afed17279479b191a59f49bb48eb60fb9  guix-build-7343a1846ceb/output/x86_64-apple-darwin/bitcoin-7343a1846ceb-x86_64-apple-darwin-unsigned.tar.gz
2111e4e01eeddc5dd7e8e517761ef716a1b7f2306d8a8a42a62f3d5b7d9f3e7733  guix-build-7343a1846ceb/output/x86_64-apple-darwin/bitcoin-7343a1846ceb-x86_64-apple-darwin-unsigned.zip
228ac5b21003028e25351736b6feb4a219a63089a6e600fdea56e9c3c3aa6febe3  guix-build-7343a1846ceb/output/x86_64-linux-gnu/SHA256SUMS.part
238c1dd473075143496861b13374db9a3cee3ed256bf1048be20bcc72c191eb182  guix-build-7343a1846ceb/output/x86_64-linux-gnu/bitcoin-7343a1846ceb-x86_64-linux-gnu-debug.tar.gz
244627302058f8d77d4f376424ba6a09a35a0ecc739e299167f8404a69b9769e85  guix-build-7343a1846ceb/output/x86_64-linux-gnu/bitcoin-7343a1846ceb-x86_64-linux-gnu.tar.gz
259a28ccc9d13aacc4d41486a77905c2b4d502b9605415d7dcf84aa43ecdfc4c97  guix-build-7343a1846ceb/output/x86_64-w64-mingw32/SHA256SUMS.part
2665df4aa6f05c748326355e63fd3d6e5db95958aa9db98a4ee0dacb468deec5d8  guix-build-7343a1846ceb/output/x86_64-w64-mingw32/bitcoin-7343a1846ceb-win64-codesigning.tar.gz
279c6469f487b90efdc9e9b3434911bdfce8af928dab1cf4656866810af8b6279f  guix-build-7343a1846ceb/output/x86_64-w64-mingw32/bitcoin-7343a1846ceb-win64-debug.zip
2846a14313e12b81fd3d21dd30c48c124db8b9cf6ecaa62a1519cddd5c268e95eb  guix-build-7343a1846ceb/output/x86_64-w64-mingw32/bitcoin-7343a1846ceb-win64-setup-unsigned.exe
29fc8e7170b6f0de996a56095ff8daed90e6b962933f14f1e18f696c5fcf041ccb  guix-build-7343a1846ceb/output/x86_64-w64-mingw32/bitcoin-7343a1846ceb-win64-unsigned.zip

fanquake merged this on May 9, 2025

fanquake closed this on May 9, 2025

hebasto deleted the branch on May 9, 2025

depends: Avoid using helper variables in toolchain file #31360

Code Coverage & Benchmarks

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]