cmake: Check `-Wno-*` compiler options for `leveldb` target #31366

1. 
   hebasto commented at 3:12 PM on November 25, 2024: member

   Otherwise, https://cirrus-ci.com/task/4830737755537408:

   At global scope:
   cc1plus: note: unrecognized command-line option ‘-Wno-conditional-uninitialized’ may have been intended to silence earlier diagnostics
   

2. hebasto added the label Build system on Nov 25, 2024
3. 
   DrahtBot commented at 3:12 PM on November 25, 2024: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31366.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	TheCharlatan
   Stale ACK	theuni

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. theuni approved
5. 
   theuni commented at 6:08 PM on November 25, 2024: member

   utACK 0f73d9dd49b371c28ba9e74ef3519ef8f6e80ebc

   A more helpful commit message would've been useful though: "Check for -Wfoo rather than -Wno-foo because the latter may not cause the test to fail".

6. cmake: Check `-Wno-*` compiler options for `leveldb` target

   Check for -Wfoo rather than -Wno-foo because the latter may not cause
   the test to fail.

   9e4a4b4832
7. hebasto force-pushed on Nov 25, 2024
8. 
   hebasto commented at 8:25 PM on November 25, 2024: member

   A more helpful commit message would've been useful though: "Check for -Wfoo rather than -Wno-foo because the latter may not cause the test to fail".

   Thanks! The commit message has been amended per your feedback.

9. DrahtBot added the label CI failed on Nov 25, 2024
10. DrahtBot removed the label CI failed on Nov 26, 2024
11. sedited approved
12. 
    sedited commented at 9:51 AM on November 26, 2024: contributor

    ACK 9e4a4b4832219d9d11da441779ab8a3b1304bd8b

13. DrahtBot requested review from theuni on Nov 26, 2024
14. 
    fanquake commented at 12:20 PM on November 27, 2024: member

    In Autotools we filtered out the unwanted flags, ifor CMake, the -Wno-* variants were added (but in a way that didn't quite work), and this PR fixes their usage by adding checks for the flags. However that means we duplicate checks that we do for the same flags earlier in the buildsystem, and we end up with something like:

    clang++ ... -Wconditional-uninitialized -Wsuggest-override ... -Wno-conditional-uninitialized -Wno-suggest-override

    when building leveldb. Wondering if we could have less duplication, and a more sensical compile command, by reverting to what we did in Autotools, and just filter out the unwanted flags?

15. 
    hebasto commented at 1:08 PM on November 27, 2024: member

    However that means we duplicate checks that we do for the same flags earlier in the buildsystem...

    Checks are cached. You can observe only a single instance of:

    -- Performing Test CXX_SUPPORTS__WSUGGEST_OVERRIDE
    -- Performing Test CXX_SUPPORTS__WSUGGEST_OVERRIDE - Success
    

    in the configuration output.

16. 
    fanquake commented at 1:10 PM on November 27, 2024: member

    The code is duplicated.

17. 
    maflcko commented at 1:20 PM on November 27, 2024: member

    Personally I think it is fine append -Wno... in 5 lines of code. I'd presume filtering would require even more code?

18. 
    fanquake commented at 1:22 PM on November 27, 2024: member

    I'd presume filtering would require even more code?

    I don't see why it'd be more than 1 line.

19. fanquake merged this on Feb 20, 2025
20. fanquake closed this on Feb 20, 2025

    ---

21. hebasto deleted the branch on Feb 20, 2025
22. sedited referenced this in commit f78a01a560 on Feb 22, 2025
23. stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
24. stickies-v referenced this in commit cc83553352 on Mar 17, 2025
25. stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
26. stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
27. stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
28. bug-castercv502 referenced this in commit d15545ffaa on Sep 28, 2025
29. ivanlele referenced this in commit 5c30fff21d on Apr 16, 2026
30. Kino1994 referenced this in commit 361ed25a8d on Jun 28, 2026
31. BigcoinBGC referenced this in commit 64ed7562ec on Jun 30, 2026
32. bitcoin locked this on Jul 30, 2026

Review Requested
theuni