fuzz: add cstdlib to FuzzedDataProvider #31448

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:fuzzed_data_clang_20 changing 1 files +1 −0
  1. fanquake commented at 5:09 pm on December 9, 2024: member

    Same as https://github.com/llvm/llvm-project/pull/113951.

    Avoids compile failures under clang-20 & D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES:

    0In file included from /bitcoin/src/test/fuzz/addition_overflow.cpp:5:
    1/bitcoin/src/test/fuzz/FuzzedDataProvider.h:209:5: error: use of undeclared identifier 'abort'
    2  209 |     abort();
    3      |     ^
    4/bitcoin/src/test/fuzz/FuzzedDataProvider.h:250:5: error: use of undeclared identifier 'abort'
    5  250 |     abort();
    
  2. fuzz: add cstdlib to FuzzedDataProvider
    Same as https://github.com/llvm/llvm-project/pull/113951.
    
    Avoids compile failures under clang-20 &
    `D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES`:
    ```bash
    In file included from /bitcoin/src/test/fuzz/addition_overflow.cpp:5:
    /bitcoin/src/test/fuzz/FuzzedDataProvider.h:209:5: error: use of undeclared identifier 'abort'
      209 |     abort();
          |     ^
    /bitcoin/src/test/fuzz/FuzzedDataProvider.h:250:5: error: use of undeclared identifier 'abort'
      250 |     abort();
    ```
    bb7e686341
  3. DrahtBot commented at 5:09 pm on December 9, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31448.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK dergoegge, brunoerg

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Dec 9, 2024
  5. dergoegge approved
  6. dergoegge commented at 5:16 pm on December 9, 2024: member
    utACK bb7e686341e437b2e7aae887827710918c00ae0f
  7. brunoerg approved
  8. brunoerg commented at 5:40 pm on December 9, 2024: contributor
    ACK bb7e686341e437b2e7aae887827710918c00ae0f
  9. fanquake merged this on Dec 10, 2024
  10. fanquake closed this on Dec 10, 2024

  11. fanquake deleted the branch on Dec 10, 2024
  12. achow101 added the label Needs backport (28.x) on Dec 11, 2024
  13. achow101 referenced this in commit 2835158be0 on Dec 11, 2024
  14. fanquake removed the label Needs backport (28.x) on Dec 17, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-21 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me