guix: disable gcov in base-linux-gcc

fanquake commented at 6:21 pm on December 9, 2024: member

In a x86_64-linux-gnu build, this drops:

0x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov
1x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov-dump
2x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov-tool
3x86_64-linux-gnu/lib/gcc/x86_64-linux-gnu/12.4.0: libgcov.a

For mingw-w64-gcc, --disable-gcov is currently passed for this target in Guix, due to issues with mingw-w64, see https://github.com/fanquake/guix/blob/8bed031e58c9cf895d243790e7c80808b0075de7/gnu/packages/gcc.scm#L99-L102. However we’ll add it in any case, in case it’s re-enabled in future, when the underlying issues are fixed.

In a `x86_64-linux-gnu` build, this drops:
```bash
x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov
x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov-dump
x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov-tool
x86_64-linux-gnu/lib/gcc/x86_64-linux-gnu/12.4.0: libgcov.a
```

For mingw-w64-gcc, `--disable-gcov` is currently passed for this
target in Guix, due to issues with mingw-w64, see
https://github.com/fanquake/guix/blob/8bed031e58c9cf895d243790e7c80808b0075de7/gnu/packages/gcc.scm#L99-L102.
However we'll add it in any case, in case it's re-enabled in future,
when the underlying issues are fixed.

f6496a8388

DrahtBot commented at 6:21 pm on December 9, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31450.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Build system on Dec 9, 2024

theuni commented at 9:05 pm on December 9, 2024: member

lgtm. Any particular reason? Or just dropping unused binaries?

fanquake commented at 10:28 pm on December 9, 2024: member

@theuni just cleanup atm.

TheCharlatan approved

TheCharlatan commented at 9:03 am on December 10, 2024: contributor

ACK f6496a838828

Guix build (aarch64):

 0c7f2daace2e73fb0bdda835b503800b43f14433bbec11dbb5496591cee1ea46f  guix-build-f6496a838828/output/aarch64-linux-gnu/SHA256SUMS.part
 12643f100604d1ee665ca064cc425207e8a230d1a304d008aa7b59b2b9393483e  guix-build-f6496a838828/output/aarch64-linux-gnu/bitcoin-f6496a838828-aarch64-linux-gnu-debug.tar.gz
 297e738ed04037c22f8108c5cab82f82f6692eaa90aabe150483ac4e607c4b6da  guix-build-f6496a838828/output/aarch64-linux-gnu/bitcoin-f6496a838828-aarch64-linux-gnu.tar.gz
 3fe7fd7c244515b8f4d96d6d23439d233f1fa7b924e7dc92be0f480c5f9be78a7  guix-build-f6496a838828/output/arm-linux-gnueabihf/SHA256SUMS.part
 4c8a00f7d41ca5c00c4162af99790d06c18100df77934a40c32b88f84a22b9d87  guix-build-f6496a838828/output/arm-linux-gnueabihf/bitcoin-f6496a838828-arm-linux-gnueabihf-debug.tar.gz
 5ad499f5730fdb318dbe01d596369c43453724359b75a8b6f5b1ebaad6bcda99c  guix-build-f6496a838828/output/arm-linux-gnueabihf/bitcoin-f6496a838828-arm-linux-gnueabihf.tar.gz
 61c69f6d0c0a6324cf18bb826fa74bb62f679ac9938bbc9abe69f37de44658009  guix-build-f6496a838828/output/arm64-apple-darwin/SHA256SUMS.part
 7a42b758dbba627c661a9012851b9bfcf5d9f6d7d0407193b4fc904653ac5ffad  guix-build-f6496a838828/output/arm64-apple-darwin/bitcoin-f6496a838828-arm64-apple-darwin-unsigned.tar.gz
 86f3ac8e0fe2c52faf5f237c33020bd424c8ed0e512a8ff7f34dff0dbfcf4e7b2  guix-build-f6496a838828/output/arm64-apple-darwin/bitcoin-f6496a838828-arm64-apple-darwin-unsigned.zip
 9506ff0149e59d640e0dc0f0006f600d43a987c84e3000473db3643b0e9c21bd0  guix-build-f6496a838828/output/arm64-apple-darwin/bitcoin-f6496a838828-arm64-apple-darwin.tar.gz
1013293409b1cda85293128f1a5565f9643fe1c74cb0fa9ddb05e968e8ff4230f7  guix-build-f6496a838828/output/dist-archive/bitcoin-f6496a838828.tar.gz
116d9221d1a59968d15a375a35b98c246d78d64291ad4e9c3e097a098ad904bc67  guix-build-f6496a838828/output/powerpc64-linux-gnu/SHA256SUMS.part
12c257dd78ef056e0a5e4ea53285e18d5712d197e1a33c41149052744d8598b74a  guix-build-f6496a838828/output/powerpc64-linux-gnu/bitcoin-f6496a838828-powerpc64-linux-gnu-debug.tar.gz
1397263e8acad757db69679733824fc2d367842151765878a78351e76b582e589e  guix-build-f6496a838828/output/powerpc64-linux-gnu/bitcoin-f6496a838828-powerpc64-linux-gnu.tar.gz
1477bb750fb99a3e697cdc6382a26ca0a91845c4369ff34c55b92407fc865589da  guix-build-f6496a838828/output/riscv64-linux-gnu/SHA256SUMS.part
152d6d628cf1edd50ca4cba6eb329e437493ca32a29601cfe8846b04bfed3791ad  guix-build-f6496a838828/output/riscv64-linux-gnu/bitcoin-f6496a838828-riscv64-linux-gnu-debug.tar.gz
169003283786eed5875f68d2f8c011f9da534322083a90ea1471e926603ff5e617  guix-build-f6496a838828/output/riscv64-linux-gnu/bitcoin-f6496a838828-riscv64-linux-gnu.tar.gz
17d6770db009264670cc5f8008a5fcd9fbf1e966c9cd66228ea9c2b75dff3e60bc  guix-build-f6496a838828/output/x86_64-apple-darwin/SHA256SUMS.part
18e7826f022d910a6dcdc38f6390fcc17df7c9f6ae4c17eaa77a73d645e012463f  guix-build-f6496a838828/output/x86_64-apple-darwin/bitcoin-f6496a838828-x86_64-apple-darwin-unsigned.tar.gz
195e4c3fde07e8a0224576439b6b0ba1f91548997d8c0bf56dd36f51a75bef63b9  guix-build-f6496a838828/output/x86_64-apple-darwin/bitcoin-f6496a838828-x86_64-apple-darwin-unsigned.zip
20162c86eff3c8331feef54b8eb33b45d3e25723cb36c65b28e32db3194f1707c2  guix-build-f6496a838828/output/x86_64-apple-darwin/bitcoin-f6496a838828-x86_64-apple-darwin.tar.gz
218042ee7ff8fd9653de2cb72a629812a9e616163e7a83d890e6d88612d1273ddb  guix-build-f6496a838828/output/x86_64-linux-gnu/SHA256SUMS.part
22caea65a89be6fd11a7fd4f5c6b5a6c7c83e9539585815a8e4b32f915e73f1527  guix-build-f6496a838828/output/x86_64-linux-gnu/bitcoin-f6496a838828-x86_64-linux-gnu-debug.tar.gz
2309852839744b5f8813d2dd668a3f0df59106f228f7fa31c5d91183f8a37e4683  guix-build-f6496a838828/output/x86_64-linux-gnu/bitcoin-f6496a838828-x86_64-linux-gnu.tar.gz
2417c2242fc37582668a7feff0552c94424106a65a33104a153d1b48698602f578  guix-build-f6496a838828/output/x86_64-w64-mingw32/SHA256SUMS.part
25415e9e843d0a43e7a3485fe17a95ed19679dc4f52db4e0a1c48df799cd227f3b  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64-debug.zip
26dd5a1a8d4279c6f5860ec3579bdb7b69c5d54910608c9cbf23ab782880acc343  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64-setup-unsigned.exe
279e400fbfe1e1be62d4965adeba9ec75fadd062905c797162b233804b9c3e9259  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64-unsigned.tar.gz
28a39328f89f3ea2497ccc8ada94119e1622d44b04ff105b22249b010fe1eacdaa  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64.zip

fanquake commented at 1:53 pm on December 10, 2024: member

Guix Build (x86_64):

 0c7f2daace2e73fb0bdda835b503800b43f14433bbec11dbb5496591cee1ea46f  guix-build-f6496a838828/output/aarch64-linux-gnu/SHA256SUMS.part
 12643f100604d1ee665ca064cc425207e8a230d1a304d008aa7b59b2b9393483e  guix-build-f6496a838828/output/aarch64-linux-gnu/bitcoin-f6496a838828-aarch64-linux-gnu-debug.tar.gz
 297e738ed04037c22f8108c5cab82f82f6692eaa90aabe150483ac4e607c4b6da  guix-build-f6496a838828/output/aarch64-linux-gnu/bitcoin-f6496a838828-aarch64-linux-gnu.tar.gz
 3fe7fd7c244515b8f4d96d6d23439d233f1fa7b924e7dc92be0f480c5f9be78a7  guix-build-f6496a838828/output/arm-linux-gnueabihf/SHA256SUMS.part
 4c8a00f7d41ca5c00c4162af99790d06c18100df77934a40c32b88f84a22b9d87  guix-build-f6496a838828/output/arm-linux-gnueabihf/bitcoin-f6496a838828-arm-linux-gnueabihf-debug.tar.gz
 5ad499f5730fdb318dbe01d596369c43453724359b75a8b6f5b1ebaad6bcda99c  guix-build-f6496a838828/output/arm-linux-gnueabihf/bitcoin-f6496a838828-arm-linux-gnueabihf.tar.gz
 61c69f6d0c0a6324cf18bb826fa74bb62f679ac9938bbc9abe69f37de44658009  guix-build-f6496a838828/output/arm64-apple-darwin/SHA256SUMS.part
 7a42b758dbba627c661a9012851b9bfcf5d9f6d7d0407193b4fc904653ac5ffad  guix-build-f6496a838828/output/arm64-apple-darwin/bitcoin-f6496a838828-arm64-apple-darwin-unsigned.tar.gz
 86f3ac8e0fe2c52faf5f237c33020bd424c8ed0e512a8ff7f34dff0dbfcf4e7b2  guix-build-f6496a838828/output/arm64-apple-darwin/bitcoin-f6496a838828-arm64-apple-darwin-unsigned.zip
 9506ff0149e59d640e0dc0f0006f600d43a987c84e3000473db3643b0e9c21bd0  guix-build-f6496a838828/output/arm64-apple-darwin/bitcoin-f6496a838828-arm64-apple-darwin.tar.gz
1013293409b1cda85293128f1a5565f9643fe1c74cb0fa9ddb05e968e8ff4230f7  guix-build-f6496a838828/output/dist-archive/bitcoin-f6496a838828.tar.gz
116d9221d1a59968d15a375a35b98c246d78d64291ad4e9c3e097a098ad904bc67  guix-build-f6496a838828/output/powerpc64-linux-gnu/SHA256SUMS.part
12c257dd78ef056e0a5e4ea53285e18d5712d197e1a33c41149052744d8598b74a  guix-build-f6496a838828/output/powerpc64-linux-gnu/bitcoin-f6496a838828-powerpc64-linux-gnu-debug.tar.gz
1397263e8acad757db69679733824fc2d367842151765878a78351e76b582e589e  guix-build-f6496a838828/output/powerpc64-linux-gnu/bitcoin-f6496a838828-powerpc64-linux-gnu.tar.gz
1477bb750fb99a3e697cdc6382a26ca0a91845c4369ff34c55b92407fc865589da  guix-build-f6496a838828/output/riscv64-linux-gnu/SHA256SUMS.part
152d6d628cf1edd50ca4cba6eb329e437493ca32a29601cfe8846b04bfed3791ad  guix-build-f6496a838828/output/riscv64-linux-gnu/bitcoin-f6496a838828-riscv64-linux-gnu-debug.tar.gz
169003283786eed5875f68d2f8c011f9da534322083a90ea1471e926603ff5e617  guix-build-f6496a838828/output/riscv64-linux-gnu/bitcoin-f6496a838828-riscv64-linux-gnu.tar.gz
17d6770db009264670cc5f8008a5fcd9fbf1e966c9cd66228ea9c2b75dff3e60bc  guix-build-f6496a838828/output/x86_64-apple-darwin/SHA256SUMS.part
18e7826f022d910a6dcdc38f6390fcc17df7c9f6ae4c17eaa77a73d645e012463f  guix-build-f6496a838828/output/x86_64-apple-darwin/bitcoin-f6496a838828-x86_64-apple-darwin-unsigned.tar.gz
195e4c3fde07e8a0224576439b6b0ba1f91548997d8c0bf56dd36f51a75bef63b9  guix-build-f6496a838828/output/x86_64-apple-darwin/bitcoin-f6496a838828-x86_64-apple-darwin-unsigned.zip
20162c86eff3c8331feef54b8eb33b45d3e25723cb36c65b28e32db3194f1707c2  guix-build-f6496a838828/output/x86_64-apple-darwin/bitcoin-f6496a838828-x86_64-apple-darwin.tar.gz
218042ee7ff8fd9653de2cb72a629812a9e616163e7a83d890e6d88612d1273ddb  guix-build-f6496a838828/output/x86_64-linux-gnu/SHA256SUMS.part
22caea65a89be6fd11a7fd4f5c6b5a6c7c83e9539585815a8e4b32f915e73f1527  guix-build-f6496a838828/output/x86_64-linux-gnu/bitcoin-f6496a838828-x86_64-linux-gnu-debug.tar.gz
2309852839744b5f8813d2dd668a3f0df59106f228f7fa31c5d91183f8a37e4683  guix-build-f6496a838828/output/x86_64-linux-gnu/bitcoin-f6496a838828-x86_64-linux-gnu.tar.gz
2417c2242fc37582668a7feff0552c94424106a65a33104a153d1b48698602f578  guix-build-f6496a838828/output/x86_64-w64-mingw32/SHA256SUMS.part
25415e9e843d0a43e7a3485fe17a95ed19679dc4f52db4e0a1c48df799cd227f3b  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64-debug.zip
26dd5a1a8d4279c6f5860ec3579bdb7b69c5d54910608c9cbf23ab782880acc343  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64-setup-unsigned.exe
279e400fbfe1e1be62d4965adeba9ec75fadd062905c797162b233804b9c3e9259  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64-unsigned.tar.gz
28a39328f89f3ea2497ccc8ada94119e1622d44b04ff105b22249b010fe1eacdaa  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64.zip

fanquake merged this on Dec 11, 2024

fanquake closed this on Dec 11, 2024

fanquake deleted the branch on Dec 11, 2024

guix: disable gcov in base-linux-gcc #31450

Code Coverage & Benchmarks

Reviews