guix: disable gcov in base-linux-gcc #31450

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:no_gcov changing 1 files +2 −0
  1. fanquake commented at 6:21 PM on December 9, 2024: member

    In a x86_64-linux-gnu build, this drops:

    x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov
x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov-dump
x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov-tool
x86_64-linux-gnu/lib/gcc/x86_64-linux-gnu/12.4.0: libgcov.a

    For mingw-w64-gcc, --disable-gcov is currently passed for this target in Guix, due to issues with mingw-w64, see https://github.com/fanquake/guix/blob/8bed031e58c9cf895d243790e7c80808b0075de7/gnu/packages/gcc.scm#L99-L102. However we'll add it in any case, in case it's re-enabled in future, when the underlying issues are fixed.

  2. guix: disable gcov in base-linux-gcc
    In a `x86_64-linux-gnu` build, this drops:
```bash
x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov
x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov-dump
x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov-tool
x86_64-linux-gnu/lib/gcc/x86_64-linux-gnu/12.4.0: libgcov.a
```

For mingw-w64-gcc, `--disable-gcov` is currently passed for this
target in Guix, due to issues with mingw-w64, see
https://github.com/fanquake/guix/blob/8bed031e58c9cf895d243790e7c80808b0075de7/gnu/packages/gcc.scm#L99-L102.
However we'll add it in any case, in case it's re-enabled in future,
when the underlying issues are fixed.
    f6496a8388
  3. DrahtBot commented at 6:21 PM on December 9, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31450.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK TheCharlatan

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Build system on Dec 9, 2024
  5. theuni commented at 9:05 PM on December 9, 2024: member

    lgtm. Any particular reason? Or just dropping unused binaries?

  6. fanquake commented at 10:28 PM on December 9, 2024: member

    @theuni just cleanup atm.

  7. sedited approved
  8. sedited commented at 9:03 AM on December 10, 2024: contributor

    ACK f6496a838828

    Guix build (aarch64):

    c7f2daace2e73fb0bdda835b503800b43f14433bbec11dbb5496591cee1ea46f  guix-build-f6496a838828/output/aarch64-linux-gnu/SHA256SUMS.part
2643f100604d1ee665ca064cc425207e8a230d1a304d008aa7b59b2b9393483e  guix-build-f6496a838828/output/aarch64-linux-gnu/bitcoin-f6496a838828-aarch64-linux-gnu-debug.tar.gz
97e738ed04037c22f8108c5cab82f82f6692eaa90aabe150483ac4e607c4b6da  guix-build-f6496a838828/output/aarch64-linux-gnu/bitcoin-f6496a838828-aarch64-linux-gnu.tar.gz
fe7fd7c244515b8f4d96d6d23439d233f1fa7b924e7dc92be0f480c5f9be78a7  guix-build-f6496a838828/output/arm-linux-gnueabihf/SHA256SUMS.part
c8a00f7d41ca5c00c4162af99790d06c18100df77934a40c32b88f84a22b9d87  guix-build-f6496a838828/output/arm-linux-gnueabihf/bitcoin-f6496a838828-arm-linux-gnueabihf-debug.tar.gz
ad499f5730fdb318dbe01d596369c43453724359b75a8b6f5b1ebaad6bcda99c  guix-build-f6496a838828/output/arm-linux-gnueabihf/bitcoin-f6496a838828-arm-linux-gnueabihf.tar.gz
1c69f6d0c0a6324cf18bb826fa74bb62f679ac9938bbc9abe69f37de44658009  guix-build-f6496a838828/output/arm64-apple-darwin/SHA256SUMS.part
a42b758dbba627c661a9012851b9bfcf5d9f6d7d0407193b4fc904653ac5ffad  guix-build-f6496a838828/output/arm64-apple-darwin/bitcoin-f6496a838828-arm64-apple-darwin-unsigned.tar.gz
6f3ac8e0fe2c52faf5f237c33020bd424c8ed0e512a8ff7f34dff0dbfcf4e7b2  guix-build-f6496a838828/output/arm64-apple-darwin/bitcoin-f6496a838828-arm64-apple-darwin-unsigned.zip
506ff0149e59d640e0dc0f0006f600d43a987c84e3000473db3643b0e9c21bd0  guix-build-f6496a838828/output/arm64-apple-darwin/bitcoin-f6496a838828-arm64-apple-darwin.tar.gz
13293409b1cda85293128f1a5565f9643fe1c74cb0fa9ddb05e968e8ff4230f7  guix-build-f6496a838828/output/dist-archive/bitcoin-f6496a838828.tar.gz
6d9221d1a59968d15a375a35b98c246d78d64291ad4e9c3e097a098ad904bc67  guix-build-f6496a838828/output/powerpc64-linux-gnu/SHA256SUMS.part
c257dd78ef056e0a5e4ea53285e18d5712d197e1a33c41149052744d8598b74a  guix-build-f6496a838828/output/powerpc64-linux-gnu/bitcoin-f6496a838828-powerpc64-linux-gnu-debug.tar.gz
97263e8acad757db69679733824fc2d367842151765878a78351e76b582e589e  guix-build-f6496a838828/output/powerpc64-linux-gnu/bitcoin-f6496a838828-powerpc64-linux-gnu.tar.gz
77bb750fb99a3e697cdc6382a26ca0a91845c4369ff34c55b92407fc865589da  guix-build-f6496a838828/output/riscv64-linux-gnu/SHA256SUMS.part
2d6d628cf1edd50ca4cba6eb329e437493ca32a29601cfe8846b04bfed3791ad  guix-build-f6496a838828/output/riscv64-linux-gnu/bitcoin-f6496a838828-riscv64-linux-gnu-debug.tar.gz
9003283786eed5875f68d2f8c011f9da534322083a90ea1471e926603ff5e617  guix-build-f6496a838828/output/riscv64-linux-gnu/bitcoin-f6496a838828-riscv64-linux-gnu.tar.gz
d6770db009264670cc5f8008a5fcd9fbf1e966c9cd66228ea9c2b75dff3e60bc  guix-build-f6496a838828/output/x86_64-apple-darwin/SHA256SUMS.part
e7826f022d910a6dcdc38f6390fcc17df7c9f6ae4c17eaa77a73d645e012463f  guix-build-f6496a838828/output/x86_64-apple-darwin/bitcoin-f6496a838828-x86_64-apple-darwin-unsigned.tar.gz
5e4c3fde07e8a0224576439b6b0ba1f91548997d8c0bf56dd36f51a75bef63b9  guix-build-f6496a838828/output/x86_64-apple-darwin/bitcoin-f6496a838828-x86_64-apple-darwin-unsigned.zip
162c86eff3c8331feef54b8eb33b45d3e25723cb36c65b28e32db3194f1707c2  guix-build-f6496a838828/output/x86_64-apple-darwin/bitcoin-f6496a838828-x86_64-apple-darwin.tar.gz
8042ee7ff8fd9653de2cb72a629812a9e616163e7a83d890e6d88612d1273ddb  guix-build-f6496a838828/output/x86_64-linux-gnu/SHA256SUMS.part
caea65a89be6fd11a7fd4f5c6b5a6c7c83e9539585815a8e4b32f915e73f1527  guix-build-f6496a838828/output/x86_64-linux-gnu/bitcoin-f6496a838828-x86_64-linux-gnu-debug.tar.gz
09852839744b5f8813d2dd668a3f0df59106f228f7fa31c5d91183f8a37e4683  guix-build-f6496a838828/output/x86_64-linux-gnu/bitcoin-f6496a838828-x86_64-linux-gnu.tar.gz
17c2242fc37582668a7feff0552c94424106a65a33104a153d1b48698602f578  guix-build-f6496a838828/output/x86_64-w64-mingw32/SHA256SUMS.part
415e9e843d0a43e7a3485fe17a95ed19679dc4f52db4e0a1c48df799cd227f3b  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64-debug.zip
dd5a1a8d4279c6f5860ec3579bdb7b69c5d54910608c9cbf23ab782880acc343  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64-setup-unsigned.exe
9e400fbfe1e1be62d4965adeba9ec75fadd062905c797162b233804b9c3e9259  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64-unsigned.tar.gz
a39328f89f3ea2497ccc8ada94119e1622d44b04ff105b22249b010fe1eacdaa  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64.zip
  9. fanquake commented at 1:53 PM on December 10, 2024: member

    Guix Build (x86_64):

    c7f2daace2e73fb0bdda835b503800b43f14433bbec11dbb5496591cee1ea46f  guix-build-f6496a838828/output/aarch64-linux-gnu/SHA256SUMS.part
2643f100604d1ee665ca064cc425207e8a230d1a304d008aa7b59b2b9393483e  guix-build-f6496a838828/output/aarch64-linux-gnu/bitcoin-f6496a838828-aarch64-linux-gnu-debug.tar.gz
97e738ed04037c22f8108c5cab82f82f6692eaa90aabe150483ac4e607c4b6da  guix-build-f6496a838828/output/aarch64-linux-gnu/bitcoin-f6496a838828-aarch64-linux-gnu.tar.gz
fe7fd7c244515b8f4d96d6d23439d233f1fa7b924e7dc92be0f480c5f9be78a7  guix-build-f6496a838828/output/arm-linux-gnueabihf/SHA256SUMS.part
c8a00f7d41ca5c00c4162af99790d06c18100df77934a40c32b88f84a22b9d87  guix-build-f6496a838828/output/arm-linux-gnueabihf/bitcoin-f6496a838828-arm-linux-gnueabihf-debug.tar.gz
ad499f5730fdb318dbe01d596369c43453724359b75a8b6f5b1ebaad6bcda99c  guix-build-f6496a838828/output/arm-linux-gnueabihf/bitcoin-f6496a838828-arm-linux-gnueabihf.tar.gz
1c69f6d0c0a6324cf18bb826fa74bb62f679ac9938bbc9abe69f37de44658009  guix-build-f6496a838828/output/arm64-apple-darwin/SHA256SUMS.part
a42b758dbba627c661a9012851b9bfcf5d9f6d7d0407193b4fc904653ac5ffad  guix-build-f6496a838828/output/arm64-apple-darwin/bitcoin-f6496a838828-arm64-apple-darwin-unsigned.tar.gz
6f3ac8e0fe2c52faf5f237c33020bd424c8ed0e512a8ff7f34dff0dbfcf4e7b2  guix-build-f6496a838828/output/arm64-apple-darwin/bitcoin-f6496a838828-arm64-apple-darwin-unsigned.zip
506ff0149e59d640e0dc0f0006f600d43a987c84e3000473db3643b0e9c21bd0  guix-build-f6496a838828/output/arm64-apple-darwin/bitcoin-f6496a838828-arm64-apple-darwin.tar.gz
13293409b1cda85293128f1a5565f9643fe1c74cb0fa9ddb05e968e8ff4230f7  guix-build-f6496a838828/output/dist-archive/bitcoin-f6496a838828.tar.gz
6d9221d1a59968d15a375a35b98c246d78d64291ad4e9c3e097a098ad904bc67  guix-build-f6496a838828/output/powerpc64-linux-gnu/SHA256SUMS.part
c257dd78ef056e0a5e4ea53285e18d5712d197e1a33c41149052744d8598b74a  guix-build-f6496a838828/output/powerpc64-linux-gnu/bitcoin-f6496a838828-powerpc64-linux-gnu-debug.tar.gz
97263e8acad757db69679733824fc2d367842151765878a78351e76b582e589e  guix-build-f6496a838828/output/powerpc64-linux-gnu/bitcoin-f6496a838828-powerpc64-linux-gnu.tar.gz
77bb750fb99a3e697cdc6382a26ca0a91845c4369ff34c55b92407fc865589da  guix-build-f6496a838828/output/riscv64-linux-gnu/SHA256SUMS.part
2d6d628cf1edd50ca4cba6eb329e437493ca32a29601cfe8846b04bfed3791ad  guix-build-f6496a838828/output/riscv64-linux-gnu/bitcoin-f6496a838828-riscv64-linux-gnu-debug.tar.gz
9003283786eed5875f68d2f8c011f9da534322083a90ea1471e926603ff5e617  guix-build-f6496a838828/output/riscv64-linux-gnu/bitcoin-f6496a838828-riscv64-linux-gnu.tar.gz
d6770db009264670cc5f8008a5fcd9fbf1e966c9cd66228ea9c2b75dff3e60bc  guix-build-f6496a838828/output/x86_64-apple-darwin/SHA256SUMS.part
e7826f022d910a6dcdc38f6390fcc17df7c9f6ae4c17eaa77a73d645e012463f  guix-build-f6496a838828/output/x86_64-apple-darwin/bitcoin-f6496a838828-x86_64-apple-darwin-unsigned.tar.gz
5e4c3fde07e8a0224576439b6b0ba1f91548997d8c0bf56dd36f51a75bef63b9  guix-build-f6496a838828/output/x86_64-apple-darwin/bitcoin-f6496a838828-x86_64-apple-darwin-unsigned.zip
162c86eff3c8331feef54b8eb33b45d3e25723cb36c65b28e32db3194f1707c2  guix-build-f6496a838828/output/x86_64-apple-darwin/bitcoin-f6496a838828-x86_64-apple-darwin.tar.gz
8042ee7ff8fd9653de2cb72a629812a9e616163e7a83d890e6d88612d1273ddb  guix-build-f6496a838828/output/x86_64-linux-gnu/SHA256SUMS.part
caea65a89be6fd11a7fd4f5c6b5a6c7c83e9539585815a8e4b32f915e73f1527  guix-build-f6496a838828/output/x86_64-linux-gnu/bitcoin-f6496a838828-x86_64-linux-gnu-debug.tar.gz
09852839744b5f8813d2dd668a3f0df59106f228f7fa31c5d91183f8a37e4683  guix-build-f6496a838828/output/x86_64-linux-gnu/bitcoin-f6496a838828-x86_64-linux-gnu.tar.gz
17c2242fc37582668a7feff0552c94424106a65a33104a153d1b48698602f578  guix-build-f6496a838828/output/x86_64-w64-mingw32/SHA256SUMS.part
415e9e843d0a43e7a3485fe17a95ed19679dc4f52db4e0a1c48df799cd227f3b  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64-debug.zip
dd5a1a8d4279c6f5860ec3579bdb7b69c5d54910608c9cbf23ab782880acc343  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64-setup-unsigned.exe
9e400fbfe1e1be62d4965adeba9ec75fadd062905c797162b233804b9c3e9259  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64-unsigned.tar.gz
a39328f89f3ea2497ccc8ada94119e1622d44b04ff105b22249b010fe1eacdaa  guix-build-f6496a838828/output/x86_64-w64-mingw32/bitcoin-f6496a838828-win64.zip
  10. fanquake merged this on Dec 11, 2024
  11. fanquake closed this on Dec 11, 2024
  12. fanquake deleted the branch on Dec 11, 2024
  13. hebasto commented at 3:55 PM on December 22, 2024: member

    Post-merge ACK f6496a838828aa6d5a2a40380c2338fda2e0d812.

  14. sedited referenced this in commit 230a439a4a on Jan 17, 2025
  15. stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
  16. stickies-v referenced this in commit cc83553352 on Mar 17, 2025
  17. stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
  18. stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
  19. stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
  20. bug-castercv502 referenced this in commit 44b075fe71 on Sep 28, 2025
  21. knst referenced this in commit 63724c2454 on Oct 22, 2025
  22. bitcoin locked this on Dec 22, 2025
Contributors
fanquakeDrahtBottheuniseditedhebasto
Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 06:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me