CI: Cmake warnings should be errors #31476

1. 
   maflcko commented at 8:30 am on December 12, 2024: member

   It is brittle to silently ignore Cmake warnings in the CI.

   They should be turned into errors.

   This will uncover an issue in the centos task that the correct python version is missing. I guess this should be fixed by installing and activating an acceptable python version.

2. maflcko added the label Build system on Dec 12, 2024
3. maflcko added the label CI failed on Dec 12, 2024
4. fanquake added this to the milestone 29.0 on Dec 12, 2024
5. fanquake referenced this in commit 78f1bff709 on Dec 13, 2024
6. 
   hebasto commented at 11:47 am on December 13, 2024: member

   It is brittle to silently ignore Cmake warnings in the CI.

   They should be turned into errors.

   When building with Berkeley DB > 4.8, this warning will be always emitted: https://github.com/bitcoin/bitcoin/blob/78f1bff7099b854bb71e57d0307b8c21a1ac32c5/CMakeLists.txt#L107-L109

7. 
   maflcko commented at 11:57 am on December 13, 2024: member

   I guess I was mostly thinking about configure_warnings.

   An alternative would be to require python to be disabled explicitly. Otherwise, it seems odd that every setting in cmake has a static default that can only be overridden explicitly, except for some, which are silently downgraded?

Contributors
maflcko hebasto

Labels
Build system CI failed

Milestone
29.0