depends: update capnproto to 1.0.2 #31484

1. 
   fanquake commented at 5:25 pm on December 12, 2024: member

   This fixes compilation on FreeBSD:

    0-- Build files have been written to: /tmp/cirrus-ci-build/bitcoin-core/depends/work/build/x86_64-unknown-freebsd14.0/native_capnp/1.0.1-867405dd2c4
    1Building native_capnp...
    2gmake[1]: Entering directory '/tmp/cirrus-ci-build/bitcoin-core/depends/work/build/x86_64-unknown-freebsd14.0/native_capnp/1.0.1-867405dd2c4'
    3[ 1%] Building CXX object src/kj/CMakeFiles/kj.dir/array.c++.o
    4[ 2%] Building CXX object src/kj/CMakeFiles/kj.dir/cidr.c++.o
    5/tmp/cirrus-ci-build/bitcoin-core/depends/work/build/x86_64-unknown-freebsd14.0/native_capnp/1.0.1-867405dd2c4/src/kj/cidr.c++:112:71: error: member access into incomplete type 'const struct sockaddr_in6'
    6otherBits = reinterpret_cast<const struct sockaddr_in6*>(addr)->sin6_addr.s6_addr;
    7^
    8/tmp/cirrus-ci-build/bitcoin-core/depends/work/build/x86_64-unknown-freebsd14.0/native_capnp/1.0.1-867405dd2c4/src/kj/cidr.c++:112:51: note: forward declaration of 'sockaddr_in6'
    9otherBits = reinterpret_cast<const struct sockaddr_in6*>(addr)->sin6_addr.s6_addr;
   10^
   11/tmp/cirrus-ci-build/bitcoin-core/depends/work/build/x86_64-unknown-freebsd14.0/native_capnp/1.0.1-867405dd2c4/src/kj/cidr.c++:123:63: error: member access into incomplete type 'const struct sockaddr_in'
   12&reinterpret_cast<const struct sockaddr_in*>(addr)->sin_addr.s_addr);
   13^
   14/tmp/cirrus-ci-build/bitcoin-core/depends/work/build/x86_64-unknown-freebsd14.0/native_capnp/1.0.1-867405dd2c4/src/kj/cidr.c++:123:44: note: forward declaration of 'sockaddr_in'
   15&reinterpret_cast<const struct sockaddr_in*>(addr)->sin_addr.s_addr);
   16^
   17/tmp/cirrus-ci-build/bitcoin-core/depends/work/build/x86_64-unknown-freebsd14.0/native_capnp/1.0.1-867405dd2c4/src/kj/cidr.c++:133:69: error: member access into incomplete type 'const struct sockaddr_in6'
   18otherBits = reinterpret_cast<const struct sockaddr_in6*>(addr)->sin6_addr.s6_addr;
   19^
   20/tmp/cirrus-ci-build/bitcoin-core/depends/work/build/x86_64-unknown-freebsd14.0/native_capnp/1.0.1-867405dd2c4/src/kj/cidr.c++:133:49: note: forward declaration of 'sockaddr_in6'
   21otherBits = reinterpret_cast<const struct sockaddr_in6*>(addr)->sin6_addr.s6_addr;
   22^
   233 errors generated.
   

   See: https://github.com/capnproto/capnproto/commit/1c19c362b4733023dc38042481a21c22502ed593.

2. depends: update capnproto to 1.0.2

   This fixes compilation on FreeBSD.
   See:
   https://github.com/capnproto/capnproto/commit/1c19c362b4733023dc38042481a21c22502ed593.

   5cd9e95eea
3. 
   DrahtBot commented at 5:25 pm on December 12, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31484.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	theuni, ryanofsky
   Concept ACK	kevkevinpal

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Build system on Dec 12, 2024
5. 
   kevkevinpal commented at 5:54 pm on December 12, 2024: contributor

   Concept ACK 5cd9e95

   Also I validated the sha256 hash by doing the following

   0wget https://capnproto.org/capnproto-c++-1.0.2.tar.gz -O capnproto-cxx-1.0.2.tar.gz
   1sha256sum capnproto-cxx-1.0.2.tar.gz
   

   output: 9057dbc0223366b74bbeca33a05de164a229b0377927f1b7ef3828cdd8cb1d7e capnproto-cxx-1.0.2.tar.gz

6. theuni approved
7. 
   theuni commented at 8:49 pm on December 12, 2024: member

   utACK 5cd9e95eea12fddd2a1a668d509f0a5b6e267516

   Code changes from 1.0.1 to 1.0.2 are easy to review. Standard simple fixes.

8. ryanofsky approved
9. 
   ryanofsky commented at 10:19 pm on December 12, 2024: contributor

   Code review ACK 5cd9e95eea12fddd2a1a668d509f0a5b6e267516. Downloaded the file and checked the hash. Also followed theuni’s lead and looked at the source changes which were very minor. It did look like thousands of lines changed in the autotools build, but this should not affect us as we are using the cmake build.
10. fanquake merged this on Dec 13, 2024
11. fanquake closed this on Dec 13, 2024

    ---

12. fanquake deleted the branch on Dec 13, 2024
13. 
    hebasto commented at 8:30 am on December 14, 2024: member

    Post-merge ACK 5cd9e95eea12fddd2a1a668d509f0a5b6e267516, tested on FreeBSD 14.2 as follows:

    0gmake -C depends capnp MULTIPROCESS=1
    

14. 
    hebasto commented at 9:44 am on December 14, 2024: member

    This fixes compilation on FreeBSD

    The build on OpenBSD still fails, but it is resolved in https://github.com/capnproto/capnproto/pull/1907.

Contributors
fanquake DrahtBot kevkevinpal theuni ryanofsky hebasto

Labels
Build system