Currently the libstdc++ debug mode can only be used with version 11, or 15 (and later), due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117966
This seems restrictive.
Add a temporary workaround for now, which makes the global (temporary) std::span local to a lambda.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31493.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
191 | @@ -192,7 +192,10 @@ int ecdsa_signature_parse_der_lax(secp256k1_ecdsa_signature* sig, const unsigned 192 | * For an example script for calculating H, refer to the unit tests in 193 | * ./test/functional/test_framework/crypto/secp256k1.py 194 | */ 195 | -constexpr XOnlyPubKey XOnlyPubKey::NUMS_H{"50929b74c1a04954b78b4b6035e97a5e078a5a0f28ec96d547bfee9ace803ac0"_hex_u8}; 196 | +constexpr XOnlyPubKey XOnlyPubKey::NUMS_H{
Nice hack. Could use consteval on the lambda to enforce compile-time
constexpr XOnlyPubKey XOnlyPubKey::NUMS_H{
// Use immediate lambda to work around GCC-14 bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117966
[]() consteval { return XOnlyPubKey{"50929b74c1a04954b78b4b6035e97a5e078a5a0f28ec96d547bfee9ace803ac0"_hex_u8}; }(),
};
I left it out to let the compiler decide whether to use it or not, just like before.
Though, pushed consteval now, thx!
Concept ACK
utACK fa9e0489f57968945d54ef56b275f51540f3e5e4
191 | @@ -192,7 +192,10 @@ int ecdsa_signature_parse_der_lax(secp256k1_ecdsa_signature* sig, const unsigned 192 | * For an example script for calculating H, refer to the unit tests in 193 | * ./test/functional/test_framework/crypto/secp256k1.py 194 | */ 195 | -constexpr XOnlyPubKey XOnlyPubKey::NUMS_H{"50929b74c1a04954b78b4b6035e97a5e078a5a0f28ec96d547bfee9ace803ac0"_hex_u8}; 196 | +constexpr XOnlyPubKey XOnlyPubKey::NUMS_H{ 197 | + // Use immediate lambda to work around GCC-14 bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117966
nit: GCC-12 and GCC-13 seem also affected.
That is documented in the link and PR description.
nit: GCC-12 and GCC-13 seem also affected.
The code is intentional, to only mention the last version of gcc where the workaround is needed. I don't see the value to mention more than that.
ACK fa9e0489f57968945d54ef56b275f51540f3e5e4, tested on Ubuntu 24.10.
ACK fa9e0489f57968945d54ef56b275f51540f3e5e4