[Qt] addressbookpage: make addressbookpage use message() / remove optionsmodel #3157

pull Diapolo wants to merge 3 commits into bitcoin:master from Diapolo:addressbookpage changing 6 files +34 −34

Diapolo commented at 4:59 PM on October 26, 2013: none

Related to #3159 and #3160 (same changes for transactionview and walletview).

Goal: Harmonize user experience for export of addresses, transactions and backup of the wallet!
addressbookpage: remove unused optionsmodel stuff 85eb1a6645

addressbookpage: add message() signal

- allow to use message() in addressbookpage by connecting to the
  message() signal in WalletView
- needs to change the model in setModel() from AddressTableModel to
  WalletModel

534f8b4f6d

addressbookpage: make on_exportButton_clicked() use message()

- use message() for displaying success or failure of export
- rework the strings to be more detailed / informative
- additional small cleanups

f2949a9c3f

BitcoinPullTester commented at 7:21 PM on October 26, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f2949a9c3f26f84c4611c8dde44d5567605700a7 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 8:00 AM on October 31, 2013: member

As I mentioned somewhere else: AddressBookPage is supposed to be a standalone dialog that can be launched from anywhere, so I'd prefer not making it dependent on connecting signals.
Diapolo commented at 4:40 PM on October 31, 2013: none

Yeah, I'm going to rework this, to not use mesage(), that way as it seems impossible to do it in a clean way and it's a standalone dialog, as you also said. It's a tad sad that my invention breaks the coding-rules somehow, but I'm happy you appreciated this :-).

What about a message() function (not signal) in GUIUtil, perhaps nearly a copy of the one in BitcoinGUI (so we have a unified user experience and API)? Just a quick thought...
laanwj commented at 1:47 PM on November 11, 2013: member

@Diapolo I suppose what could work is pass in the Notificator object, and move the message() function/slot there. A global function in GUIUtil would not work, it wouldn't have access to the Notificator.
Diapolo commented at 4:49 PM on November 13, 2013: none

@laanwj How should I access the notificator pointer, it's included in BitcoinGUI also :-/.

I still have no clue, how your suggestion should be implemented ^^.
laanwj commented at 8:14 AM on January 21, 2014: member

Closing this for now
laanwj closed this on Jan 21, 2014
Bushstar referenced this in commit 21d33dd56d on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

BitcoinPullTester

laanwj

Linked (view graph)

#3158 GUIUtil: make getSaveFileName() use native OS path separators #3159 [Qt] transactionview: make transactionview use message()#3160 [Qt] walletview: make backupWallet() use GUIUtil::getSaveFileName()