GUIUtil: make getSaveFileName() use native OS path separators #3158

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:guiutil changing 1 files +5 −5

Diapolo commented at 5:07 PM on October 26, 2013: none

Important for #3157, #3159 and #3160.
GUIUtil: make getSaveFileName() use native OS path separators 444fd65f66
BitcoinPullTester commented at 6:09 PM on October 26, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/444fd65f662159d4618eb80cf2a9f0ec2ca24c33 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

in src/qt/guiutil.cpp:None in 444fd65f66

 240 | @@ -242,7 +241,8 @@ QString getSaveFileName(QWidget *parent, const QString &caption,
 241 |      {
 242 |          myDir = dir;
 243 |      }
 244 | -    QString result = QFileDialog::getSaveFileName(parent, caption, myDir, filter, &selectedFilter);
 245 | +    /* Directly convert path to native OS path separators */
 246 | +    QString result = QDir::toNativeSeparators(QFileDialog::getSaveFileName(parent, caption, myDir, filter, &selectedFilter));

laanwj commented at 8:23 AM on October 27, 2013:

Strange that this is needed, I wonder why QFileDialog::getSaveFileName doesn't return native OS path separators by default.

laanwj referenced this in commit aa5822f9c3 on Oct 27, 2013
laanwj merged this on Oct 27, 2013
laanwj closed this on Oct 27, 2013
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

BitcoinPullTester

laanwj

Linked (view graph)

#3157 [Qt] addressbookpage: make addressbookpage use message() / remove optionsmodel #3159 [Qt] transactionview: make transactionview use message()#3160 [Qt] walletview: make backupWallet() use GUIUtil::getSaveFileName()