[Qt] transactionview: make transactionview use message() #3159

pull Diapolo wants to merge 2 commits into bitcoin:master from Diapolo:transactionsview changing 3 files +19 −11

Diapolo commented at 5:24 PM on October 26, 2013: none

Related to #3157 and #3160 (same changes for addressbookpage and walletview).

Goal: Harmonize user experience for export of addresses, transactions and backup of the wallet!

transactionview: add message() signal

- allow to use message() in transactionview by connecting to the
  message() signal in WalletView

868d3ee5ac

transactionview: make exportClicked() use message()

- use message() for displaying success or failure of export
- rework the strings to be more detailed / informative
- additional small cleanups

9eb4ab66bf

in src/qt/transactionview.cpp:None in 66b81a3baa outdated
```
 181 | @@ -182,6 +182,9 @@ void TransactionView::setModel(WalletModel *model)
 182 |          transactionView->horizontalHeader()->setSectionResizeMode(TransactionTableModel::ToAddress, QHeaderView::Stretch);
 183 |  #endif
 184 |          transactionView->horizontalHeader()->resizeSection(TransactionTableModel::Amount, 100);
 185 | +
 186 | +        // Receive and forward messages (WalletModel is used for passing through message())
 187 | +        connect(this, SIGNAL(message(QString,QString,unsigned int)), model, SIGNAL(message(QString,QString,unsigned int)));
```
laanwj commented at 3:07 PM on October 30, 2013:

As I mentioned before, don't use the model as a conduit to pass messages through. I must say it's inventive, but it hides what is really happening. If you want a message signal on TransactionView (which is a good idea), make the WalletView subscribe to it.

Diapolo commented at 3:09 PM on October 30, 2013:

Yeah I know I have to do this, before this can be merged :). It's far more work/tricky for the AddressBookPage, as this is used in very different files (other related pull).

laanwj commented at 3:22 PM on October 30, 2013:

AddressBookPage is only used as a standalone dialog, not as part of the main GUI, so it also makes less sense there.
Diapolo commented at 9:45 PM on October 30, 2013: none
Updated:
- moved connect() to WalletView :)
BitcoinPullTester commented at 10:27 PM on October 30, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9eb4ab66bf581a75e82713640de669b93a84d9f7 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit ede3ee3348 on Oct 31, 2013
laanwj merged this on Oct 31, 2013
laanwj closed this on Oct 31, 2013
Bushstar referenced this in commit 859d60f818 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester

Linked (view graph)

#3157 [Qt] addressbookpage: make addressbookpage use message() / remove optionsmodel #3158 GUIUtil: make getSaveFileName() use native OS path separators #3160 [Qt] walletview: make backupWallet() use GUIUtil::getSaveFileName()