On Illumos-based systems, such as OpenIndiana and OmniOS, the assumption that “the default zone ID of 0 can be omitted for the default scope” is incorrect. As a result, getaddrinfo("fe80::1%0", ...) returns the EAI_NONAME error instead of resolving to “fe80::1”.
See: https://www.illumos.org/man/3SOCKET/getaddrinfo.
This PR removes the problematic code introduced in #19951.
On Illumos-based systems, such as OpenIndiana and SmartOS, the
assumption that "the default zone ID of 0 can be omitted for the default
scope" is incorrect. As a result, `getaddrinfo("fe80::1%0", ...)`
returns the `EAI_NONAME` error.
See: https://www.illumos.org/man/3SOCKET/getaddrinfo.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31580.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | fanquake |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Is there a way to skip the test for Illumos-based platforms?
I’ve verified both OpenIndiana and OmniOS. The __illumos__ macro is defined to 1 in both.
i think this makes sense, relying on a “default scope” is brittle at most. Better to add the interface number explicitly. We don’t use that anywhere in our code outside the test, right? If so i think it’s okay to remove this test unconditionally.
Or to say: it’s OS specific functionality, apparently, and it can still be used. But it is not required, and thus no test is required to ensure that it is available.
And the only way i can see this possibly comes up, is when the user specifies such addresses on the command line, or through RPC when connecting to a peer manually.
