[28.x] Finalize 28.1 #31582

1. 
   achow101 commented at 5:58 PM on December 30, 2024: member

   No description provided.

2. build: bump to 28.1 2d90a7198e
3. doc: generate 28.1 manpages 2a87869461
4. doc: Update 28.1 release notes 898db487f3
5. 
   DrahtBot commented at 5:58 PM on December 30, 2024: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31582.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	glozow, maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

6. DrahtBot added the label Backport on Dec 30, 2024
7. in configure.ac:7 in 898db487f3

      1 | @@ -2,7 +2,7 @@ AC_PREREQ([2.69])
      2 |  define(_CLIENT_VERSION_MAJOR, 28)
      3 |  define(_CLIENT_VERSION_MINOR, 1)
      4 |  define(_CLIENT_VERSION_BUILD, 0)
      5 | -define(_CLIENT_VERSION_RC, 2)
      6 | +define(_CLIENT_VERSION_RC, 0)
      7 |  define(_CLIENT_VERSION_IS_RELEASE, true)
      8 |  define(_COPYRIGHT_YEAR, 2024)
   

   ---

   ---

   

   glozow commented at 12:27 PM on January 2, 2025:

   Should this be 2025?

   ---

   

   maflcko commented at 12:33 PM on January 2, 2025:

   I think no code from 2025 was backported, so this seems fine to keep as-is for now.

8. 
   glozow commented at 12:28 PM on January 2, 2025: member

   ACK 898db487f3f4b4ec131e46cb66ab01b35de2c4c7 unless copyright year should be changed

9. 
   maflcko commented at 12:33 PM on January 2, 2025: member

   lgtm ACK 898db487f3f4b4ec131e46cb66ab01b35de2c4c7

10. 
    fanquake commented at 12:38 PM on January 2, 2025: member

    There are still things tagged for backport for 28.x that haven't been backported.

11. maflcko added this to the milestone 28.1 on Jan 2, 2025
12. 
    maflcko commented at 1:27 PM on January 2, 2025: member

    There are still things tagged for backport for 28.x that haven't been backported.

    Fixed in https://github.com/bitcoin/bitcoin/pull/31594

13. 
    achow101 commented at 4:45 PM on January 3, 2025: member

    Closing in favor of https://github.com/bitcoin/bitcoin/pull/31594

14. achow101 closed this on Jan 3, 2025

    ---

15. bitcoin locked this on Jan 3, 2026

Contributors

achow101DrahtBotglozowmaflckofanquake

Milestone
28.1