This is a follow-up to fa47baa03bcfcf44fb2ed05f009a32d32f860c45, which bumped the gcc version to avoid a warning bloat in the CI log. However, it is also required to bump python3, see #31476#issue-2735206340
This will uncover an issue in the centos task that the correct python version is missing. I guess this should be fixed by installing and activating an acceptable python version.
Instead of bumping the packages individually in centos stream 9, just bump to stream 10.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31593.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | fanquake |
| Concept ACK | davidgumberg, hebasto |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
WITH_PYTHON build option by hebasto)If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
https://cirrus-ci.com/task/4631012182851584
0[10:35:39.510] + bash -c 'dnf -y --allowerasing install gcc-c++ glibc-devel.x86_64 libstdc++-devel.x86_64 glibc-devel.i686 libstdc++-devel.i686 ccache make git python3 python3-pip which patch lbzip2 xz procps-ng dash rsync coreutils bison e2fsprogs cmake '
1[10:35:40.618] Extra Packages for Enterprise Linux 10 - x86_64 3.7 MB/s | 3.1 MB 00:00
2[10:35:41.599] Last metadata expiration check: 0:00:01 ago on Mon Jan 6 05:35:40 2025.
3[10:35:42.086] No match for argument: glibc-devel.i686
4[10:35:42.091] No match for argument: libstdc++-devel.i686
5[10:35:42.095] Package python3-3.12.8-2.el10.x86_64 is already installed.
6[10:35:42.099] No match for argument: lbzip2
7[10:35:42.105] No match for argument: dash
8[10:35:42.120] Error: Unable to find a match: glibc-devel.i686 libstdc++-devel.i686 lbzip2 dash
9[10:35:42.272] Error: building at STEP "RUN bash -c cd /ci_container_base/ && set -o errexit && source ./ci/test/00_setup_env.sh && ./ci/test/01_base_install.sh": while running runtime: exit status 1
Yeah, it is blocked on https://bugzilla.redhat.com/show_bug.cgi?id=2335616.
Also, I am thinking it is fine to drop the 32-bit build, given that it is mostly redundant with ci/test/00_setup_env_i686_multiprocess.sh anyway.
Concept ACK
The CentOS Stream 9 CI task as-is uses the core python3 packages which are 3.9, below the minimum 3.10 and results in a syntax error any time test/functional/combine_logs.py is invoked since it uses a match statement.
It seems that CMake has been complaining in every single centos CI run1 since the minimum version was bumped to 3.10, I wonder why that hasn’t resulted in CI failure.
Edit: I’ve opened #31665 to make configuration errors fatal in CI.
dash into EPEL 10: https://bugzilla.redhat.com/show_bug.cgi?id=2335416
Upstream tracking issue for branching and adding
dashinto EPEL 10 is here: https://bugzilla.redhat.com/show_bug.cgi?id=2335416
Thx, used ksh for now (temporarily)
