ci: Turn CentOS task into native one #31651

1. 
   maflcko commented at 10:55 pm on January 13, 2025: member

   Cross-compiling to i686-pc-linux-gnu on CentOS in the CI is mostly redundant with the ci/test/00_setup_env_i686_multiprocess.sh task (albeit it using clang):

   https://github.com/bitcoin/bitcoin/blob/35bf426e02210c1bbb04926f4ca2e0285fbfcd11/ci/test/00_setup_env_i686_multiprocess.sh#L9-L12

   One task seems sufficient as a sanity check, given that there seems to be no real demand for this architecture anyway.

   Turning the task into a native one makes it possible to run the task natively on aarch64 or any other supported architecture.

   Also, remove the install of the lbzip2 package, which is unused since commit a46065e36cf868265c909dc5edf29dc17be53c1f

   Also, remove the CONFIG_SHELL env var, which is unused since the cmake migration. (CONFIG_SHELL in depends is still kept).

2. ci: Turn CentOS task into native one fabefd9915
3. 
   DrahtBot commented at 10:55 pm on January 13, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31651.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	davidgumberg, hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #31669 (cmake: Introduce WITH_PYTHON build option by hebasto)
   • #31657 (ci: Supply --platform argument to docker commands. by davidgumberg)
   • #31349 (ci: detect outbound internet traffic generated while running tests by vasild)
   • #31176 (ci: Test cross-built Windows executables on Windows natively by hebasto)
   • #30997 (build: Switch to Qt 6 by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Tests on Jan 13, 2025
5. 
   Sjors commented at 12:20 pm on January 14, 2025: member

   Tested on my self-hosted Cirrus setup, seems fine: https://cirrus-ci.com/task/6297483418009600
6. 
   davidgumberg commented at 2:57 am on January 15, 2025: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/31651/commits/fabefd9915802d53d8c83ae66e5cb259196d9422

   Ran locally and all tests passed.

   0env -i HOME="$HOME" PATH="$PATH" USER="$USER" bash -c 'FILE_ENV="./ci/test/00_setup_env_native_centos.sh" ./ci/test_run_all.sh'
   

7. 
   maflcko commented at 10:05 am on January 16, 2025: member

   For reference, multiprocess was turned into i686, because the centos task didn’t find one issue, see #22923

   cc @hebasto

8. 
   hebasto commented at 10:14 am on January 16, 2025: member

   Turning the task into a native one makes it easier to run it on aarch64 or any other supported architecture.

   Mind elaborating “easier to run it on aarch64”?

9. 
   maflcko commented at 10:17 am on January 16, 2025: member

   Turning the task into a native one makes it easier to run it on aarch64 or any other supported architecture.

   Mind elaborating “easier to run it on aarch64”?

   Thanks, replaced “easier” with “possible”, because with current master it is not possible to run the task natively. (Since it is not a native task).

10. in .cirrus.yml:143 in fabefd9915

    139@@ -140,13 +140,13 @@ task:
    140     FILE_ENV: "./ci/test/00_setup_env_win64.sh"
    141 
    142 task:
    143-  name: '32-bit CentOS, dash, gui'
    144+  name: 'CentOS, dash, gui'
    

    ---

    ---

    

    hebasto commented at 10:31 am on January 16, 2025:

    Shouldn’t “depends” be mentioned here for consistency with other task names?

    ---

    

    maflcko commented at 10:53 am on January 16, 2025:

    Thx, will add in the follow-up, which touches this anyway

    ---

    

    maflcko commented at 2:34 pm on January 17, 2025:

    thx, fixed in https://github.com/bitcoin/bitcoin/pull/31593
11. hebasto approved
12. 
    hebasto commented at 10:32 am on January 16, 2025: member

    ACK fabefd9915802d53d8c83ae66e5cb259196d9422, tested locally on Ubuntu 24.10.
13. maflcko requested review from fanquake on Jan 17, 2025
14. 
    fanquake commented at 11:39 am on January 17, 2025: member

    Tested on aarch64.
15. fanquake merged this on Jan 17, 2025
16. fanquake closed this on Jan 17, 2025

    ---

17. maflcko deleted the branch on Jan 17, 2025

Contributors
maflcko DrahtBot Sjors davidgumberg hebasto fanquake

Review Requested
fanquake

Labels
Tests