multi-peer orphan resolution followups #31666

1. 
   glozow commented at 11:49 pm on January 15, 2025: member

   Followup to #31397.

   Addressing (in order): #31397 (review) #31397 (review) #31397 (review) #31397 (review) #31397 (review) #31397 (review) #31397 (review) #31658#pullrequestreview-2551617694 #31397 (review)

2. glozow added the label P2P on Jan 15, 2025
3. 
   DrahtBot commented at 11:49 pm on January 15, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31666.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   No conflicts as of last run.

4. glozow force-pushed on Jan 16, 2025
5. glozow force-pushed on Jan 16, 2025
6. glozow force-pushed on Jan 16, 2025
7. glozow marked this as ready for review on Jan 16, 2025
8. DrahtBot added the label CI failed on Jan 17, 2025
9. [refactor] helper function for adding orphan parents to txrequest b0446cc347
10. [refactor] make GetCandidatePeers take uint256 and in-out vector

    The txrequest fuzzer uses uint256s, not transactions, so it's best if
    GetCandidatePeers takes that as an input.

    ac880a0b16
11. [fuzz] GetCandidatePeers 2237163b3c
12. multi-announcer orphan handling test fixups 6475a36010
13. [refactor] assign local variable for wtxid 33c6159f32
14. [doc] how unique_parents can be empty a99065bd29
15. pass P2PTxInvStore init args to P2PInterface init cfe03d69e1
16. test fix: make peer who sends MSG_TX announcement non-wtxidrelay

    Otherwise, it is not meaningful to test whether the announcement is
    ignored, because *all* announcements of this type are ignored.

    6260f8314c
17. [p2p] assign just 1 random announcer in AddChildrenToWorkSet d5abec74a2
18. glozow force-pushed on Jan 18, 2025
19. 
    glozow commented at 1:42 pm on January 18, 2025: member

    Rebased for #31675 which fixes https://cirrus-ci.com/task/5200590696873984
20. DrahtBot removed the label CI failed on Jan 18, 2025

Contributors
glozow DrahtBot

Labels
P2P