Fix compilation errors in blockchain.cpp related to serialization, UTXO dumping, and path conversion #31735

pull krishpranav wants to merge 2 commits into bitcoin:master from krishpranav:master changing 2 files +100 −0
  1. krishpranav commented at 2:06 pm on January 25, 2025: none

    issue: #31373

    updated path conversion logic to handle std::string to fs::path, and addressing undeclared identifiers such as DumpUTXOSet.

  2. rpc: blockchain[dumptxoutset] b12390da2d
  3. test: functional[rpc_dumptxoutset_pipe] 91dbe67297
  4. DrahtBot commented at 2:06 pm on January 25, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31735.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept NACK l0rinc, i-am-yuvi

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. DrahtBot added the label CI failed on Jan 25, 2025
  6. DrahtBot commented at 2:10 pm on January 25, 2025: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/36165560973

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  7. l0rinc commented at 2:47 pm on January 25, 2025: contributor
    NACK
  8. i-am-yuvi commented at 1:47 pm on January 27, 2025: contributor
    NACK
  9. fanquake commented at 1:52 pm on January 27, 2025: member
    See #31560.
  10. fanquake closed this on Jan 27, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-22 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me