[WIP] leveldb: pull upstream C++23 changes #31766

1. 
   fanquake commented at 2:01 pm on January 30, 2025: member

   PR to test https://github.com/bitcoin-core/leveldb-subtree/pull/47 in our CI.

   Cherry-picks two commits from upstream (https://github.com/google/leveldb/commit/302786e211d1f2e6fd260261f642d03a91e5922c, https://github.com/google/leveldb/commit/e829478c6a3a55d8e5c1227e2678dcc18d518609), which remove the usage of std::aligned_storage/std::aligned_union.

   Note the first cherry-pick is not clean, because due to Google tooling issues, it accidently contained a revert of the prior two commits. See https://github.com/google/leveldb/pull/1249 for more details.

   Also see https://issues.chromium.org/issues/388068052, although note that they reverted the roll to latest leveldb. I’m guessing due to the acidental reversion issue above.

2. Squashed 'src/leveldb/' changes from 04b5790928..183e79a495

   183e79a495 Fix speculatively some "placement new" issues in leveldb
   82c31046ed Fix C++23 compilation errors in leveldb
   
   git-subtree-dir: src/leveldb
   git-subtree-split: 183e79a495d4e19c539cf1d64498106972c0ee6b

   f833cb4242
3. ci: remove -Wno-error=deprecated-declarations from ASAN

   This is no-longer needed after the changes to leveldb.

   229181ba9d
4. 
   DrahtBot commented at 2:01 pm on January 30, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31766.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   No conflicts as of last run.

5. 
   DrahtBot commented at 3:00 pm on January 30, 2025: contributor

   🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/36420557428

   Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

   • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

   • An intermittent issue.

   Leave a comment here, if you need help tracking down a confusing failure.

6. DrahtBot added the label CI failed on Jan 30, 2025
7. 
   victorvianna commented at 5:48 pm on January 30, 2025: none

   FYI the upstream PR landed

Contributors
fanquake DrahtBot victorvianna

Labels
CI failed