test: added additional coverage to waitforblock and waitforblockheight rpc’s #31784

1. 
   kevkevinpal commented at 2:11 pm on February 3, 2025: contributor

   Similar to #31746

   This adds test coverage to the waitforblock and waitforblockheight rpc’s by adding a test to assert we get an rpc error if we include a negative timeout

2. test: added additional coverage to waitforblock and waitforblockheight rpc's 7e0db87d4f
3. 
   DrahtBot commented at 2:11 pm on February 3, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31784.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	Prabhat1308, Sjors, brunoerg, BrandonOdiwuor

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Feb 3, 2025
5. Prabhat1308 approved
6. 
   Prabhat1308 commented at 9:15 pm on February 3, 2025: contributor

   ACK 7e0db87

   Good to have error handling for negative timeout scenarios since both of the functions depend on it.

7. 
   Sjors commented at 12:15 pm on February 4, 2025: member

   utACK 7e0db87d4fff996c086f6e86b62338c98ef30c55
8. brunoerg approved
9. 
   brunoerg commented at 5:10 pm on February 4, 2025: contributor

   code review ACK 7e0db87d4fff996c086f6e86b62338c98ef30c55
10. BrandonOdiwuor approved
11. 
    BrandonOdiwuor commented at 6:14 am on February 5, 2025: contributor

    Code Review ACK 7e0db87d4fff996c086f6e86b62338c98ef30c55
12. fanquake merged this on Feb 5, 2025
13. fanquake closed this on Feb 5, 2025

    ---

14. sedited referenced this in commit f78a01a560 on Feb 22, 2025
15. stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
16. stickies-v referenced this in commit cc83553352 on Mar 17, 2025
17. stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
18. stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
19. stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
20. bug-castercv502 referenced this in commit d15545ffaa on Sep 28, 2025
21. bitcoin locked this on Feb 5, 2026

Contributors
kevkevinpal DrahtBot Prabhat1308 Sjors brunoerg BrandonOdiwuor

Labels
Tests