Similar to #31746
This adds test coverage to the waitforblock
and waitforblockheight
rpc’s by adding a test to assert we get an rpc error if we include a negative timeout
Similar to #31746
This adds test coverage to the waitforblock
and waitforblockheight
rpc’s by adding a test to assert we get an rpc error if we include a negative timeout
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31784.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
ACK | Prabhat1308, Sjors, brunoerg, BrandonOdiwuor |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
ACK 7e0db87
Good to have error handling for negative timeout scenarios since both of the functions depend on it.