test: added additional coverage to waitforblock and waitforblockheight rpc’s #31784

pull kevkevinpal wants to merge 1 commits into bitcoin:master from kevkevinpal:moreTimeoutTests changing 1 files +2 −0
  1. kevkevinpal commented at 2:11 pm on February 3, 2025: contributor

    Similar to #31746

    This adds test coverage to the waitforblock and waitforblockheight rpc’s by adding a test to assert we get an rpc error if we include a negative timeout

  2. test: added additional coverage to waitforblock and waitforblockheight rpc's 7e0db87d4f
  3. DrahtBot commented at 2:11 pm on February 3, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31784.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK Prabhat1308, Sjors, brunoerg, BrandonOdiwuor

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Feb 3, 2025
  5. Prabhat1308 approved
  6. Prabhat1308 commented at 9:15 pm on February 3, 2025: none

    ACK 7e0db87

    Good to have error handling for negative timeout scenarios since both of the functions depend on it.

  7. Sjors commented at 12:15 pm on February 4, 2025: member
    utACK 7e0db87d4fff996c086f6e86b62338c98ef30c55
  8. brunoerg approved
  9. brunoerg commented at 5:10 pm on February 4, 2025: contributor
    code review ACK 7e0db87d4fff996c086f6e86b62338c98ef30c55
  10. BrandonOdiwuor approved
  11. BrandonOdiwuor commented at 6:14 am on February 5, 2025: contributor
    Code Review ACK 7e0db87d4fff996c086f6e86b62338c98ef30c55
  12. fanquake merged this on Feb 5, 2025
  13. fanquake closed this on Feb 5, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-07 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me