Move rpc/external_signer from bitcoin_common to bitcoin_node.
Remove the check-deps suppression.
build: move `rpc/external_signer` to node library #31865
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:move_external_signer_node changing 2 files +1 −4-
fanquake commented at 3:45 PM on February 14, 2025: member
-
build: move rpc/external_signer to node library e501246e77
-
DrahtBot commented at 3:45 PM on February 14, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31865.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko, TheCharlatan, achow101 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #30437 (multiprocess: add bitcoin-mine test program by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Build system on Feb 14, 2025
-
maflcko commented at 4:12 PM on February 14, 2025: member
lgtm ACK e501246e77cc36cff222fb07aed2fd1316e11e19
- TheCharlatan approved
-
TheCharlatan commented at 4:43 PM on February 14, 2025: contributor
ACK e501246e77cc36cff222fb07aed2fd1316e11e19
-
achow101 commented at 10:20 PM on February 14, 2025: member
ACK e501246e77cc36cff222fb07aed2fd1316e11e19
- achow101 merged this on Feb 14, 2025
- achow101 closed this on Feb 14, 2025
- fanquake deleted the branch on Feb 15, 2025
-
hebasto commented at 7:42 AM on February 16, 2025: member
Post-merge ACK e501246e77cc36cff222fb07aed2fd1316e11e19.
Labels