test: remove scanning check on wallet_importdescriptors #31893

pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2025-02-fix-test-intermittent changing 1 files +0 −8
  1. brunoerg commented at 9:41 pm on February 17, 2025: contributor
    Reverts recently merged #31768 due to CI failures, see issue #31881.
  2. DrahtBot commented at 9:41 pm on February 17, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31893.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hodlinator, BrandonOdiwuor, theStack

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Tests on Feb 17, 2025
  4. test: remove scanning check on `wallet_importdescriptors` 405dd0e647
  5. brunoerg force-pushed on Feb 17, 2025
  6. DrahtBot commented at 9:44 pm on February 17, 2025: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/37363998745

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  7. DrahtBot added the label CI failed on Feb 17, 2025
  8. hodlinator approved
  9. hodlinator commented at 10:07 pm on February 17, 2025: contributor

    cr-ACK 405dd0e647e4ed0402320917a06128eb69504655

    PR description

    May cause intermittent issues. See: #31881

    Could be a bit clearer, along the lines of:

    Reverts recently merged #31768 due to CI failures, see issue #31881.

  10. brunoerg commented at 10:11 pm on February 17, 2025: contributor
    Thanks, @hodlinator. I updated the description.
  11. DrahtBot removed the label CI failed on Feb 17, 2025
  12. BrandonOdiwuor commented at 5:35 am on February 18, 2025: contributor
    Code Review ACK 405dd0e647e4ed0402320917a06128eb69504655
  13. maflcko added this to the milestone 29.0 on Feb 18, 2025
  14. theStack approved
  15. theStack commented at 2:15 pm on February 18, 2025: contributor
    ACK 405dd0e647e4ed0402320917a06128eb69504655
  16. fanquake merged this on Feb 18, 2025
  17. fanquake closed this on Feb 18, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-22 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me