Reverts recently merged #31768 due to CI failures, see issue #31881.
test: remove scanning check on `wallet_importdescriptors` #31893
pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2025-02-fix-test-intermittent changing 1 files +0 −8-
brunoerg commented at 9:41 PM on February 17, 2025: contributor
-
DrahtBot commented at 9:41 PM on February 17, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31893.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hodlinator, BrandonOdiwuor, theStack If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Feb 17, 2025
-
test: remove scanning check on `wallet_importdescriptors` 405dd0e647
- brunoerg force-pushed on Feb 17, 2025
-
DrahtBot commented at 9:44 PM on February 17, 2025: contributor
<!--85328a0da195eb286784d51f73fa0af9-->
🚧 At least one of the CI tasks failed. <sub>Debug: https://github.com/bitcoin/bitcoin/runs/37363998745</sub>
<details><summary>Hints</summary>
Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
</details>
- DrahtBot added the label CI failed on Feb 17, 2025
- hodlinator approved
-
hodlinator commented at 10:07 PM on February 17, 2025: contributor
-
brunoerg commented at 10:11 PM on February 17, 2025: contributor
Thanks, @hodlinator. I updated the description.
- DrahtBot removed the label CI failed on Feb 17, 2025
-
BrandonOdiwuor commented at 5:35 AM on February 18, 2025: contributor
Code Review ACK 405dd0e647e4ed0402320917a06128eb69504655
- maflcko added this to the milestone 29.0 on Feb 18, 2025
- theStack approved
-
theStack commented at 2:15 PM on February 18, 2025: contributor
ACK 405dd0e647e4ed0402320917a06128eb69504655
- fanquake merged this on Feb 18, 2025
- fanquake closed this on Feb 18, 2025