depends: Update libmultiprocess library to fix CI failures #31945

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/bumptree2 changing 1 files +2 −2
  1. ryanofsky commented at 12:57 pm on February 24, 2025: contributor

    Bump libmultiprocess library to include bugfix https://github.com/chaincodelabs/libmultiprocess/pull/159 which should fix intermittent CI failures reported in #31921

    This change is bumping the libmultiprocess version instead of cherry picking the bugfix. It could cherry-pick the bugfix instead, but there are reasons to prefer bumping the version:

    • Bugfix might interact with earlier PRs, and the latest version is better tested with testing done in many CI configurations in #30975 and #31802

    • Even though we are in feature freeze for a release, the MULTIPROCESS=1 option is currently not enabled for release, so this PR only affect CI builds and local builds, not the release build.

    This update brings in the following changes:

    https://github.com/chaincodelabs/libmultiprocess/pull/140 build: don’t clobber user/superproject c++ version https://github.com/chaincodelabs/libmultiprocess/pull/142 build: add option for external mpgen binary https://github.com/chaincodelabs/libmultiprocess/pull/143 cleanup: initialize vars in the EventLoop constructor in the correct order https://github.com/chaincodelabs/libmultiprocess/pull/146 cmake: Suppress compiler warnings from capnproto headers https://github.com/chaincodelabs/libmultiprocess/pull/147 cmake: EXTERNAL_MPGEN cleanups https://github.com/chaincodelabs/libmultiprocess/pull/148 util: fix -Wpessimizing-move warning https://github.com/chaincodelabs/libmultiprocess/pull/145 CTest: Module must be included at the top level https://github.com/chaincodelabs/libmultiprocess/pull/149 Avoid -Wundef compiler warnings https://github.com/chaincodelabs/libmultiprocess/pull/152 refactor: Fix compiler and clang-tidy warnings https://github.com/chaincodelabs/libmultiprocess/pull/155 scripted-diff: s/Libmultiprocess_EXTERNAL_MPGEN/MPGEN_EXECUTABLE/g https://github.com/chaincodelabs/libmultiprocess/pull/156 refactor: Remove locale-dependent function calls https://github.com/chaincodelabs/libmultiprocess/pull/157 refactor: Avoid using std::format https://github.com/chaincodelabs/libmultiprocess/pull/159 bugfix: Do not lock EventLoop::mutex after EventLoop is done https://github.com/chaincodelabs/libmultiprocess/pull/161 cmake: Avoid including CTest if not top level project https://github.com/chaincodelabs/libmultiprocess/pull/164 Bump minimum required cmake to 3.12


    This PR is part of the process separation project.

  2. depends: Update libmultiprocess library to fix CI failure
    Bump libmultiprocess library to include bugfix
    https://github.com/chaincodelabs/libmultiprocess/pull/159 which should fix
    intermittent CI failures reported in
    https://github.com/bitcoin/bitcoin/issues/31921
    
    This change is bumping the libmultiprocess version instead of cherry picking
    the bugfix. It could cherry-pick the bugfix instead, but there are reasons to
    prefer bumping the version:
    
    - Bugfix might interact with earlier PRs, and the latest version is better
      tested with testing done in many CI configurations in #30975 and #31802
    
    - Even though we are in feature freeze for a release, the MULTIPROCESS=1 option
      is currently not enabled for release, so this PR only affect CI builds and
      local builds, not the release build.
    
    This update brings in the following changes:
    
    https://github.com/chaincodelabs/libmultiprocess/pull/140 build: don't clobber user/superproject c++ version
    https://github.com/chaincodelabs/libmultiprocess/pull/142 build: add option for external mpgen binary
    https://github.com/chaincodelabs/libmultiprocess/pull/143 cleanup: initialize vars in the EventLoop constructor in the correct order
    https://github.com/chaincodelabs/libmultiprocess/pull/146 cmake: Suppress compiler warnings from capnproto headers
    https://github.com/chaincodelabs/libmultiprocess/pull/147 cmake: EXTERNAL_MPGEN cleanups
    https://github.com/chaincodelabs/libmultiprocess/pull/148 util: fix -Wpessimizing-move warning
    https://github.com/chaincodelabs/libmultiprocess/pull/145 CTest: Module must be included at the top level
    https://github.com/chaincodelabs/libmultiprocess/pull/149 Avoid `-Wundef` compiler warnings
    https://github.com/chaincodelabs/libmultiprocess/pull/152 refactor: Fix compiler and clang-tidy warnings
    https://github.com/chaincodelabs/libmultiprocess/pull/155 scripted-diff: s/Libmultiprocess_EXTERNAL_MPGEN/MPGEN_EXECUTABLE/g
    https://github.com/chaincodelabs/libmultiprocess/pull/156 refactor: Remove locale-dependent function calls
    https://github.com/chaincodelabs/libmultiprocess/pull/157 refactor: Avoid using std::format
    https://github.com/chaincodelabs/libmultiprocess/pull/159 bugfix: Do not lock EventLoop::mutex after EventLoop is done
    https://github.com/chaincodelabs/libmultiprocess/pull/161 cmake: Avoid including CTest if not top level project
    https://github.com/chaincodelabs/libmultiprocess/pull/164 Bump minimum required cmake to 3.12
    01f7715766
  3. DrahtBot commented at 12:57 pm on February 24, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31945.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Build system on Feb 24, 2025
  5. ryanofsky force-pushed on Feb 24, 2025
  6. maflcko added the label Tests on Feb 24, 2025
  7. maflcko added this to the milestone 29.0 on Feb 24, 2025
  8. maflcko removed the label Tests on Feb 24, 2025
  9. maflcko requested review from Sjors on Feb 24, 2025
  10. ryanofsky force-pushed on Feb 24, 2025
  11. fanquake approved
  12. fanquake commented at 2:45 pm on February 25, 2025: member
    ACK 01f771576608403dbfc5dee4fcdd84ef262f9390
  13. fanquake merged this on Feb 25, 2025
  14. fanquake closed this on Feb 25, 2025

  15. hebasto commented at 5:26 pm on March 4, 2025: member
    Post-merge ACK 01f771576608403dbfc5dee4fcdd84ef262f9390.


ryanofsky DrahtBot fanquake hebasto


Sjors

Labels
Build system

Milestone
29.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-03-10 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me