For when we shift libmultiprocess into the bitcoin-core organisation.
scripted-diff: rename libmultiprocess repository #31982
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:rename_multiprocess changing 3 files +7 −7-
fanquake commented at 11:33 AM on March 4, 2025: member
-
18749efb07
scripted-diff: rename libmultiprocess repository
-BEGIN VERIFY SCRIPT- sed -i -e "s/chaincodelabs\/libmultiprocess/bitcoin-core\/libmultiprocess/g" $(git grep -l "chaincodelabs/libmultiprocess") -END VERIFY SCRIPT-
-
DrahtBot commented at 11:33 AM on March 4, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31982.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #31802 (Add bitcoin-{node,gui} to release binaries for IPC by Sjors)
- #31741 (multiprocess: Add libmultiprocess git subtree by ryanofsky)
- #30975 (ci: build multiprocess on most jobs by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Refactoring on Mar 4, 2025
-
Sjors commented at 12:03 PM on March 4, 2025: member
Concept ACK
-
hebasto commented at 1:18 PM on March 4, 2025: member
Concept ACK.
-
fanquake commented at 2:06 PM on March 5, 2025: member
I've made the transfer. See https://github.com/bitcoin-core/libmultiprocess.
- fanquake marked this as ready for review on Mar 5, 2025
-
Sjors commented at 2:17 PM on March 5, 2025: member
tACK 18749efb07266da5fc8d5a5786ace23d5a42a816
I tested by having depends make
MULTIPROCESS=1and it fetches it from the new place.Note that on master it works fine too, because there's a redirect (for now):
wget https://github.com/chaincodelabs/libmultiprocess/archive/1954f7f65661d49e700c344eae0fc8092decf975.tar.gz - DrahtBot requested review from hebasto on Mar 5, 2025
- hebasto approved
-
hebasto commented at 2:21 PM on March 5, 2025: member
ACK 18749efb07266da5fc8d5a5786ace23d5a42a816.
-
fanquake commented at 2:22 PM on March 5, 2025: member
- hebasto merged this on Mar 5, 2025
- hebasto closed this on Mar 5, 2025
- fanquake deleted the branch on Mar 5, 2025
Labels