doc: Bring reduce-memory.md up to date #31985

1. 
   laanwj commented at 2:29 pm on March 4, 2025: member

   Update default number of RPC threads to 16 (#31215) and remove reference to very old version of bitcoin core.

   Let me know if you notice other mismatches with current defaults.

2. laanwj added the label Docs on Mar 4, 2025
3. laanwj added this to the milestone 29.0 on Mar 4, 2025
4. 
   DrahtBot commented at 2:29 pm on March 4, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31985.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	brunoerg, TheCharlatan, vasild, achow101
   Stale ACK	dergoegge

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. laanwj force-pushed on Mar 4, 2025
6. doc: Bring reduce-memory.md up to date

   Update default number of RPC threads to 16 (#31215) and remove reference
   to very old version of bitcoin core.

   fff4f93dff
7. laanwj force-pushed on Mar 4, 2025
8. dergoegge approved
9. 
   dergoegge commented at 2:39 pm on March 4, 2025: member

   ACK 4bb2eae061c9ed0c20e2a435145bf77c9b3601cc - 16 matches the DEFAULT_HTTP_THREADS constant.
10. brunoerg approved
11. 
    brunoerg commented at 2:46 pm on March 4, 2025: contributor

    ACK fff4f93dff8ba67689e43929615e3c63c67015e4
12. DrahtBot requested review from dergoegge on Mar 4, 2025
13. TheCharlatan approved
14. 
    TheCharlatan commented at 2:49 pm on March 4, 2025: contributor

    ACK fff4f93dff8ba67689e43929615e3c63c67015e4
15. 
    fanquake commented at 2:50 pm on March 4, 2025: member

    Let me know if you notice other mismatches with current defaults.

    In this file “The minimum value for -dbcache is 4.” However it’s entirely possible to run bitcoind with -dbcache=1. Maybe that line can just be dropped?

16. 
    laanwj commented at 2:52 pm on March 4, 2025: member

    In this file “The minimum value for -dbcache is 4.” However it’s entirely possible to run bitcoind with -dbcache=1. Maybe that line can just be dropped?

    Could be removed if it’s not longer correct, but to be clear: 4 here was meant here as the minimum effective value, not the minimum value that would be accepted as command line argument.

    Edit, seems that still holds:

    0//! min. -dbcache (bytes)
    1static constexpr size_t MIN_DB_CACHE{4_MiB};
    

17. vasild approved
18. 
    vasild commented at 2:55 pm on March 4, 2025: contributor

    ACK fff4f93dff8ba67689e43929615e3c63c67015e4
19. 
    fanquake commented at 2:58 pm on March 4, 2025: member

    not the minimum value that would be accepted as command line argument.

    Should we make this function like maxmempool, which will fail to accept a value lower than the minimim (5)? Seems we are somewhat inconsistent in our handling of these.

20. achow101 assigned achow101 on Mar 4, 2025
21. 
    achow101 commented at 7:35 pm on March 4, 2025: member

    ACK fff4f93dff8ba67689e43929615e3c63c67015e4
22. achow101 merged this on Mar 4, 2025
23. achow101 closed this on Mar 4, 2025

    ---

24. 
    laanwj commented at 12:16 pm on March 5, 2025: member

    Should we make this function like maxmempool, which will fail to accept a value lower than the minimim (5)? Seems we are somewhat inconsistent in our handling of these.

    Yes, probably. It’s pretty much always better for user communication to fail for wrong values than to silently interpret them as something else.

    (although we have to be careful around the GUI to not create a user lock-out situation like bitcoin-core/gui#843 )

Contributors
laanwj DrahtBot dergoegge brunoerg TheCharlatan fanquake vasild achow101

Review Requested
dergoegge

Labels
Docs

Milestone
29.0