wallet: Replace “non-0” with “non-zero” in translatable error message #31987

1. 
   hebasto commented at 4:31 pm on March 4, 2025: member

   Transifex interprets the “-0” substring as a number in translatable strings. Since not all translations preserve “-0,” this triggers a corresponding warning. While this warning could be disabled globally, it is more reasonable to adjust the original string instead.
2. wallet: Replace "non-0" with "non-zero" in translatable error message

   Transifex interprets the "-0" substring as a number in translatable
   strings. Since not all translations preserve "-0," this triggers a
   corresponding warning. While this warning could be disabled globally, it
   is more reasonable to adjust the original string instead.

   18e83534ac
3. hebasto added the label Wallet on Mar 4, 2025
4. hebasto added this to the milestone 30.0 on Mar 4, 2025
5. 
   DrahtBot commented at 4:31 pm on March 4, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31987.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	davidgumberg, 1440000bytes, l0rinc, BrandonOdiwuor, laanwj

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

6. 
   davidgumberg commented at 6:04 pm on March 4, 2025: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/31987/commits/18e83534ace7aa2d26bc7dfa521b1d591b66edfa
7. 
   l0rinc commented at 6:16 pm on March 4, 2025: contributor

   Concept ACK

   Since not all translations preserve “-0,” this triggers a corresponding warning

   How complicated would it be to align the other translations instead?

8. 
   hebasto commented at 6:24 pm on March 4, 2025: member

   Concept ACK

   Since not all translations preserve “-0,” this triggers a corresponding warning

   How complicated would it be to align the other translations instead?

   It depends on the language. I cannot say about all of them.

9. bitcoin deleted a comment on Mar 4, 2025
10. 
    1440000bytes commented at 7:56 pm on March 4, 2025: none

    ACK https://github.com/bitcoin/bitcoin/pull/31987/commits/18e83534ace7aa2d26bc7dfa521b1d591b66edfa

    Apart from the translation issue, non-0 looks incorrect for an error message. I have seen ’non-zero’ or ’nonzero’ or ’non zero’ in english but never ’non-0'.

11. DrahtBot requested review from l0rinc on Mar 4, 2025
12. 
    l0rinc commented at 11:43 pm on March 4, 2025: contributor

    How come https://github.com/bitcoin/bitcoin/blob/18e83534ace7aa2d26bc7dfa521b1d591b66edfa/src/qt/bitcoinstrings.cpp#L216 wasn’t updated
13. DrahtBot requested review from l0rinc on Mar 4, 2025
14. 
    hebasto commented at 10:17 am on March 5, 2025: member

    How come

    https://github.com/bitcoin/bitcoin/blob/18e83534ace7aa2d26bc7dfa521b1d591b66edfa/src/qt/bitcoinstrings.cpp#L216 wasn’t updated

    Because https://github.com/bitcoin/bitcoin/blob/18e83534ace7aa2d26bc7dfa521b1d591b66edfa/src/qt/bitcoinstrings.cpp#L5

15. 
    l0rinc commented at 10:41 am on March 5, 2025: contributor

    Automatically generated by extract_strings_qt

    Yes, but it’s committed, so shouldn’t we update or regenerate it now?

16. 
    hebasto commented at 11:37 am on March 5, 2025: member

    Automatically generated by extract_strings_qt

    Yes, but it’s committed, so shouldn’t we update or regenerate it now?

    Sure. It will be regenerated during the release process, but not for 29.0 as we are behind the string freeze.

17. 
    l0rinc commented at 2:11 pm on March 5, 2025: contributor

    ACK 18e83534ace7aa2d26bc7dfa521b1d591b66edfa

    While I would prefer changing the extracted strings here, it’s not very important.

18. 
    BrandonOdiwuor commented at 1:03 pm on March 7, 2025: contributor

    Code Review ACK 18e83534ace7aa2d26bc7dfa521b1d591b66edfa
19. laanwj approved
20. 
    laanwj commented at 3:08 pm on March 10, 2025: member

    Code review ACK 18e83534ace7aa2d26bc7dfa521b1d591b66edfa Aside from the issue raised, this makes the message more readable.
21. in src/wallet/spend.cpp:1139 in 18e83534ac

    1137@@ -1138,7 +1138,7 @@ static util::Result<CreatedTransactionResult> CreateTransactionInternal(
    1138     // This can only happen if feerate is 0, and requested destinations are value of 0 (e.g. OP_RETURN)
    1139     // and no pre-selected inputs. This will result in 0-input transaction, which is consensus-invalid anyways
    

    ---

    ---

    

    yancyribbens commented at 0:32 am on March 11, 2025:

    0    // and no pre-selected inputs. This will result in zero-input transaction, which is consensus-invalid anyways
    

22. hebasto merged this on Mar 12, 2025
23. hebasto closed this on Mar 12, 2025

    ---

24. hebasto deleted the branch on Mar 12, 2025

Contributors
hebasto DrahtBot davidgumberg l0rinc 1440000bytes BrandonOdiwuor laanwj yancyribbens

Review Requested
l0rinc

Labels
Wallet

Milestone
30.0