ci: rename imagefile to Dockerfile to follow docker file’s convention. #31995

1. 
   eval-exec commented at 1:02 pm on March 5, 2025: contributor

   I’m reviewing bitcoin’s ci/lint instructions, I found some docker image files are named as “_imagefile”. And some docker image files are named as “.Dockerfile”.

   I think we should name “_imagefile” to “.Dockerfile” to keep consistency. Friendly invite fanquake to review this. Thank you.

   https://docs.docker.com/build/concepts/dockerfile/

    0$ fd imagefile
    1ci/lint_imagefile
    2ci/test_imagefile
    3
    4$ fd Dockerfile
    5src/minisketch/ci/linux-debian.Dockerfile
    6src/secp256k1/ci/linux-debian.Dockerfile
    7
    8$ rg -. test_imagefile
    9ci/test/02_run_container.sh
   1051:      --file "${BASE_READ_ONLY_DIR}/ci/test_imagefile" \
   11
   12$ rg -. lint_imagefile
   13test/lint/README.md
   1410:DOCKER_BUILDKIT=1 docker build -t bitcoin-linter --file "./ci/lint_imagefile" ./ && docker run --rm -v $(pwd):/bitcoin -it bitcoin-linter
   15
   16$ mv ci/lint_imagefile ci/lint.Dockerfile
   17
   18$ mv ci/test_imagefile ci/test.Dockerfile
   

2. 
   DrahtBot commented at 1:02 pm on March 5, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31995.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

3. DrahtBot added the label Tests on Mar 5, 2025
4. ci: rename imagefile to Dockerfile

   Signed-off-by: Eval EXEC <execvy@gmail.com>

   8a954374d0
5. eval-exec force-pushed on Mar 5, 2025
6. DrahtBot added the label CI failed on Mar 5, 2025
7. eval-exec renamed this:
   ci: rename imagefile to Dockerfile
   ci: rename imagefile to Dockerfile to follow docker file's convention.
   on Mar 5, 2025
8. 
   fanquake commented at 1:22 pm on March 5, 2025: member

   And some docker image files are named as “.Dockerfile”.

   These are from subtrees.

   I don’t think there’s anything to do here. Note that also don’t need to use Docker, you can also use podman.

9. 
   eval-exec commented at 1:33 pm on March 5, 2025: contributor

   Thanks for your response!

   These are from subtrees.

   Where is subtrees.

   I don’t think there’s anything to do here. Note that also don’t need to use Docker, you can also use podman.

   I just think it would be better to keep the image file names consistent. And, podman call it Containerfile. https://docs.podman.io/en/v5.3.0/markdown/podman-build.1.html

10. 
    fanquake commented at 1:39 pm on March 5, 2025: member

    Where is subtrees.

    https://github.com/bitcoin-core/secp256k1 https://github.com/sipa/minisketch

    I just think it would be better to keep the image file names consistent.

    Ours are consistently named {name}_imagefile. There’s no requirement that we are consistent with files from other repositories.

11. 
    eval-exec commented at 1:42 pm on March 5, 2025: contributor

    Thanks for clarifying. I appreciate it.
12. eval-exec closed this on Mar 5, 2025

    ---

Contributors
eval-exec DrahtBot fanquake

Labels
Tests CI failed