ci: rename imagefile to Dockerfile to follow docker file's convention. #31995

I'm reviewing bitcoin's ci/lint instructions, I found some docker image files are named as "_imagefile". And some docker image files are named as ".Dockerfile".

I think we should name "_imagefile" to ".Dockerfile" to keep consistency. Friendly invite fanquake to review this. Thank you.

https://docs.docker.com/build/concepts/dockerfile/

$ fd imagefile
ci/lint_imagefile
ci/test_imagefile

$ fd Dockerfile
src/minisketch/ci/linux-debian.Dockerfile
src/secp256k1/ci/linux-debian.Dockerfile

$ rg -. test_imagefile
ci/test/02_run_container.sh
51:      --file "${BASE_READ_ONLY_DIR}/ci/test_imagefile" \

$ rg -. lint_imagefile
test/lint/README.md
10:DOCKER_BUILDKIT=1 docker build -t bitcoin-linter --file "./ci/lint_imagefile" ./ && docker run --rm -v $(pwd):/bitcoin -it bitcoin-linter

$ mv ci/lint_imagefile ci/lint.Dockerfile

$ mv ci/test_imagefile ci/test.Dockerfile

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31995.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

And some docker image files are named as ".Dockerfile".

These are from subtrees.

I don't think there's anything to do here. Note that also don't need to use Docker, you can also use podman.

Thanks for your response!

These are from subtrees.

Where is subtrees.

I don't think there's anything to do here. Note that also don't need to use Docker, you can also use podman.

I just think it would be better to keep the image file names consistent. And, podman call it Containerfile. https://docs.podman.io/en/v5.3.0/markdown/podman-build.1.html

Where is subtrees.

https://github.com/bitcoin-core/secp256k1 https://github.com/sipa/minisketch

I just think it would be better to keep the image file names consistent.

Ours are consistently named {name}_imagefile. There's no requirement that we are consistent with files from other repositories.

Thanks for clarifying. I appreciate it.